903b83e211
We introduce a patroni_api fixture, defined in tests/conftest.py, which sets up an HTTP server serving files in a temporary directory. The server is itself defined by the PatroniAPI class; it has a 'routes()' context manager method to be used in actual tests to setup expected responses based on specified JSON files. We set up some logging in order to improve debugging. The direct advantage of this is that PatroniResource.rest_api() method is now covered by the test suite. Coverage before this commit: Name Stmts Miss Cover ----------------------------------------------- check_patroni/__init__.py 3 0 100% check_patroni/cli.py 193 18 91% check_patroni/cluster.py 113 0 100% check_patroni/convert.py 23 5 78% check_patroni/node.py 146 1 99% check_patroni/types.py 50 23 54% ----------------------------------------------- TOTAL 528 47 91% and after this commit: Name Stmts Miss Cover ----------------------------------------------- check_patroni/__init__.py 3 0 100% check_patroni/cli.py 193 18 91% check_patroni/cluster.py 113 0 100% check_patroni/convert.py 23 5 78% check_patroni/node.py 146 1 99% check_patroni/types.py 50 9 82% ----------------------------------------------- TOTAL 528 33 94% In actual test functions, we either invoke patroni_api.routes() to configure which JSON file(s) should be served for each endpoint, or we define dedicated fixtures (e.g. cluster_config_has_changed()) to configure this for several test functions or the whole module. The 'old_replica_state' parametrized fixture is used when needed to adjust such fixtures, e.g. in cluster_has_replica_ok(), to modify the JSON content using cluster_api_set_replica_running() (previously in tests/tools.py, now in tests/__init__.py). The dependency on pytest-mock is no longer needed.
205 lines
6.1 KiB
Python
205 lines
6.1 KiB
Python
from pathlib import Path
|
|
from typing import Iterator, Union
|
|
|
|
import pytest
|
|
from click.testing import CliRunner
|
|
|
|
from check_patroni.cli import main
|
|
|
|
from . import PatroniAPI, cluster_api_set_replica_running
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_has_replica_ok(
|
|
patroni_api: PatroniAPI, old_replica_state: bool, datadir: Path, tmp_path: Path
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_has_replica_ok.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
# TODO Lag threshold tests
|
|
@pytest.mark.usefixtures("cluster_has_replica_ok")
|
|
def test_cluster_has_relica_ok(runner: CliRunner, patroni_api: PatroniAPI) -> None:
|
|
result = runner.invoke(main, ["-e", patroni_api.endpoint, "cluster_has_replica"])
|
|
assert result.exit_code == 0
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERHASREPLICA OK - healthy_replica is 2 | healthy_replica=2 srv2_lag=0 srv2_sync=0 srv3_lag=0 srv3_sync=1 sync_replica=1 unhealthy_replica=0\n"
|
|
)
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_has_replica_ok")
|
|
def test_cluster_has_replica_ok_with_count_thresholds(
|
|
runner: CliRunner, patroni_api: PatroniAPI
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_has_replica",
|
|
"--warning",
|
|
"@1",
|
|
"--critical",
|
|
"@0",
|
|
],
|
|
)
|
|
assert result.exit_code == 0
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERHASREPLICA OK - healthy_replica is 2 | healthy_replica=2;@1;@0 srv2_lag=0 srv2_sync=0 srv3_lag=0 srv3_sync=1 sync_replica=1 unhealthy_replica=0\n"
|
|
)
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_has_replica_ok")
|
|
def test_cluster_has_replica_ok_with_sync_count_thresholds(
|
|
runner: CliRunner, patroni_api: PatroniAPI
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_has_replica",
|
|
"--sync-warning",
|
|
"1:",
|
|
],
|
|
)
|
|
assert result.exit_code == 0
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERHASREPLICA OK - healthy_replica is 2 | healthy_replica=2 srv2_lag=0 srv2_sync=0 srv3_lag=0 srv3_sync=1 sync_replica=1;1: unhealthy_replica=0\n"
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_has_replica_ok_lag(
|
|
patroni_api: PatroniAPI, datadir: Path, tmp_path: Path, old_replica_state: bool
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_has_replica_ok_lag.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_has_replica_ok_lag")
|
|
def test_cluster_has_replica_ok_with_count_thresholds_lag(
|
|
runner: CliRunner, patroni_api: PatroniAPI
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_has_replica",
|
|
"--warning",
|
|
"@1",
|
|
"--critical",
|
|
"@0",
|
|
"--max-lag",
|
|
"1MB",
|
|
],
|
|
)
|
|
assert result.exit_code == 0
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERHASREPLICA OK - healthy_replica is 2 | healthy_replica=2;@1;@0 srv2_lag=1024 srv2_sync=0 srv3_lag=0 srv3_sync=0 sync_replica=0 unhealthy_replica=0\n"
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_has_replica_ko(
|
|
patroni_api: PatroniAPI, old_replica_state: bool, datadir: Path, tmp_path: Path
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_has_replica_ko.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_has_replica_ko")
|
|
def test_cluster_has_replica_ko_with_count_thresholds(
|
|
runner: CliRunner, patroni_api: PatroniAPI
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_has_replica",
|
|
"--warning",
|
|
"@1",
|
|
"--critical",
|
|
"@0",
|
|
],
|
|
)
|
|
assert result.exit_code == 1
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERHASREPLICA WARNING - healthy_replica is 1 (outside range @0:1) | healthy_replica=1;@1;@0 srv3_lag=0 srv3_sync=0 sync_replica=0 unhealthy_replica=1\n"
|
|
)
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_has_replica_ko")
|
|
def test_cluster_has_replica_ko_with_sync_count_thresholds(
|
|
runner: CliRunner, patroni_api: PatroniAPI
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_has_replica",
|
|
"--sync-warning",
|
|
"2:",
|
|
"--sync-critical",
|
|
"1:",
|
|
],
|
|
)
|
|
assert result.exit_code == 2
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERHASREPLICA CRITICAL - sync_replica is 0 (outside range 1:) | healthy_replica=1 srv3_lag=0 srv3_sync=0 sync_replica=0;2:;1: unhealthy_replica=1\n"
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_has_replica_ko_lag(
|
|
patroni_api: PatroniAPI, old_replica_state: bool, datadir: Path, tmp_path: Path
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_has_replica_ko_lag.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_has_replica_ko_lag")
|
|
def test_cluster_has_replica_ko_with_count_thresholds_and_lag(
|
|
runner: CliRunner, patroni_api: PatroniAPI
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_has_replica",
|
|
"--warning",
|
|
"@1",
|
|
"--critical",
|
|
"@0",
|
|
"--max-lag",
|
|
"1MB",
|
|
],
|
|
)
|
|
assert result.exit_code == 2
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERHASREPLICA CRITICAL - healthy_replica is 0 (outside range @0:0) | healthy_replica=0;@1;@0 srv2_lag=10241024 srv2_sync=0 srv3_lag=20000000 srv3_sync=0 sync_replica=0 unhealthy_replica=2\n"
|
|
)
|