903b83e211
We introduce a patroni_api fixture, defined in tests/conftest.py, which sets up an HTTP server serving files in a temporary directory. The server is itself defined by the PatroniAPI class; it has a 'routes()' context manager method to be used in actual tests to setup expected responses based on specified JSON files. We set up some logging in order to improve debugging. The direct advantage of this is that PatroniResource.rest_api() method is now covered by the test suite. Coverage before this commit: Name Stmts Miss Cover ----------------------------------------------- check_patroni/__init__.py 3 0 100% check_patroni/cli.py 193 18 91% check_patroni/cluster.py 113 0 100% check_patroni/convert.py 23 5 78% check_patroni/node.py 146 1 99% check_patroni/types.py 50 23 54% ----------------------------------------------- TOTAL 528 47 91% and after this commit: Name Stmts Miss Cover ----------------------------------------------- check_patroni/__init__.py 3 0 100% check_patroni/cli.py 193 18 91% check_patroni/cluster.py 113 0 100% check_patroni/convert.py 23 5 78% check_patroni/node.py 146 1 99% check_patroni/types.py 50 9 82% ----------------------------------------------- TOTAL 528 33 94% In actual test functions, we either invoke patroni_api.routes() to configure which JSON file(s) should be served for each endpoint, or we define dedicated fixtures (e.g. cluster_config_has_changed()) to configure this for several test functions or the whole module. The 'old_replica_state' parametrized fixture is used when needed to adjust such fixtures, e.g. in cluster_has_replica_ok(), to modify the JSON content using cluster_api_set_replica_running() (previously in tests/tools.py, now in tests/__init__.py). The dependency on pytest-mock is no longer needed.
220 lines
6.9 KiB
Python
220 lines
6.9 KiB
Python
from pathlib import Path
|
|
from typing import Iterator, Union
|
|
|
|
import pytest
|
|
from click.testing import CliRunner
|
|
|
|
from check_patroni.cli import main
|
|
|
|
from . import PatroniAPI, cluster_api_set_replica_running
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_node_count_ok(
|
|
patroni_api: PatroniAPI, old_replica_state: bool, datadir: Path, tmp_path: Path
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_node_count_ok.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_node_count_ok")
|
|
def test_cluster_node_count_ok(
|
|
runner: CliRunner, patroni_api: PatroniAPI, old_replica_state: bool
|
|
) -> None:
|
|
result = runner.invoke(main, ["-e", patroni_api.endpoint, "cluster_node_count"])
|
|
assert result.exit_code == 0
|
|
if old_replica_state:
|
|
assert (
|
|
result.output
|
|
== "CLUSTERNODECOUNT OK - members is 3 | healthy_members=3 members=3 role_leader=1 role_replica=2 state_running=3\n"
|
|
)
|
|
else:
|
|
assert (
|
|
result.output
|
|
== "CLUSTERNODECOUNT OK - members is 3 | healthy_members=3 members=3 role_leader=1 role_replica=2 state_running=1 state_streaming=2\n"
|
|
)
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_node_count_ok")
|
|
def test_cluster_node_count_ok_with_thresholds(
|
|
runner: CliRunner, patroni_api: PatroniAPI, old_replica_state: bool
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_node_count",
|
|
"--warning",
|
|
"@0:1",
|
|
"--critical",
|
|
"@2",
|
|
"--healthy-warning",
|
|
"@2",
|
|
"--healthy-critical",
|
|
"@0:1",
|
|
],
|
|
)
|
|
assert result.exit_code == 0
|
|
if old_replica_state:
|
|
assert (
|
|
result.output
|
|
== "CLUSTERNODECOUNT OK - members is 3 | healthy_members=3;@2;@1 members=3;@1;@2 role_leader=1 role_replica=2 state_running=3\n"
|
|
)
|
|
else:
|
|
assert (
|
|
result.output
|
|
== "CLUSTERNODECOUNT OK - members is 3 | healthy_members=3;@2;@1 members=3;@1;@2 role_leader=1 role_replica=2 state_running=1 state_streaming=2\n"
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_node_count_healthy_warning(
|
|
patroni_api: PatroniAPI, old_replica_state: bool, datadir: Path, tmp_path: Path
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_node_count_healthy_warning.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_node_count_healthy_warning")
|
|
def test_cluster_node_count_healthy_warning(
|
|
runner: CliRunner, patroni_api: PatroniAPI, old_replica_state: bool
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_node_count",
|
|
"--healthy-warning",
|
|
"@2",
|
|
"--healthy-critical",
|
|
"@0:1",
|
|
],
|
|
)
|
|
assert result.exit_code == 1
|
|
if old_replica_state:
|
|
assert (
|
|
result.output
|
|
== "CLUSTERNODECOUNT WARNING - healthy_members is 2 (outside range @0:2) | healthy_members=2;@2;@1 members=2 role_leader=1 role_replica=1 state_running=2\n"
|
|
)
|
|
else:
|
|
assert (
|
|
result.output
|
|
== "CLUSTERNODECOUNT WARNING - healthy_members is 2 (outside range @0:2) | healthy_members=2;@2;@1 members=2 role_leader=1 role_replica=1 state_running=1 state_streaming=1\n"
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_node_count_healthy_critical(
|
|
patroni_api: PatroniAPI, old_replica_state: bool, datadir: Path, tmp_path: Path
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_node_count_healthy_critical.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_node_count_healthy_critical")
|
|
def test_cluster_node_count_healthy_critical(
|
|
runner: CliRunner, patroni_api: PatroniAPI
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_node_count",
|
|
"--healthy-warning",
|
|
"@2",
|
|
"--healthy-critical",
|
|
"@0:1",
|
|
],
|
|
)
|
|
assert result.exit_code == 2
|
|
assert (
|
|
result.output
|
|
== "CLUSTERNODECOUNT CRITICAL - healthy_members is 1 (outside range @0:1) | healthy_members=1;@2;@1 members=3 role_leader=1 role_replica=2 state_running=1 state_start_failed=2\n"
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_node_count_warning(
|
|
patroni_api: PatroniAPI, old_replica_state: bool, datadir: Path, tmp_path: Path
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_node_count_warning.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_node_count_warning")
|
|
def test_cluster_node_count_warning(
|
|
runner: CliRunner, patroni_api: PatroniAPI, old_replica_state: bool
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_node_count",
|
|
"--warning",
|
|
"@2",
|
|
"--critical",
|
|
"@0:1",
|
|
],
|
|
)
|
|
assert result.exit_code == 1
|
|
if old_replica_state:
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERNODECOUNT WARNING - members is 2 (outside range @0:2) | healthy_members=2 members=2;@2;@1 role_leader=1 role_replica=1 state_running=2\n"
|
|
)
|
|
else:
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERNODECOUNT WARNING - members is 2 (outside range @0:2) | healthy_members=2 members=2;@2;@1 role_leader=1 role_replica=1 state_running=1 state_streaming=1\n"
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def cluster_node_count_critical(
|
|
patroni_api: PatroniAPI, old_replica_state: bool, datadir: Path, tmp_path: Path
|
|
) -> Iterator[None]:
|
|
path: Union[str, Path] = "cluster_node_count_critical.json"
|
|
if old_replica_state:
|
|
path = cluster_api_set_replica_running(datadir / path, tmp_path)
|
|
with patroni_api.routes({"cluster": path}):
|
|
yield None
|
|
|
|
|
|
@pytest.mark.usefixtures("cluster_node_count_critical")
|
|
def test_cluster_node_count_critical(
|
|
runner: CliRunner, patroni_api: PatroniAPI
|
|
) -> None:
|
|
result = runner.invoke(
|
|
main,
|
|
[
|
|
"-e",
|
|
patroni_api.endpoint,
|
|
"cluster_node_count",
|
|
"--warning",
|
|
"@2",
|
|
"--critical",
|
|
"@0:1",
|
|
],
|
|
)
|
|
assert result.exit_code == 2
|
|
assert (
|
|
result.stdout
|
|
== "CLUSTERNODECOUNT CRITICAL - members is 1 (outside range @0:1) | healthy_members=1 members=1;@2;@1 role_leader=1 state_running=1\n"
|
|
)
|