Fixed the returned values for PDOStatement::getColumnMeta (#946)

This commit is contained in:
Jenny Tam 2019-03-08 11:43:36 -08:00 committed by GitHub
parent d60748e0cd
commit 7309fb90b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1020,7 +1020,7 @@ int pdo_sqlsrv_stmt_get_attr( _Inout_ pdo_stmt_t *stmt, _In_ zend_long attr, _In
// colno - The index of the field for which to return the metadata. // colno - The index of the field for which to return the metadata.
// return_value - zval* consisting of the metadata. // return_value - zval* consisting of the metadata.
// Return: // Return:
// 0 for failure, 1 for success. // FAILURE for failure, SUCCESS for success.
int pdo_sqlsrv_stmt_get_col_meta( _Inout_ pdo_stmt_t *stmt, _In_ zend_long colno, _Inout_ zval *return_value TSRMLS_DC) int pdo_sqlsrv_stmt_get_col_meta( _Inout_ pdo_stmt_t *stmt, _In_ zend_long colno, _Inout_ zval *return_value TSRMLS_DC)
{ {
PDO_RESET_STMT_ERROR; PDO_RESET_STMT_ERROR;
@ -1096,14 +1096,14 @@ int pdo_sqlsrv_stmt_get_col_meta( _Inout_ pdo_stmt_t *stmt, _In_ zend_long colno
} }
catch( core::CoreException& ) { catch( core::CoreException& ) {
return 0; return FAILURE;
} }
catch(...) { catch(...) {
DIE( "pdo_sqlsrv_stmt_get_col_meta: Unknown exception occurred while retrieving metadata." ); DIE( "pdo_sqlsrv_stmt_get_col_meta: Unknown exception occurred while retrieving metadata." );
} }
return 1; return SUCCESS;
} }