From 8e461ca0ee4c0e6dea1b424d7cc4a2b8d8cdc6fd Mon Sep 17 00:00:00 2001 From: Jenny Tam Date: Tue, 12 Oct 2021 14:43:13 -0700 Subject: [PATCH] Use Invoke-WebRequest instead of Msxml2.XMLHTTP for source indexing (#1315) --- buildscripts/indexsymbols.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/buildscripts/indexsymbols.py b/buildscripts/indexsymbols.py index bcf6ffbd..7bc761ef 100644 --- a/buildscripts/indexsymbols.py +++ b/buildscripts/indexsymbols.py @@ -25,7 +25,7 @@ def write_index(index_filename, tag_version): PATH=%var2% SRCSRVTRG=%TARG%\%PDBVERSION%\%fnbksl%(%var2%) SRCURL=https://raw.githubusercontent.com/Microsoft/msphpsql/%SRCVERSION%/source/%PATH% - SRCSRVCMD=powershell -Command "$r=New-Object -ComObject Msxml2.XMLHTTP; $r.open('GET', '%SRCURL%', $false); $r.send(); [io.file]::WriteAllBytes('%SRCSRVTRG%', $r.responseBody)" + SRCSRVCMD=powershell -Command "Invoke-WebRequest -Uri '%SRCURL%' -OutFile '%SRCSRVTRG%'" SRCVERSION=v5.6.0 PDBVERSION=v5.6.0 For example @@ -38,9 +38,7 @@ def write_index(index_filename, tag_version): f.write('SRCSRVTRG=%TARG%\%PDBVERSION%\%fnbksl%(%var2%)' + os.linesep) f.write('SRCURL=https://raw.githubusercontent.com/Microsoft/msphpsql/%SRCVERSION%/source/%PATH%' + os.linesep) f.write('SRCSRVCMD=powershell -Command ') - f.write('\"$r=New-Object -ComObject Msxml2.XMLHTTP; ') - f.write('$r.open(\'GET\', \'%SRCURL%\', $false); ') - f.write('$r.send(); [io.file]::WriteAllBytes(\'%SRCSRVTRG%\', $r.responseBody)\"' + os.linesep) + f.write('\"Invoke-WebRequest -Uri \'%SRCURL%\' -OutFile \'%SRCSRVTRG%\'\"' + os.linesep) f.write('SRCVERSION=' + tag_version + os.linesep) f.write('PDBVERSION=' + tag_version + os.linesep)