Addressed review comments
This commit is contained in:
parent
3c405f4b4c
commit
c676ae06d4
16
CHANGELOG.md
16
CHANGELOG.md
|
@ -7,26 +7,26 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
|
||||||
Updated PECL release packages. Here is the list of updates:
|
Updated PECL release packages. Here is the list of updates:
|
||||||
|
|
||||||
### Added
|
### Added
|
||||||
- Added support for Azure Key Vault for Always Encrypted for basic CRUD functionalities
|
- Added support for Azure Key Vault for Always Encrypted for basic CRUD functionalities such that Always Encrypted feature is also available to Linux or macOS users
|
||||||
- Added support for macOS High Sierra (requires [MS ODBC Driver 17+](https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-2017))
|
- Added support for macOS High Sierra (requires [MS ODBC Driver 17+](https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-2017))
|
||||||
|
|
||||||
### Fixed
|
### Fixed
|
||||||
- Issue [#577](https://github.com/Microsoft/msphpsql/issues/577) - Idle Connection Resiliency doesn't work with Column Encryption enabled connection
|
- Issue [#577](https://github.com/Microsoft/msphpsql/issues/577) - Idle Connection Resiliency doesn't work with Column Encryption enabled connection
|
||||||
- Issue [#678](https://github.com/Microsoft/msphpsql/issues/678) - Idle Connection Resiliency doesn't work with Connection Pooling bug
|
- Issue [#678](https://github.com/Microsoft/msphpsql/issues/678) - Idle Connection Resiliency doesn't work with Connection Pooling bug
|
||||||
- Issue [#699](https://github.com/Microsoft/msphpsql/issues/699) - binding output parameter failed when the query in the stored procedure returned no data. The test case has been added to the test lab.
|
- Issue [#699](https://github.com/Microsoft/msphpsql/issues/699) - Binding output parameter failed when the query in the stored procedure returned no data. The test case has been added to the test lab.
|
||||||
- Issue [#705](https://github.com/Microsoft/msphpsql/issues/705) - AE - Retrieving a negative decimal value (edge case) as output parameter causes truncation
|
- Issue [#705](https://github.com/Microsoft/msphpsql/issues/705) - AE - Retrieving a negative decimal value (edge case) as output parameter causes truncation
|
||||||
- Issue [#706](https://github.com/Microsoft/msphpsql/issues/706) - AE - Cannot insert double with precision and scale (38, 38)
|
- Issue [#706](https://github.com/Microsoft/msphpsql/issues/706) - AE - Cannot insert double with precision and scale (38, 38)
|
||||||
- Issue [#707](https://github.com/Microsoft/msphpsql/issues/707) - AE - fetching decimals / numerics as output parameters bound to PDO::PARAM_BOOL or PDO::PARAM_INT returns floats, not integers
|
- Issue [#707](https://github.com/Microsoft/msphpsql/issues/707) - AE - Fetching decimals / numerics as output parameters bound to PDO::PARAM_BOOL or PDO::PARAM_INT returns floats, not integers
|
||||||
- Issue [#735](https://github.com/Microsoft/msphpsql/issues/735) - PDO lastInsertId primary bigInt, after id 999999999 return ''
|
- Issue [#735](https://github.com/Microsoft/msphpsql/issues/735) - Extended the buffer size for PDO lastInsertId such that data types other than integers can be supported
|
||||||
- Pull Request [#759](https://github.com/Microsoft/msphpsql/pull/759) - removed the limitation of binding a binary as inout param as PDO::PARAM_STR with SQLSRV_ENCODING_BINARY
|
- Pull Request [#759](https://github.com/Microsoft/msphpsql/pull/759) - Removed the limitation of binding a binary as inout param as PDO::PARAM_STR with SQLSRV_ENCODING_BINARY
|
||||||
- Pull Request [#775](https://github.com/Microsoft/msphpsql/pull/775) - fixed the problem for output params with SQL types specified as SQLSRV_SQLTYPE_DECIMAL or SQLSRV_SQLTYPE_NUMERIC
|
- Pull Request [#775](https://github.com/Microsoft/msphpsql/pull/775) - Fixed the problem for output params with SQL types specified as SQLSRV_SQLTYPE_DECIMAL or SQLSRV_SQLTYPE_NUMERIC
|
||||||
|
|
||||||
### Limitations
|
### Limitations
|
||||||
- No support for inout / output params when using sql_variant type
|
- No support for inout / output params when using sql_variant type
|
||||||
- In Linux and macOS, setlocale() only takes effect if it is invoked before the first connection. Attempting to set the locale after connection will not work
|
- In Linux and macOS, setlocale() only takes effect if it is invoked before the first connection. Attempting to set the locale after connection will not work
|
||||||
- Always Encrypted feature, which requires [MS ODBC Driver 17+](https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-2017)
|
- Always Encrypted feature, which requires [MS ODBC Driver 17+](https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-2017)
|
||||||
- only Windows Certificate Store and Azure Key Vault are supported
|
- only Windows Certificate Store and Azure Key Vault are supported
|
||||||
- Issue [#716](https://github.com/Microsoft/msphpsql/issues/716) - Named Parameters in Sub Queries
|
- Issue [#716](https://github.com/Microsoft/msphpsql/issues/716) - With Always Encrypted feature enabled, Named Parameters in Sub Queries are not supported
|
||||||
- [Always Encrypted limitations](https://docs.microsoft.com/en-us/sql/connect/php/using-always-encrypted-php-drivers?view=sql-server-2017#limitations-of-the-php-drivers-when-using-always-encrypted)
|
- [Always Encrypted limitations](https://docs.microsoft.com/en-us/sql/connect/php/using-always-encrypted-php-drivers?view=sql-server-2017#limitations-of-the-php-drivers-when-using-always-encrypted)
|
||||||
|
|
||||||
### Known Issues
|
### Known Issues
|
||||||
|
@ -34,7 +34,7 @@ Updated PECL release packages. Here is the list of updates:
|
||||||
- When pooling is enabled in Linux or macOS
|
- When pooling is enabled in Linux or macOS
|
||||||
- unixODBC <= 2.3.4 (Linux and macOS) might not return proper diagnostics information, such as error messages, warnings and informative messages
|
- unixODBC <= 2.3.4 (Linux and macOS) might not return proper diagnostics information, such as error messages, warnings and informative messages
|
||||||
- due to this unixODBC bug, fetch large data (such as xml, binary) as streams as a workaround. See the examples [here](https://github.com/Microsoft/msphpsql/wiki/Features#pooling)
|
- due to this unixODBC bug, fetch large data (such as xml, binary) as streams as a workaround. See the examples [here](https://github.com/Microsoft/msphpsql/wiki/Features#pooling)
|
||||||
- With ColumnEncryption enabled, calling stored procedure with XML parameter does not work (Issue [#674](https://github.com/Microsoft/msphpsql/issues/674))
|
- With ColumnEncryption enabled, calling stored procedures with XML parameters does not work (Issue [#674](https://github.com/Microsoft/msphpsql/issues/674))
|
||||||
|
|
||||||
|
|
||||||
## Windows/Linux/macOS 5.2.0 - 2018-03-23
|
## Windows/Linux/macOS 5.2.0 - 2018-03-23
|
||||||
|
|
|
@ -93,9 +93,9 @@ The version number may have trailing pre-release version identifiers to indicate
|
||||||
## Guidelines for Reporting Issues
|
## Guidelines for Reporting Issues
|
||||||
We appreciate you taking the time to test the driver, provide feedback and report any issues. It would be extremely helpful if you:
|
We appreciate you taking the time to test the driver, provide feedback and report any issues. It would be extremely helpful if you:
|
||||||
|
|
||||||
- First check [FAQ](https://github.com/Microsoft/msphpsql/wiki/FAQ)
|
- First check the [FAQ](https://github.com/Microsoft/msphpsql/wiki/FAQ)
|
||||||
- Report each issue as a new issue (but check first if it's already been reported)
|
- Report each issue as a new issue (but check first if it's already been reported)
|
||||||
- Please address the questions in the new issue template and provide scripts, table schema, and/or any detail that help reproducing the problem(s)
|
- Please address the questions in the new issue template and provide scripts, table schema, and/or any details that may help reproduce the problem(s)
|
||||||
|
|
||||||
Thank you!
|
Thank you!
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue