From e3fd38c87304183bbaac325eaee7ffda18f9c758 Mon Sep 17 00:00:00 2001 From: lilgreenbird Date: Mon, 24 Jul 2017 15:12:03 -0700 Subject: [PATCH] removed redundant count() as per review comment --- test/functional/sqlsrv/TC21_Connection.phpt | 2 +- test/functional/sqlsrv/sqlsrv_close.phpt | 2 +- test/functional/sqlsrv/sqlsrv_fetch_field_twice_data_types.phpt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/functional/sqlsrv/TC21_Connection.phpt b/test/functional/sqlsrv/TC21_Connection.phpt index 0a6872a7..0d3b53dc 100644 --- a/test/functional/sqlsrv/TC21_Connection.phpt +++ b/test/functional/sqlsrv/TC21_Connection.phpt @@ -36,7 +36,7 @@ function ConnectionTest() Trace("\nValid connection attempt (to $server) ....\n"); $conn2 = Connect(); $errors = sqlsrv_errors(SQLSRV_ERR_ERRORS); - if (!empty($errors) && count($errors) != 0) + if (!empty($errors)) { die("No errors were expected on valid connection attempts."); } diff --git a/test/functional/sqlsrv/sqlsrv_close.phpt b/test/functional/sqlsrv/sqlsrv_close.phpt index 8841141e..2c8e2d10 100644 --- a/test/functional/sqlsrv/sqlsrv_close.phpt +++ b/test/functional/sqlsrv/sqlsrv_close.phpt @@ -14,7 +14,7 @@ using an already closed connection. $conn2 = Connect(); $stmt1 = sqlsrv_query($conn2, "IF OBJECT_ID('PHPTable', 'U') IS NOT NULL DROP TABLE [PHPTable]"); $errors = sqlsrv_errors(); - if (!empty($errors) && count($errors) != 0) + if (!empty($errors)) { die("No errors were expected on valid connection attempts."); } diff --git a/test/functional/sqlsrv/sqlsrv_fetch_field_twice_data_types.phpt b/test/functional/sqlsrv/sqlsrv_fetch_field_twice_data_types.phpt index 8fed9d3c..333c87d5 100644 --- a/test/functional/sqlsrv/sqlsrv_fetch_field_twice_data_types.phpt +++ b/test/functional/sqlsrv/sqlsrv_fetch_field_twice_data_types.phpt @@ -72,7 +72,7 @@ function FetchField($stmt, $idx, $numFields, $errorExpected) function PrintError($errorExpected = true) { $errors = sqlsrv_errors(SQLSRV_ERR_ALL); - if (!empty($errors) && count($errors) > 0) + if (!empty($errors)) { $e = $errors[0]; var_dump($e['message']);