Commit graph

597 commits

Author SHA1 Message Date
David Puglielli e2a6ece527 Fixed test and error message 2019-04-11 12:11:02 -07:00
David Puglielli 4b6b650db1 Added row and column count checks 2019-04-05 12:34:33 -07:00
David Puglielli a8a0146671 Removed forward cursor condition 2019-04-02 16:08:53 -07:00
David Puglielli 6325284919
Merge pull request #930 from gdegoulet/dev
add Language option on connect
2019-03-28 12:09:54 -07:00
Jenny Tam f76944de94 Merge tag 'v5.6.1' into HEAD
The hotfix for 5.6.0 RTW
2019-03-28 10:19:37 -07:00
Jenny Tam 3c71213575 5.6.1 hotfix 2019-03-18 16:50:19 -07:00
Jenny Tam 2c8f8caf8d Fix issue 955 - errors building sqlsrv alone (#956)
(cherry picked from commit 15f61bd0b4)
2019-03-18 16:37:27 -07:00
Jenny Tam 763913d7ca Fixed the returned values for PDOStatement::getColumnMeta (#946)
(cherry picked from commit 7309fb90b1)
2019-03-18 16:34:30 -07:00
Jenny Tam a6cee775f7 Issue 937 - fixed ASSERT and added new tests (#940)
(cherry picked from commit 12d01c9189)
2019-03-18 16:32:45 -07:00
Jenny Tam 15f61bd0b4
Fix issue 955 - errors building sqlsrv alone (#956) 2019-03-18 08:23:31 -07:00
Jenny Tam 840ebc2378
Fixed the error in Issue 570 (#952) 2019-03-14 11:17:14 -07:00
Jenny Tam 7309fb90b1
Fixed the returned values for PDOStatement::getColumnMeta (#946) 2019-03-08 11:43:36 -08:00
Jenny Tam 12d01c9189
Issue 937 - fixed ASSERT and added new tests (#940) 2019-02-27 16:54:26 -08:00
Guillaume Degoulet 5b2b7504da add Language option on connect 2019-02-13 13:56:12 +01:00
David Puglielli 9e49a176d8 Fixed load order issue in sqlsrv 2019-02-05 15:42:53 -08:00
Jenny Tam 04f531d813
Initialize hasLoss before passing into Convert function (#919) 2019-01-21 08:16:25 -08:00
Jenny Tam d6c8cc2e15
Changed version 5.6.0 (#918) 2019-01-16 10:19:01 -08:00
Jenny Tam 9a372582f9
Support for Managed Identity for Azure resources (#875) 2019-01-11 17:17:45 -08:00
Jannes Jeising 4efb54e45a Enable compiling extensions statically into PHP (#904) 2018-12-20 11:49:06 -08:00
Jenny Tam d4f840f630
Initialize output param buffer when allocating extra space (#907) 2018-12-17 12:25:37 -08:00
David Puglielli 2f92a262dc Improve performance of Unicode conversions (#891) 2018-12-04 13:00:34 -08:00
Jenny Tam 9195f84f60
Removed warning messages while compiling extensions (#892) 2018-12-03 12:08:21 -08:00
Jenny Tam ae29f73aee
Version update for 5.5.0-preview (#889) 2018-11-29 08:54:45 -08:00
Jenny Tam 76c595fc2b
Decimal places for money types only (#886) 2018-11-27 17:18:38 -08:00
Jenny Tam 69e82080ea
Modified config files to add the compiler flag, /Qspectre (#878) 2018-11-13 15:33:07 -08:00
Jenny Tam f4ad2ae1d4
Feature request 415 for pdo_sqlsrv (#873) 2018-11-02 14:34:27 -07:00
Jenny Tam b3072a99ee
Modified how to send stream data using SQLPutData and SQLParamData (#865) 2018-10-19 14:48:21 -07:00
Jenny Tam 18094a6cef
Feature request 415 for sqlsrv (#861) 2018-10-12 15:22:27 -07:00
Jenny Tam b523306919
Save meta data for the fetched result set (#855)
* Save meta data on fetched result sets

* Fixed a compilation error

* Optimized some more -- metadata should be available when fetching

* Skip conversion for strings of numeric values, integers, floats, decimals etc

* Set encoding char for numeric data

* Apply review
2018-10-05 15:01:18 -07:00
Jenny Tam 32732c885e
Clear AKV data after setting the connection attribute or when exception is thrown (#854)
* Dev (#820)

* Fixed the potential error reported by Prefast code analysis

* Use SQLSRV_ASSERT for checking NULL ptrs

* For these AKV tests check env despite not AE connected

* Added the driver option to run functional tests

* Fixed connection pooling tests for more than one ODBC drivers

* added driver option to pdo isPooled.php

* Removed win32 ifdefs re connection resiliency (#802)

* Set the driver argument for getDSN to null by default (#798)

* Added the driver argument to getDSN

* Dropped the driver argument but set to null as default

* Removed the AE condition in locale support

* Modified the AE condition for locale support

* Changed int to SQLLEN to avoid infinite loop (#806)

* Version 5.3.0 (#803)

* Version 5.3.0

* Fixed the wrong replacements

* Added comments block to m4 files

* Use dnl for comments

*  Modified AE fetch phptypes test to insert only one row at a time and loop through php types (#801)

* Modified AE fetch phptypes test to insert only one row at a time and loop through php types

* Fixed formatting

* Streamlined two very similar large column name tests (#807)

* Streamlined two very similar large column name tests

* Changed the EOL

* Updates to change log and readme (#811)

* Updates to change log and readme

* Dropped support for Ubuntu 17

* Modified as per review comments

* Fixed connection resiliency tests for Unix, updated AppVeyor for ODBC 17.2

* Fixed expected output

* Fixed output and skipifs

* Fixed skipifs and output

* Fixed driver name

* Updated installation instructions and sample script (#813)

* Updated instructions and sample test for 5.3.0 RTW

* Fixed sample code to adhere to php coding standard

* Fixed cases and spaces

* Modified NOTE for UB 18.04 based on review comments

* Added 'exit'

* Modified change log and readme based on review to PR 811

* Applied review comments

* build output to debug appveyor failure

* removed debug output

* Streamlined two very similar large column name tests (#815)

* Streamlined two very similar large column name tests

* Added random number of test table names to avoid operand clash issues

* Replaced to with for based on review

* Changelog updated

* changelog updated, test skipif changed to run on unix platforms

* Fixed skipif typo

* Fixed typo in skipif for pdo

* Fixed some output for Travis

* Moved error checking inside pdo connres tests

* Added links back to changelog

* Fixed output for sqlsrv connres tests

* Fixed output

* Fixed output again

* Clear AKV data after connection or when exception is thrown

* Modified tests too to skip some AKV tests without real credentials

* Used assignment operator also free the existing memory
2018-09-26 14:51:16 -07:00
Jenny Tam 88dfea339a
Updated version 5.4.0-preview (#846)
* Updated version 5.4.0-preview

* Replaced 5.3 with 5.4
2018-09-18 08:20:43 -07:00
Jenny Tam 902a03263e
Feature request - add ReturnDatesAsStrings option to statement level for sqlsrv (#844)
* Added ReturnDatesAsStrings option to the statement level

* Added new tests for ReturnDatesAsStrings at statement level

* Added more datetime types as per review
2018-09-17 16:25:02 -07:00
Jenny Tam 7521f095ee
Feature request - new PDO_STMT_OPTION_FETCHES_DATETIME_TYPE flag for pdo_sqlsrv to return datetime as objects (#842)
* Feature request - issue 648

* Fixed constructor for field_cache and added another test

* Added tests for FETCH_BOUND

* Added a new test for output param

* Modified output param test to set attributes differently

* Removed a useless helped function in a test

* Combined two new tests into one as per review

* Uncommented dropTable
2018-09-17 16:24:52 -07:00
Jenny Tam e51380612d
Adding supporting for Azure AD access token (#837)
* Adding supporting for Azure AD access token

* Added more comments for the AD access token skipif files

* Save the pointer to access token struct until after connecting

* Clear the access token data before freeing the memory

* Added a reference as per review
2018-09-06 11:32:04 -07:00
Jenny Tam 084ab72406
Incorporated changes in PR 634 to pdo_sqlsrv (#834)
* Incorporated changes in PR 634 to pdo_sqlsrv

* Reverted the changes because the array is for internal use only
2018-08-28 15:18:01 -07:00
Jenny Tam c209b7248f
Enabled Spectre Mitigations (#836) 2018-08-24 15:31:13 -07:00
Jenny Tam 6a688b3727
Modified the error handling to make it more flexible (#833)
* Made error handling more flexible

* Fixed a minor issue with a test
2018-08-20 14:51:33 -07:00
Jenny Tam 909d1fa130
Before freeing stmt in destructor check if dbh driver data is NULL (#829)
* Issue 434 - set dbh driver data to NULL as well in destructor

* Reverted the last change but instead check if dbh driver_data is already freed

* Modified the comment
2018-08-10 15:18:08 -07:00
David Puglielli ba9579b504
Merge pull request #827 from david-puglielli/string-initialisation-nulls
Fix for compilation problem again
2018-08-01 16:40:40 -07:00
David Puglielli 0b15997d3c Fix for compilation problem again 2018-08-01 16:14:34 -07:00
David Puglielli d699680cd4
Merge pull request #826 from david-puglielli/string-initialisation-nulls
Fix for compilation problem
2018-08-01 14:36:20 -07:00
David Puglielli 29f4ad710b Fix for compilation problem 2018-08-01 13:24:20 -07:00
David Puglielli 026c5d14d3
Merge pull request #825 from david-puglielli/string-initialisation-nulls
String initialisation to nulls
2018-07-31 18:28:57 -07:00
David Puglielli 41a7caf1c1 Made array index spacing consistent 2018-07-31 17:22:56 -07:00
David Puglielli a664a5fcf9 Removed some spaces 2018-07-31 14:58:21 -07:00
David Puglielli adf86f17ae Initialising strings with nulls 2018-07-31 13:16:32 -07:00
Jenny Tam b6d815bfc9
Changes made to source and tests to support PHP 7.3 (#822)
* Changes made to support php 7.3

* Correct use of the smart pointer

* Fixed the tests for 7.3

* Some clean up for array_init()

* Fixed formattings and clean up
2018-07-26 15:21:03 -07:00
Jenny Tam 197489ab4f
Version 5.3.0 (#803)
* Version 5.3.0

* Fixed the wrong replacements

* Added comments block to m4 files

* Use dnl for comments
2018-06-27 11:03:52 -07:00
Jenny Tam ae0b95b757
Changed int to SQLLEN to avoid infinite loop (#806) 2018-06-27 11:03:30 -07:00
Jenny Tam 81ff0851ea
Removed win32 ifdefs re connection resiliency (#802) 2018-06-21 14:29:09 -07:00
Jenny Tam 44d1bb39ba Use SQLSRV_ASSERT for checking NULL ptrs 2018-06-06 13:18:58 -07:00
Jenny Tam 10ff344fca Fixed the potential error reported by Prefast code analysis 2018-06-05 13:09:51 -07:00
David Puglielli 13144d9c5e
Merge pull request #783 from david-puglielli/type-conversion-for-ae
Added select type conversion test
2018-05-28 15:48:18 -07:00
David Puglielli c348aadd68 Addressed review comments 2018-05-28 15:08:46 -07:00
David Puglielli d35575b164 Added select type conversion test and updated values 2018-05-25 21:47:25 -07:00
Jenny Tam 45f422abba
Merge pull request #780 from yitam/version
Modified version.h for 5.2.1-preview
2018-05-25 16:48:13 -07:00
David Puglielli 1747df1ced addressed review comments 2018-05-25 14:42:32 -07:00
Jenny Tam 6817c7b4d4 Modified the comments to clarify things 2018-05-25 09:38:23 -07:00
Jenny Tam d26440b207 Modified version.h for 5.2.1-preview 2018-05-24 16:30:12 -07:00
David Puglielli e0f9afae2f
Merge pull request #768 from david-puglielli/azure-key-vault-support
Azure key vault support
2018-05-18 14:43:36 -07:00
David Puglielli e2ed131b41 Final style fixes 2018-05-18 14:05:18 -07:00
David Puglielli 10ea9286d8 Fixed coding style 2018-05-18 12:24:37 -07:00
David Puglielli 757a84fd4c Added constant for AKV name 2018-05-17 16:24:40 -07:00
Jenny Tam 64e2241ba2 Extend output buffer sizes with SQL decimals or numerics 2018-05-17 13:06:22 -07:00
David Puglielli 079c4ea0fe Fixed tests, fixed wide char name in keystore struct 2018-05-16 15:14:47 -07:00
Jenny Tam 4747537a96 Fixed the formatting 2018-05-15 16:13:36 -07:00
Jenny Tam 0b5ceb001d Reverted the changes 2018-05-15 15:57:47 -07:00
Jenny Tam 4c7c08515d Added workaround for the test plus use BIGINT for 64-bit systems 2018-05-15 14:28:26 -07:00
Jenny Tam bca311081d Modified the output param initial value 2018-05-15 12:41:28 -07:00
Jenny Tam 9a82e9daa3 Used sizeof not INT_MAX 2018-05-15 10:00:36 -07:00
Jenny Tam 999312be8b Tried using INT_MAX instead 2018-05-15 09:33:52 -07:00
David Puglielli 2239511f80 Workaround for error returned in Linux 2018-05-14 12:04:25 -07:00
David Puglielli 3b94eb4726 Merging 2018-05-08 17:56:28 -07:00
David Puglielli 2aaae26f55 Minor fixes 2018-05-08 17:09:58 -07:00
David Puglielli fb1a2ecb70 Changes according to PR review comments 2018-05-08 14:12:14 -07:00
Jenny Tam 5a842c9b32
Merge pull request #761 from yitam/vso2823
Made changes to output param handling code to convert doubles to ints, if necessary
2018-05-08 13:13:14 -07:00
David Puglielli 2fe0b5a2bc Removed more unnecessary comments 2018-05-05 17:24:34 -07:00
David Puglielli 52cd004b79 Removed unnecessary comments 2018-05-05 17:22:02 -07:00
David Puglielli 977e5309dd Support for Azure Key Vault 2018-05-05 17:08:01 -07:00
Jenny Tam 5f6c3994ca A huge negative number is out of range too 2018-04-26 08:57:22 -07:00
Jenny Tam 5bb3f1a2ec Modified the error message to indicate value out of range 2018-04-26 08:48:41 -07:00
Jenny Tam 218497c642 Made changes to output param handling code to convert doubles to ints if necessary 2018-04-25 15:43:56 -07:00
Jenny Tam 3033a26c51 Added a comment to address the issue 2018-04-25 07:56:58 -07:00
Jenny Tam 72ca1cd1eb Fixed incorrect error when binding inout PDO STR with binary encoding 2018-04-24 15:38:53 -07:00
Jenny Tam 93b9938e02 Replace most strlen with strnlen_s 2018-04-13 15:06:10 -07:00
David Puglielli 454bc2739f
Merge pull request #744 from david-puglielli/Revert-bigint-change
Reverted change handling bigint output parameters
2018-04-11 14:21:20 -07:00
David Puglielli 2960738883 Reverted change handling bigint output parameters 2018-04-09 17:15:58 -07:00
Jenny Tam 812db3da38 Increase LAST_INSERT_ID_BUFF_LEN for other data types for identity columns 2018-04-06 11:35:32 -07:00
Jenny Tam 88f0bcfc92 Added bigint into the options 2018-04-04 13:37:41 -07:00
Jenny Tam 4740ed25b8 Fix issue 705 by including the possible negative sign 2018-04-02 15:41:54 -07:00
Jenny Tam db56c0344e Removed support for Custom Keystore provider 2018-02-08 09:00:16 -08:00
Yuki Wong 3bc2c74fd3
Merge pull request #676 from v-kaywon/versionh
change version.h and config flags for debug mode
2018-01-29 21:06:13 -08:00
v-kaywon 13d6f9129e change version.h and config flags for debug mode 2018-01-29 16:38:09 -08:00
Jenny Tam 6d5763abd6 Replace SQL_IS_SMALLINT with SQL_IS_INTEGER 2018-01-29 16:34:57 -08:00
Jenny Tam 9e2c080dda Replace 0 with SQL_IS_SMALLINT 2018-01-29 15:56:25 -08:00
v-kaywon 253a0f3d44 fix typo 2018-01-17 10:12:31 -08:00
v-kaywon abd2c65348 fix indentation 2018-01-16 16:50:17 -08:00
v-kaywon 53e5a51760 remove workaround for limitation on fetching stream 2018-01-15 11:57:52 -08:00
David Puglielli bc71d659d8 Fixed merge conflicts 2018-01-05 12:14:01 -08:00
Jenny Tam cc303c5904 Use https for fwlinks 2018-01-03 13:02:26 -08:00
Jenny Tam 00a2e82ca8 Changed connection order to ODBC drivers 2018-01-02 15:26:33 -08:00
David Puglielli 6b177f0ee1 Added immediate binding and fixed some mac related test output 2017-12-21 14:14:23 -08:00
Jenny Tam 244e3401b5 Added Control Flow Guard to configs 2017-12-21 12:52:36 -08:00
Jenny Tam 44e447a86a
Update version.h
Renamed RC RC1 for PECL
2017-12-21 11:02:11 -08:00
v-kaywon 0c0882b93f coding standard 2017-12-15 13:42:59 -08:00
v-kaywon 0284279e9b fix crash related to zend_hash_internal_pointer_reset 2017-12-15 13:37:29 -08:00
Jenny Tam 2236e71234
Merge pull request #631 from yitam/RC1
Updated versions from 5.1 to 5.2
2017-12-14 16:49:54 -08:00
Jenny Tam 8d33f1fc02 Updated versions from 5.1 to 5.2 2017-12-14 16:05:34 -08:00
v-kaywon ad29c28dc4 fix warning according to prefast code analysis 2017-12-13 13:33:32 -08:00
v-kaywon 9f8078dde9 fix spacing in core_stmt.cpp 2017-12-08 16:15:24 -08:00
v-kaywon b9579a2426 add error handling for fetching stream with always encrypted 2017-12-07 17:29:06 -08:00
Yuki Wong f2884e0979
Merge pull request #594 from v-kaywon/adjustprecision
Adjust precision for decimal input when column encryption is enabled
2017-11-22 13:58:53 -08:00
Jenny Tam 11c6fe6f46 chech param num against vector size 2017-11-21 16:41:18 -08:00
Jenny Tam ab5bdb4ac0 Merge branch 'dev' into describeParam 2017-11-21 15:29:09 -08:00
v-kaywon 0b135b1529 if not scientific notation, only parse up to decimal_digits 2017-11-21 13:17:39 -08:00
v-susanh 54f1e5e22f
support for non-utf8 locales (#598)
* support non-utf8 locales
2017-11-20 17:56:45 -08:00
v-kaywon 20480812c2 remove include string in core_stmt.cpp 2017-11-20 16:06:39 -08:00
v-kaywon acb0300271 change changelog and version.h for 5.1.2-preview 2017-11-17 16:12:57 -08:00
v-kaywon fc7c4fb89b return if the length of the decimal string is greater than maxDecimalStrLen 2017-11-17 13:27:45 -08:00
v-kaywon bb1e1c0168 do not throw an error if the decimal string is ill formed; let SQL Server handle it 2017-11-17 12:30:14 -08:00
v-kaywon 90029e7e54 add test for scientific notation 2017-11-17 10:21:03 -08:00
David Puglielli 01dd22cac2
Merge pull request #595 from david-puglielli/nextrowset-revert
Revert nextRowset changes
2017-11-16 22:06:12 -05:00
Jenny Tam ef45560db0 Modified how to bind parameters when AE is enabled 2017-11-16 10:30:44 -08:00
David Puglielli 633024c22b Revert next result changes, improve tests 2017-11-15 17:39:00 -08:00
v-kaywon 9acfab9ec2 include vector library 2017-11-15 16:38:27 -08:00
v-kaywon 9d6aba62ce implement adjustInputPrecision 2017-11-15 16:36:10 -08:00
Jenny Tam 1a2459614e Adjusted the initial length for string and LOB fields 2017-11-15 11:00:56 -08:00
Jenny Tam d633691b5b Raised the initial buffer size and modified tests as per review 2017-11-10 15:04:07 -08:00
Jenny Tam 52b612ece8 Fix to GitHub issue 574 2017-11-09 15:24:08 -08:00
David Puglielli 10aa50ced0 Fixed crash caused by non-freed reference 2017-11-06 15:48:51 -08:00
Jenny Tam ef144000c3 Fixed the typo in the comment 2017-11-03 12:17:43 -07:00
Jenny Tam b44a5dd1fb Modified comments as per review feedback 2017-11-03 11:14:55 -07:00
Jenny Tam e5a3767089 Added error handling for LOB types as output parameters 2017-11-03 10:00:08 -07:00
v-kaywon 2ce10aceb0 change error messages 2017-10-31 09:41:34 -07:00
v-kaywon 631f80a9af added error handling for using direct_query and emulate_prepare in a Column Encryption enabled connection 2017-10-26 13:58:38 -07:00
Yuki Wong 779c39abc2 Merge pull request #571 from v-kaywon/AEdecimalprecision
fix for right truncation error when precision of the column definition and input is not aligned
2017-10-26 13:43:27 -07:00
v-kaywon 7a496acfbe change test title in pdo_decimal_precision.phpt and sqlsrv_decimal_precision.phpt 2017-10-20 15:10:56 -07:00
Jenny Tam f25d5d59dd update version to 5.1.1 2017-10-19 15:14:02 -07:00
v-kaywon 02e145d988 fix for right truncation error when precision of the column definition and input is not aligned 2017-10-18 18:10:30 -07:00
v-kaywon 6a4f625e56 change encoding 2017-10-18 15:40:58 -07:00
v-kaywon f2f3bc1ff5 change encoding 2017-10-18 13:08:07 -07:00
v-kaywon f4c736a073 only change encoding if it is invalid 2017-10-18 12:17:52 -07:00
v-kaywon b73539c311 remove setting encoding in core_stmt.cpp 2017-10-18 11:17:55 -07:00
v-kaywon d7212e60cb change output biging to encoding utf8 2017-10-17 16:11:05 -07:00
v-kaywon f67240e566 change encoding to converting from long to string to UTF8 2017-10-17 16:02:12 -07:00
v-kaywon 9e847c1ca8 detect appveyor problem 2017-10-17 15:51:41 -07:00
v-kaywon 6b223a77c9 detect appveyor problem 2017-10-17 15:44:52 -07:00
v-kaywon 597d54476e detect appveyor problem 2017-10-17 15:37:59 -07:00
v-kaywon 3e247c6a25 detect appveyor problem 2017-10-17 15:30:27 -07:00
v-kaywon 98edd5df85 detect appveyor problem 2017-10-17 15:22:00 -07:00