From 6b55368234a3c63222bac5f4e702c45fcc463725 Mon Sep 17 00:00:00 2001
From: Jeremy Dubois <jdubois@evolix.fr>
Date: Mon, 15 Jul 2019 17:48:51 +0200
Subject: [PATCH] Improve script and add comments

---
 .../plugins_bsd/check_connections_state.sh    | 24 +++++++++++++++----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/roles/nagios-nrpe/files/plugins_bsd/check_connections_state.sh b/roles/nagios-nrpe/files/plugins_bsd/check_connections_state.sh
index ef894cd..ac73313 100755
--- a/roles/nagios-nrpe/files/plugins_bsd/check_connections_state.sh
+++ b/roles/nagios-nrpe/files/plugins_bsd/check_connections_state.sh
@@ -9,11 +9,13 @@ INFO_MAIN_CONNECTION="IP - Description"
 INFO_SECOND_CONNECTION="IP - Description"
 CURRENT_GATEWAY=$(/usr/bin/netstat -nr | /usr/bin/grep "default" | /usr/bin/awk '{print $2}')
 
-IS_GATEWAY_IN_FILE=1
-IS_VPN_USING_MAIN_CONNECTION=1
-IS_PF_USING_MAIN_CONNECTION=1
-CHECK_CARP=0
+IS_GATEWAY_IN_FILE=1            # Check whether /etc/mygate has the IP of main connection
+IS_VPN_USING_MAIN_CONNECTION=1  # Check whether ipsecctl use the main connection
+IS_PF_USING_MAIN_CONNECTION=1   # Check whether PacketFilter has route-to using the main connection
+IS_MISCELLANEOUS=1              # Check miscellaneous things
+CHECK_CARP=0                    # No check if host is backup
 
+# No check if host is backup
 if [ "${CHECK_CARP}" = 1 ]; then
     CARP_STATUS=$(/sbin/ifconfig carp0 | /usr/bin/grep "status" | /usr/bin/awk '{print $2}')
     if [ "$CARP_STATUS" = "backup" ]; then
@@ -22,6 +24,8 @@ if [ "${CHECK_CARP}" = 1 ]; then
     fi
 fi
 
+# If main connection is UP but not used => critical and continue
+# If main connection is DOWN (used or not) => warning and exit
 /sbin/ping -c1 -w1 ${MAIN_CONNECTION_PINGABLE_IP} >/dev/null 2>&1
 if [ $? = 0 ]; then
     if [ "${CURRENT_GATEWAY}" != "${MAIN_CONNECTION_GATEWAY}" ]; then
@@ -30,18 +34,21 @@ if [ $? = 0 ]; then
     fi
 else
     echo "Main connection (${INFO_MAIN_CONNECTION}) is down"
-    STATE=2
+    STATE=1
     IS_GATEWAY_IN_FILE=0
     IS_VPN_USING_MAIN_CONNECTION=0
     IS_PF_USING_MAIN_CONNECTION=0
+    IS_MISCELLANEOUS=0
 fi
 
+# If second connection is DOWN => critical and continue
 /sbin/ping -c1 -w1 ${SECOND_CONNECTION_PINGABLE_IP} >/dev/null 2>&1
 if [ $? != 0 ]; then
     echo "Second connection (${INFO_SECOND_CONNECTION}) is down"
     STATE=2
 fi
 
+# Check whether /etc/mygate has the IP of main connection
 if [ "${IS_GATEWAY_IN_FILE}" = 1 ]; then
     /usr/bin/grep -q "${MAIN_CONNECTION_GATEWAY}" /etc/mygate
     if [ $? != 0 ]; then
@@ -50,6 +57,7 @@ if [ "${IS_GATEWAY_IN_FILE}" = 1 ]; then
     fi
 fi
 
+# Check whether ipsecctl use the main connection
 if [ "${IS_VPN_USING_MAIN_CONNECTION}" = 1 ]; then
     /sbin/ipsecctl -sa | /usr/bin/grep -q "${MAIN_CONNECTION_IP}"
     if [ $? != 0 ]; then
@@ -58,6 +66,7 @@ if [ "${IS_VPN_USING_MAIN_CONNECTION}" = 1 ]; then
     fi
 fi
 
+# Check whether PacketFilter has route-to using the main connection
 if [ "${IS_PF_USING_MAIN_CONNECTION}" = 1 ]; then
     /sbin/pfctl -sr | /usr/bin/grep "route-to" | /usr/bin/grep -q "${MAIN_CONNECTION_GATEWAY}"
     if [ $? != 0 ]; then
@@ -66,6 +75,11 @@ if [ "${IS_PF_USING_MAIN_CONNECTION}" = 1 ]; then
     fi
 fi
 
+# Check miscellaneous things
+if [ "${IS_MISCELLANEOUS}" = 1 ]; then
+    echo
+fi
+
 if [ "${STATE}" = 0 ]; then
     echo "OK - Main connection is UP and used, second connection is UP"
 fi