Applying fix from yamllint and ansible-lint

roles/base/handlers/main.yml

@@ -1,6 +1,6 @@
 ---
 - name: newaliases
-  shell: smtpctl update table aliases
+  command: smtpctl update table aliases
 
 - name: remount / noatime
   command: mount -u -o noatime /

roles/base/tasks/cron.yml

@@ -5,4 +5,4 @@
     env: true
     value: "{{ cron_root_path }}"
   tags:
-    - cron
+    - cron

roles/base/tasks/dotfiles.yml

@@ -3,6 +3,7 @@
   template:
     src: profile.j2
     dest: /root/.profile
+    mode: "0644"
   tags:
     - admin
     - dotfiles
@@ -21,6 +22,7 @@
   copy:
     src: kshrc
     dest: /root/.kshrc
+    mode: "0644"
   tags:
     - admin
     - dotfiles
@@ -29,6 +31,7 @@
   template:
     src: profile.j2
     dest: /etc/skel/.profile
+    mode: "0644"
   tags:
     - admin
     - dotfiles
@@ -37,6 +40,7 @@
   lineinfile:
     state: present
     dest: /etc/skel/.profile
+    mode: "0644"
     insertafter: EOF
     line: 'trap "doas /usr/share/scripts/evomaintenance.sh" 0'
     create: true
@@ -58,6 +62,7 @@
   copy:
     src: kshrc
     dest: /etc/skel/.kshrc
+    mode: "0644"
   tags:
     - admin
     - dotfiles

roles/base/tasks/mail.yml

@@ -14,6 +14,7 @@
     line:
       'date | mail -s "boot/reboot of $(hostname -s)" {{ general_alert_email }}'
     insertbefore: 'echo'
+    mode: "0640"
     create: true
   when:
     - not (rclocal_content.stdout

roles/base/tasks/newsyslog.yml

@@ -3,5 +3,6 @@
   copy:
     src: newsyslog.conf
     dest: /etc/newsyslog.conf
+    mode: "0644"
   tags:
     - newsyslog

roles/base/tasks/ntp.yml

@@ -3,8 +3,8 @@
   command: cat ntpd.conf
   args:
     chdir: /etc/
-  check_mode: no
+  check_mode: false
-  changed_when: no
+  changed_when: false
   register: ntpd_conf
   tags:
     - ntp
@@ -21,7 +21,7 @@
   lineinfile:
     path: /etc/ntpd.conf
     line: "server {{ ntpd_servers }}"
-    create: yes
+    create: true
     owner: root
     group: wheel
     mode: '0644'

roles/base/tasks/packages.yml

@@ -4,6 +4,7 @@
   copy:
     dest: /etc/installurl
     src: installurl
+    mode: "0644"
   tags:
     - pkg
 

roles/base/tasks/utils.yml

@@ -3,7 +3,7 @@
   copy:
     src: "dump-server-state.sh"
     dest: /usr/local/sbin/dump-server-state
-    force: True
+    force: true
     owner: root
     group: wheel
     mode: "0750"

roles/etc-git/tasks/commit.yml

@@ -33,3 +33,4 @@
   when:
     - _usr_share_scripts_git.stat.exists
     - _usr_share_scripts_git.stat.isdir
+

roles/etc-git/tasks/main.yml

@@ -12,7 +12,7 @@
     src: evocommit
     dest: /usr/local/bin/evocommit
     mode: "0755"
-    force: yes
+    force: true
   tags:
     - etc-git
 
@@ -42,7 +42,7 @@
     src: etc-git-optimize
     dest: /usr/share/scripts/etc-git-optimize
     mode: "0755"
-    force: yes
+    force: true
   tags:
     - etc-git
 
@@ -51,7 +51,7 @@
     src: etc-git-status
     dest: /usr/share/scripts/etc-git-status
     mode: "0755"
-    force: yes
+    force: true
   tags:
     - etc-git
 
@@ -147,7 +147,7 @@
     insertbefore: "/usr/share/scripts/etc-git-status"
     owner: root
     mode: "0644"
-    create: true 
+    create: true
     state: "{{ etc_git_monitor_status | bool | ternary('present','absent') }}"
   tags:
     - etc-git

roles/evocheck/tasks/exec.yml

@@ -10,6 +10,6 @@
 
 - debug:
     var: evocheck_run.stdout_lines
-  when: evocheck_run.stdout != ""
+  when: evocheck_run.stdout | length != 0
   tags:
     - evocheck-exec

roles/evocheck/tasks/main.yml

@@ -23,6 +23,7 @@
   copy:
     src: evocheck.cf
     dest: /etc/evocheck.cf
+    mode: "0644"
     force: false
   tags:
     - evocheck

roles/nagios-nrpe/tasks/main.yml

@@ -29,6 +29,7 @@
   template:
     src: evolix_bsd.cfg.j2
     dest: /etc/nrpe.d/evolix.cfg
+    mode: "0644"
   notify: restart nrpe
 
 - name: Create nrpe plugins dir

roles/post-install/tasks/ldif.yml

@@ -10,9 +10,9 @@
 - name: run generateldif
   command: '{{ general_scripts_dir }}/generateldif.sh'
   register: generateldif_run
-  changed_when: False
+  changed_when: false
-  failed_when: False
+  failed_when: false
-  check_mode: no
+  check_mode: false
   tags:
     - generateldif-exec
 

roles/post-install/tasks/update.yml

@@ -1,4 +1,4 @@
 ---
 - name: Check and install updates (erratas) if available
-  shell: /usr/sbin/syspatch
+  command: /usr/sbin/syspatch
   when: ansible_distribution_version is version_compare("6.1",'>=')