Reordering of the list of NRPE checks #30

Manually merged
Ghost merged 1 commits from reorder_nrpe_checks into dev 2020-04-24 14:22:17 +02:00
Owner

With deletion of unused check_onduleur and correction of check_connections_state location.

Ordering based on our ansible-roles/nagios-nrpe/templates/evolix.cfg.j2 file

With deletion of unused check_onduleur and correction of check_connections_state location. Ordering based on our ansible-roles/nagios-nrpe/templates/evolix.cfg.j2 file
Ghost reviewed 2020-04-23 17:13:27 +02:00
@ -42,0 +47,4 @@
command[check_connections_state]=doas /usr/local/libexec/nagios/plugins/check_connections_state.sh
# This is an Ansible managed file !
# For local modifications use the /etc/nrpe.d/zzz-evolix.cfg file instead
First-time contributor

Should we put this at the top instead ?

Should we put this at the top instead ?
Author
Owner

It also is at the top. It was previously put both at the top and the bottom by a6815408a8 , but the bottom has been lost, and I did not find which commit deleted it.

It's useful to have it at the bottom because that's, I think, the first place we see when we are going to edit a file. I fear it would not be seen if it was only at the top.

It also is at the top. It was previously put both at the top and the bottom by a6815408a8ad09f0ad8c4802feac28ec0c875676 , but the bottom has been lost, and I did not find which commit deleted it. It's useful to have it at the bottom because that's, I think, the first place we see when we are going to edit a file. I fear it would not be seen if it was only at the top.
First-time contributor

I agree with you @jdubois, it's a good thing to have it both at the top and the bottom. Ok by me.

I agree with you @jdubois, it's a good thing to have it both at the top and the bottom. Ok by me.
Ghost approved these changes 2020-04-24 14:21:57 +02:00
Ghost left a comment
First-time contributor

Ok with me.

Ok with me.
Ghost closed this pull request 2020-04-24 14:22:17 +02:00
jdubois deleted branch reorder_nrpe_checks 2020-05-12 15:19:58 +02:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: evolix/EvoBSD#30
No description provided.