Enhance ospfd_simple check #19

Merged
jdubois merged 2 commits from enhance_check_ospfd_simple into dev 2020-04-29 15:46:21 +02:00
Member

The condition did not work properly

The condition did not work properly
jdubois changed title from Enhance ospfd_simple check to WIP : Enhance ospfd_simple check 2019-07-22 16:00:07 +02:00
jdubois changed title from WIP : Enhance ospfd_simple check to WIP: Enhance ospfd_simple check 2019-07-22 16:00:19 +02:00
First-time contributor

Is this still a WIP ? I feel like it could be better.

For instance we could first check if the .sock file is present. If not, send an error message saying ospf is not running because the socket is missing. Then run the ospf show command to make sure it's running properly.

Is this still a WIP ? I feel like it could be better. For instance we could first check if the .sock file is present. If not, send an error message saying ospf is not running because the socket is missing. Then run the ospf show command to make sure it's running properly.
jdubois changed title from WIP: Enhance ospfd_simple check to Enhance ospfd_simple check 2020-04-22 12:10:47 +02:00
Author
Member

You are right. The check was not even operational. I just improved it, I used it on a server and it works.

It is not a WIP anymore.

You are right. The check was not even operational. I just improved it, I used it on a server and it works. It is not a WIP anymore.
Ghost reviewed 2020-04-23 17:15:53 +02:00
@ -12,0 +13,4 @@
exit "$STATE_OK"
else
echo "CRITICAL - OSPFD not running"
exit "$STATE_CRITICAL"
First-time contributor

Is OSPFD not running or in a failed state but running ?

Is OSPFD not running or in a failed state but running ?
Author
Member

If we got there, then the socket file was not found, and the ospfctl command failed. I don't think OSPFD can be running with a failure on a ospfctl command. Conversely, I think that if the ospfctl command successes, then OSPFD surely is running.

If we got there, then the socket file was not found, and the *ospfctl* command failed. I don't think OSPFD can be running with a failure on a *ospfctl* command. Conversely, I think that if the *ospfctl* command successes, then OSPFD surely is running.
First-time contributor

OK for now, well see if we have to make it more descriptive in the future.

OK for now, well see if we have to make it more descriptive in the future.
Ghost approved these changes 2020-04-27 15:55:17 +02:00
jdubois closed this pull request 2020-04-29 15:46:21 +02:00
jdubois deleted branch enhance_check_ospfd_simple 2020-05-12 15:20:17 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/EvoBSD#19
No description provided.