From 1c6fdbf85ab8646bb317be52dd76ddd0fdcc1e6f Mon Sep 17 00:00:00 2001
From: Patrick Marchand <mail@patrickmarchand.com>
Date: Thu, 22 Dec 2022 11:31:28 -0500
Subject: [PATCH] Remove warning ignores as they are depreciated

Will cause a hard fail in ansible 2.14, so better get rid of them now.
There is no alternative, but the ansible warnings for those modules
are not hard failures anyways.
---
 CHANGELOG.md                        | 1 +
 etc-git/tasks/repository.yml        | 3 ---
 evolinux-base/handlers/main.yml     | 4 ----
 kibana/tasks/main.yml               | 2 --
 nginx/tasks/munin_vhost.yml         | 4 ----
 rbenv/tasks/main.yml                | 8 --------
 remount-usr/handlers/main.yml       | 4 +---
 webapps/evoadmin-web/tasks/user.yml | 2 --
 8 files changed, 2 insertions(+), 26 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index dca61a6c..975f00dc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,7 @@ The **patch** part changes is incremented if multiple releases happen the same m
 ### Added
 
 ### Changed
+* Removed all "warn: False" args in command, shell and other modules as it's been depreciated and will give a hard fail in ansible-core 2.14.0.
 
 ### Fixed
 
diff --git a/etc-git/tasks/repository.yml b/etc-git/tasks/repository.yml
index 80987da2..dbf66cda 100644
--- a/etc-git/tasks/repository.yml
+++ b/etc-git/tasks/repository.yml
@@ -9,7 +9,6 @@
   args:
     chdir: "{{ repository_path }}"
     creates: "{{ repository_path }}/.git/"
-    warn: no
   register: git_init
   tags:
     - etc-git
@@ -54,7 +53,6 @@
   command: "git log"
   args:
     chdir: "{{ repository_path }}"
-    warn: no
   changed_when: False
   failed_when: False
   register: git_log
@@ -66,7 +64,6 @@
   shell: "git add -A . && git commit -m \"Initial commit via Ansible\""
   args:
     chdir: "{{ repository_path }}"
-    warn: no
   register: git_commit
   when: git_log.rc != 0 or (git_init is defined and git_init is changed)
   tags:
diff --git a/evolinux-base/handlers/main.yml b/evolinux-base/handlers/main.yml
index 7331a245..388bf051 100644
--- a/evolinux-base/handlers/main.yml
+++ b/evolinux-base/handlers/main.yml
@@ -23,13 +23,9 @@
 
 - name: remount /home
   command: mount -o remount /home
-  args:
-    warn: no
 
 - name: remount /var
   command: mount -o remount /var
-  args:
-    warn: no
 
 
 - name: restart nginx
diff --git a/kibana/tasks/main.yml b/kibana/tasks/main.yml
index e6377dde..341bfd13 100644
--- a/kibana/tasks/main.yml
+++ b/kibana/tasks/main.yml
@@ -126,8 +126,6 @@
 
 # - name: Get mount options for /usr partition
 #   shell: "mount | grep 'on /usr type'"
-#   args:
-#     warn: no
 #   register: mount
 #   changed_when: False
 #   failed_when: False
diff --git a/nginx/tasks/munin_vhost.yml b/nginx/tasks/munin_vhost.yml
index ff9f8423..5aa137c9 100644
--- a/nginx/tasks/munin_vhost.yml
+++ b/nginx/tasks/munin_vhost.yml
@@ -18,15 +18,11 @@
   shell: "chown --verbose www-data:munin /var/log/munin/munin-cgi-*"
   register: command_result
   changed_when: "'changed' in command_result.stdout"
-  args:
-    warn: no
 
 - name: Mode for munin-cgi is set to 660
   shell: "chmod --verbose 660 /var/log/munin/munin-cgi-*"
   register: command_result
   changed_when: "'changed' in command_result.stdout"
-  args:
-    warn: no
 
 - name: Systemd unit for Munin-fcgi is installed
   copy:
diff --git a/rbenv/tasks/main.yml b/rbenv/tasks/main.yml
index de366e78..8294cfdc 100644
--- a/rbenv/tasks/main.yml
+++ b/rbenv/tasks/main.yml
@@ -88,8 +88,6 @@
 
 - name: "is Ruby {{ rbenv_ruby_version }} available for {{ username }} ?"
   shell: /bin/bash -lc "rbenv versions | grep {{ rbenv_ruby_version }}"
-  args:
-    warn: no
   failed_when: False
   changed_when: False
   check_mode: False
@@ -101,8 +99,6 @@
 
 - name: "Ruby {{ rbenv_ruby_version }} is available for {{ username }} (be patient... could be long)"
   shell: /bin/bash -lc "TMPDIR=~/tmp rbenv install {{ rbenv_ruby_version }}"
-  args:
-    warn: no
   when: ruby_installed.rc != 0
   become_user: "{{ username }}"
   become: yes
@@ -111,8 +107,6 @@
 
 - name: "is Ruby {{ rbenv_ruby_version }} selected for {{ username }} ?"
   shell: /bin/bash -lc "rbenv version | cut -d ' ' -f 1 | grep -Fx '{{ rbenv_ruby_version }}'"
-  args:
-    warn: no
   register: ruby_selected
   changed_when: False
   failed_when: False
@@ -124,8 +118,6 @@
 
 - name: "select Ruby {{ rbenv_ruby_version }} for {{ username }}"
   shell: /bin/bash -lc "rbenv global {{ rbenv_ruby_version }} && rbenv rehash"
-  args:
-    warn: no
   when: ruby_selected.rc != 0
   become_user: "{{ username }}"
   become: yes
diff --git a/remount-usr/handlers/main.yml b/remount-usr/handlers/main.yml
index 5f197e78..f13f3ed6 100644
--- a/remount-usr/handlers/main.yml
+++ b/remount-usr/handlers/main.yml
@@ -1,6 +1,4 @@
 ---
 - name: remount usr
   command: "mount -o remount /usr"
-  failed_when: false
-  args:
-    warn: no
+  failed_when: false
\ No newline at end of file
diff --git a/webapps/evoadmin-web/tasks/user.yml b/webapps/evoadmin-web/tasks/user.yml
index bbad1b8f..f26bc57b 100644
--- a/webapps/evoadmin-web/tasks/user.yml
+++ b/webapps/evoadmin-web/tasks/user.yml
@@ -100,8 +100,6 @@
   register: command_result
   changed_when: "'changed' in command_result.stdout"
   # failed_when: False
-  args:
-    warn: False
 
 - name: Add evoadmin sudoers file
   template: