From 2b08a2d81d8ab6fe207844e57a9ba0104fa0b18a Mon Sep 17 00:00:00 2001
From: Mathieu Trossevin <mtrossevin+git@evolix.fr>
Date: Fri, 19 Jun 2020 14:01:09 +0200
Subject: [PATCH] [Cleanup] redmine

Add galaxy_info to meta/main (based on the one on the wiki)

Add become to all tasks that have become_user defined
---
 redmine/meta/main.yml     | 16 ++++++++++++++++
 redmine/tasks/mysql.yml   |  2 +-
 redmine/tasks/release.yml |  6 ++++++
 redmine/tasks/source.yml  |  2 ++
 4 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/redmine/meta/main.yml b/redmine/meta/main.yml
index ffa48751..578388a4 100644
--- a/redmine/meta/main.yml
+++ b/redmine/meta/main.yml
@@ -1,3 +1,19 @@
 ---
+galaxy_info:
+  author: Evolix
+  description: Install redmine on a Debian install
+
+  issue_tracker_url: https://gitea.evolix.org/evolix/ansible-roles/issues
+
+  license: GPLv2
+
+  min_ansible_version: 2.2
+
+  platforms:
+    - name: Debian
+      version:
+        - jessie
+        - stretch
+
 dependencies:
   - { role: evolix/nginx }
diff --git a/redmine/tasks/mysql.yml b/redmine/tasks/mysql.yml
index 414da319..075aee96 100644
--- a/redmine/tasks/mysql.yml
+++ b/redmine/tasks/mysql.yml
@@ -13,7 +13,7 @@
   register: redmine_generate_mysql_password
   check_mode: no
   changed_when: False
-  when: redmine_get_mysql_password.stdout == ""
+  when: not redmine_get_mysql_password.stdout
   tags:
   - redmine
 
diff --git a/redmine/tasks/release.yml b/redmine/tasks/release.yml
index 730b0877..1155d31b 100644
--- a/redmine/tasks/release.yml
+++ b/redmine/tasks/release.yml
@@ -22,6 +22,7 @@
     state: stopped
     user: yes
   become_user: "{{ redmine_user }}"
+  become: yes
   environment: "{{ user_env }}"
   tags:
     - redmine
@@ -79,6 +80,7 @@
     chdir: "/home/{{ redmine_user }}/www"
     creates: "/home/{{ redmine_user }}/www/config/initializers/secret_token.rb"
   become_user: "{{ redmine_user }}"
+  become: yes
   environment: "{{ user_env }}"
   tags:
     - redmine
@@ -88,6 +90,7 @@
   args:
     chdir: "/home/{{ redmine_user }}/www/"
   become_user: "{{ redmine_user }}"
+  become: yes
   environment: "{{ user_env }}"
   tags:
     - redmine
@@ -97,6 +100,7 @@
   args:
     chdir: "/home/{{ redmine_user }}/www/"
   become_user: "{{ redmine_user }}"
+  become: yes
   environment: "{{ user_env }}"
   when: redmine_mysql_create.changed
   tags:
@@ -107,6 +111,7 @@
   args:
     chdir: "/home/{{ redmine_user }}/www/"
   become_user: "{{ redmine_user }}"
+  become: yes
   environment: "{{ user_env }}"
   tags:
     - redmine
@@ -118,6 +123,7 @@
     state: started
     user: yes
   become_user: "{{ redmine_user }}"
+  become: yes
   environment: "{{ user_env }}"
   tags:
     - redmine
diff --git a/redmine/tasks/source.yml b/redmine/tasks/source.yml
index 51427acf..94a1f552 100644
--- a/redmine/tasks/source.yml
+++ b/redmine/tasks/source.yml
@@ -57,6 +57,7 @@
     version: "{{ item.tree | default('master') }}"
     umask: "027"
   become_user: "{{ redmine_user }}"
+  become: yes
   when: item.git is defined
   with_items: "{{ redmine_plugins }}"
   tags:
@@ -82,6 +83,7 @@
     version: "{{ item.tree | default('master') }}"
     umask: "027"
   become_user: "{{ redmine_user }}"
+  become: yes
   when: item.git is defined
   with_items: "{{ redmine_themes }}"
   tags: