From 5cf81335e6a1b2a5c38e3fe965fa5c5314bc4d0e Mon Sep 17 00:00:00 2001 From: Mathieu Trossevin Date: Fri, 19 Jun 2020 10:47:35 +0200 Subject: [PATCH] [Cleanup] multiple small role cleaning Mostly whitespace and comparison with empty strings --- kvm-host/tasks/images.yml | 4 ++-- logstash/tasks/logs.yml | 2 +- logstash/tasks/tmpdir.yml | 2 +- lxc-php/tasks/main.yml | 2 +- lxc/meta/main.yml | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/kvm-host/tasks/images.yml b/kvm-host/tasks/images.yml index 420e83ec..c75279eb 100644 --- a/kvm-host/tasks/images.yml +++ b/kvm-host/tasks/images.yml @@ -13,7 +13,7 @@ changed_when: False check_mode: no register: kvm_libvirt_images_current_real_path_test - when: kvm_custom_libvirt_images_path != '' + when: kvm_custom_libvirt_images_path - name: Images directory is moved to custom path block: @@ -35,6 +35,6 @@ dest: '/var/lib/libvirt/images' state: link when: - - kvm_custom_libvirt_images_path != '' + - kvm_custom_libvirt_images_path - kvm_custom_libvirt_images_path != kvm_libvirt_images_current_real_path_test.stdout - not kvm_custom_libvirt_images_path_test.stat.exists diff --git a/logstash/tasks/logs.yml b/logstash/tasks/logs.yml index 4417bd89..bfeb1a1b 100644 --- a/logstash/tasks/logs.yml +++ b/logstash/tasks/logs.yml @@ -4,7 +4,7 @@ failed_when: False changed_when: False register: is_cron_installed - + - name: "log rotation script" template: src: rotate_logstash_logs.j2 diff --git a/logstash/tasks/tmpdir.yml b/logstash/tasks/tmpdir.yml index 4149f5af..bbf4cc91 100644 --- a/logstash/tasks/tmpdir.yml +++ b/logstash/tasks/tmpdir.yml @@ -28,4 +28,4 @@ - restart logstash tags: - logstash - when: (logstash_custom_tmpdir != '' and logstash_custom_tmpdir != None) or fstab_tmp_noexec.rc == 0 + when: (logstash_custom_tmpdir and logstash_custom_tmpdir != None) or fstab_tmp_noexec.rc == 0 diff --git a/lxc-php/tasks/main.yml b/lxc-php/tasks/main.yml index d3fcad4a..4cd9ec4f 100644 --- a/lxc-php/tasks/main.yml +++ b/lxc-php/tasks/main.yml @@ -4,7 +4,7 @@ msg: Please configure var lxc_php_version when: lxc_php_version is none -- name: "Update APT cache in container {{lxc_php_version}}" +- name: "Update APT cache in container {{ lxc_php_version }}" lxc_container: name: "{{ lxc_php_version }}" container_command: "apt-get update" diff --git a/lxc/meta/main.yml b/lxc/meta/main.yml index f6af051d..6208702b 100644 --- a/lxc/meta/main.yml +++ b/lxc/meta/main.yml @@ -1,6 +1,6 @@ galaxy_info: author: Evolix - description: Creation of LXC Containers + description: Creation of LXC Containers issue_tracker_url: https://gitea.evolix.org/evolix/ansible-roles/issues