remount-usr: do not try to remount /usr RW if /usr is not a mounted partition
Ansible Lint |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |2655|22|2633|15|:-1: Reference build: <a href="https://jenkins.evolix.org/job/gitea/job/ansible-roles/job/unstable/427//ansiblelint">Evolix » ansible-roles » unstable #427</a> Details
gitea/ansible-roles/pipeline/head This commit looks good Details

This commit is contained in:
William Hirigoyen 2023-12-08 10:11:45 +01:00
parent c90afcb4f4
commit 66b69f1502
2 changed files with 16 additions and 4 deletions

View File

@ -20,6 +20,7 @@ The **patch** part changes is incremented if multiple releases happen the same m
* etc-git: add /var/chroot-bind/etc/bind repo
* webapps/nextcloud: Set ownership and permissions of data directory
* webapps/nextcloud: Add condition for config tasks
* remount-usr: do not try to remount /usr RW if /usr is not a mounted partition
### Changed

View File

@ -1,17 +1,28 @@
---
# findmnt returns 0 on hit, 1 on miss
# If the return code is higher than 1, it's a blocking failure
- name: "check if /usr is a mountpoint"
ansible.builtin.shell: "findmnt -n /usr &> /dev/null"
register: usr_mount_exists
failed_when: False
check_mode: False
changed_when: False
- name: "check if /usr is a read-only partition"
ansible.builtin.command:
cmd: 'findmnt /usr --noheadings --options ro'
register: usr_partition
when: usr_mount_exists.rc == 0
changed_when: False
failed_when: usr_partition.rc > 1
check_mode: no
register: usr_partition
check_mode: False
- name: "mount /usr in rw"
ansible.builtin.command:
cmd: 'mount -o remount,rw /usr'
changed_when: False
when: usr_partition.rc == 0
when:
- usr_mount_exists.rc == 0
- usr_partition.rc == 0
notify: remount usr
changed_when: False