From cd2c1931b154cfe7730e3867e9d28b66f815c9a3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Dubois?= <jdubois@evolix.fr>
Date: Mon, 28 Nov 2022 17:16:28 +0100
Subject: [PATCH] keepalived: change exit code (warning if runnin but not on
 expected state ; critical if not running)

---
 CHANGELOG.md                      |  1 +
 keepalived/files/check_keepalived | 27 +++++++++++++++------------
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6fa86d5d..e24bbd8e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -40,6 +40,7 @@ The **patch** part changes is incremented if multiple releases happen the same m
 * squid: whitelist deb.freexian.com
 * varnish: better package facts usage with check mode and tags
 * varnish: systemd override depends on Varnish version instead of Debian version
+* keepalived: change exit code (warning if runnin but not on expected state ; critical if not running)
 
 ### Fixed
 
diff --git a/keepalived/files/check_keepalived b/keepalived/files/check_keepalived
index e518e99e..a457551d 100644
--- a/keepalived/files/check_keepalived
+++ b/keepalived/files/check_keepalived
@@ -18,35 +18,38 @@ MASTER='true'
 # checking if there are alive keepalived processes so we can trust the content of the notify 'state' file
 KEEPALIVENUM=`ps uax|grep '/usr/sbin/keepalived'|grep -v grep|wc -l|tr -d "\n"`
 
-if [ $KEEPALIVENUM -gt 0 ]; then
+if [ ${KEEPALIVENUM} -gt 0 ]; then
 
   KEEPALIVESTATE=`cat /var/run/keepalive.state`
 
-  if [ "$MASTER" == "true" ]; then
+  if [ "${MASTER}" == "true" ]; then
 
-    if [[ $KEEPALIVESTATE == *"MASTER"* ]];then
-      echo $KEEPALIVESTATE
+    if [[ ${KEEPALIVESTATE} == *"MASTER"* ]];then
+      echo "OK - ${KEEPALIVESTATE}"
       exit 0
     fi
 
-    if [[ $KEEPALIVESTATE == *"BACKUP"* ]];then
-      echo $KEEPALIVESTATE
-      exit 2
+    if [[ ${KEEPALIVESTATE} == *"BACKUP"* ]];then
+      echo "WARNING - ${KEEPALIVESTATE}"
+      exit 1
     fi
 
   else
 
-    if [[ $KEEPALIVESTATE == *"BACKUP"* ]];then
-      echo $KEEPALIVESTATE
+    if [[ ${KEEPALIVESTATE} == *"BACKUP"* ]];then
+      echo "OK - ${KEEPALIVESTATE}"
       exit 0
     fi
 
-    if [[ $KEEPALIVESTATE == *"MASTER"* ]];then
-      echo $KEEPALIVESTATE
-      exit 2
+    if [[ ${KEEPALIVESTATE} == *"MASTER"* ]];then
+      echo "WARNING - ${KEEPALIVESTATE}"
+      exit 1
     fi
 
   fi
+else
+    echo "CRITICAL - keepalived is not running"
+    exit 2
 fi
 
 echo "Keepalived is in UNKNOWN state"