From fc52fbf4bcc78115440b783889379b71ff516f99 Mon Sep 17 00:00:00 2001
From: Jeremy Lecour <jlecour@evolix.fr>
Date: Thu, 20 Oct 2022 14:36:47 +0200
Subject: [PATCH] redis: some values should be quoted

When Redis overwrites its own config, it uses quoted string values, so it's better to do the same to avoid changes.
---
 CHANGELOG.md                  |  5 +++--
 redis/templates/redis.conf.j2 | 14 +++++++-------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 714e161e..da7c4dbc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,14 +17,15 @@ The **patch** part changes is incremented if multiple releases happen the same m
 ### Changed
 
 * evolinux-base: utils.yml can be excluded
+* evolinux-todo: execute tasks only for Debian distribution (because this task is a dependency for others roles used on different distributions)
 * evolinux-user: Add sudoers privilege for chck php\_fpm81
 * java: use default JRE package when version is not specified
-* lxc-solr: download URL according to Solr Version
 * lxc-solr: detect the real partition options
+* lxc-solr: download URL according to Solr Version
 * lxc-solr: set homedir and port at install
 * minifirewall: whitelist deb.freexian.com
+* redis: some values should be quoted
 * squid: whitelist deb.freexian.com
-* evolinux-todo: execute tasks only for Debian distribution (because this task is a dependency for others roles used on different distributions)
 
 ### Fixed
 
diff --git a/redis/templates/redis.conf.j2 b/redis/templates/redis.conf.j2
index 720f724f..4afced22 100644
--- a/redis/templates/redis.conf.j2
+++ b/redis/templates/redis.conf.j2
@@ -1,24 +1,24 @@
 daemonize yes
-pidfile {{ redis_pid_dir }}/redis-server.pid
+pidfile "{{ redis_pid_dir }}/redis-server.pid"
 port {{ redis_port }}
 bind {{ redis_bind_interfaces | join(' ') }}
 
 {% if redis_socket_enabled %}
-unixsocket {{ redis_socket_dir }}/redis.sock
+unixsocket "{{ redis_socket_dir }}/redis.sock"
 unixsocketperm {{ redis_socket_perms }}
 {% endif %}
 
 {% if redis_password %}
-requirepass {{ redis_password }}
+requirepass "{{ redis_password }}"
 {% endif %}
 {% if redis_password_master %}
-masterauth {{ redis_password_master }}
+masterauth "{{ redis_password_master }}"
 {% endif %}
 
 timeout {{ redis_timeout }}
 
 loglevel {{ redis_log_level }}
-logfile {{ redis_log_dir }}/redis-server.log
+logfile "{{ redis_log_dir }}/redis-server.log"
 
 # To enable logging to the system logger, just set 'syslog-enabled' to yes,
 # and optionally update the other syslog parameters to suit your needs.
@@ -33,8 +33,8 @@ save {{ save }}
 {% endfor %}
 
 rdbcompression {{ redis_rdbcompression | bool | ternary('yes','no') }}
-dbfilename {{ redis_data_file }}
-dir {{ redis_data_dir }}
+dbfilename "{{ redis_data_file }}"
+dir "{{ redis_data_dir }}"
 
 {% if redis_installed_version is version('3.2', '>=') %}
 protected-mode {{ redis_protected_mode | bool | ternary('yes','no') }}