Refactor userlogrotate #115

New Issue

Open

opened 2020-09-21 15:45:08 +02:00 by bwaegeneire · 0 comments

bwaegeneire commented

2020-09-21 15:45:08 +02:00

Owner

The script userlogrotate (./packweb-apache/files/userlogrotate) is mixing logic and data which make it difficult to adjust on specific system and prone of issue when doing such modification. Having a variable containg the list of logs to rotate would make it easier to add and remove files from it.

By default the rotate function shouldn't modify the ownership of the log file and just use the log before rotation.

See evoticket 52982 for an example of a failing attempt to modify this script.

The script `userlogrotate` (`./packweb-apache/files/userlogrotate`) is mixing logic and data which make it difficult to adjust on specific system and prone of issue when doing such modification. Having a variable containg the list of logs to rotate would make it easier to add and remove files from it. By default the `rotate` function shouldn't modify the ownership of the log file and just use the log before rotation. See evoticket 52982 for an example of a failing attempt to modify this script.