Cleanup #107

Open
mtrossevin wants to merge 23 commits from mtrossevin/ansible-roles:cleanup into unstable

23 Commits

Author SHA1 Message Date
Mathieu Trossevin 62dce66cbd
Cleanup: Update changelog
continuous-integration/drone/pr Build is failing Details
2020-12-23 15:10:21 +01:00
Mathieu Trossevin fe7d9290bf
[Cleanup] whitespaces + missed space before/after var name 2020-12-23 15:08:45 +01:00
Mathieu Trossevin 208d7d603c
[Cleanup] webapps
Probably the most dangerous part of the cleanup, replace call to the
shell module that don't seems to make use of shell features with the
command module.
2020-12-23 15:08:45 +01:00
Mathieu Trossevin 6fb78be66c
[Cleanup] munin: space before and after variable names 2020-12-23 15:08:44 +01:00
Mathieu Trossevin c51669531b
[Cleanup] squid: Compare with empty string + name tasks 2020-12-23 15:08:44 +01:00
Mathieu Trossevin 2b08a2d81d
[Cleanup] redmine
Add galaxy_info to meta/main (based on the one on the wiki)

Add become to all tasks that have become_user defined
2020-12-23 15:08:44 +01:00
Mathieu Trossevin 082e02fe6f
[Cleanup] redis
Space before and after variable names, comparison with empty strings and
naming two tasks
2020-12-23 15:08:44 +01:00
Mathieu Trossevin 9e0202d3de
[Cleanup] postgresql: space before and after variable name 2020-12-23 15:08:43 +01:00
Mathieu Trossevin 119e134373
[Cleanup] php and postfix
Comparison with litteral True and False ( `var == False` ⇔ `not var` or
`var is boolean and var` or ` var is sameas False` should there be a
need to check if it is really a boolean that is False and not only
something evaluationg to False)
2020-12-23 15:08:43 +01:00
Mathieu Trossevin dc5d206488
[Cleanup] packweb-apache 2020-12-23 15:08:43 +01:00
Mathieu Trossevin 498d85b549
[Cleanup] nginx: whitespace + comparison with empty string 2020-12-23 15:08:43 +01:00
Mathieu Trossevin c3caa31bf2
[Cleanup] newrelic, don't compare to empty string 2020-12-23 15:08:42 +01:00
Mathieu Trossevin 97d3d29210
[Cleanup] networkd-to-ifconfig
Add changed_when: false to shell command that does not change anything.
2020-12-23 15:08:42 +01:00
Mathieu Trossevin 478beab856
[Cleanup] mysql-oracle (name + comparison with empty string) 2020-12-23 15:08:42 +01:00
Mathieu Trossevin 93f981be3b
[Cleanup] memcached and metricbeat
Don't compare with empty string
2020-12-23 15:08:40 +01:00
Mathieu Trossevin d206ae4c85
[Cleanup] lxc-solr
Replaced direct call to lxc-attach with the lxc_container module calling
a container_command.

(+ spaces before and after variable name)
2020-12-23 15:06:43 +01:00
Mathieu Trossevin 5cf81335e6
[Cleanup] multiple small role cleaning
Mostly whitespace and comparison with empty strings
2020-12-23 15:06:42 +01:00
Mathieu Trossevin 440bec2feb
[Cleanup] fail2ban
Name all tasks.

It would seems that the task creating the `fail2ban_ignore_ips` fact for
the whitelist exist in both main.yml and ip_whitelist.yml, one of them
might be superfluous.
2020-12-23 15:06:42 +01:00
Mathieu Trossevin 63a0894906
[Cleanup] Clean up elasticsearch role
Don't compare with empty string

Explicitly checkout master branch of head repository.

Space after variable name
2020-12-23 15:06:42 +01:00
Mathieu Trossevin 26eec48954
[Cleanup] amazon-ec2, apache, bind, evolinux-todo, evomaintenance
Don't compare with empty string

Name all tasks

Variables should have space before and after their name
2020-12-23 15:06:41 +01:00
Mathieu Trossevin 0825d88552
[Cleanup] Clean up evoacme and evocheck roles
Don't compare with empty string as an empty string is already false and
a non-empty string is already true.

Name all tasks.
2020-12-23 15:06:38 +01:00
Mathieu Trossevin 3ec85f9560
[Cleanup] Clean up evolinux-base and evolinux-users
evolinux-users: Add name to all tasks for self documentation purposes
and don't compare with empty string.

evolinux-base: Remove trailing whitespaces.
2020-12-23 15:05:04 +01:00
Mathieu Trossevin 2036db938b
[Cleanup] Cleanup the mysql role
Remove the useless call for `cat` as `grep` take a file as it's second
argument that tell it to search for the pattern in a specific file
instead of whatever is passed to it through stdin.

Name both task defining the position of the config directory for
self-documentation purposes (and please ansible-lint defaults).

Change role description to it's description in the readme instead of the
default description asking for the role to be described.

Don't compare to empty string, an empty string is already false while a
non-empty string is true.
2020-12-23 15:02:20 +01:00