[WIP] Allow more --check runs #167

Draft
dprevot wants to merge 1 commit from when-not-check into unstable
Owner

Use “when: not ansible_check_mode” or “when .stat.exists or not
ansible_check_mode” in order to provide a meaningful diff if possible.

This is an improvement from the previously reverted commit
1728eaee68.

(Still work in progress, not ready for merge: just a request for
comment. I’ve reviewed my previous commit until minifirewall, will
continue starting with munin.)

Use “when: not ansible_check_mode” or “when <file>.stat.exists or not ansible_check_mode” in order to provide a meaningful diff if possible. This is an improvement from the previously reverted commit 1728eaee68118ac67477ae01c5c09486aa36b2f2. (Still work in progress, not ready for merge: just a request for comment. I’ve reviewed my previous commit until minifirewall, will continue starting with munin.)
dprevot added 1 commit 2022-12-21 18:15:38 +01:00
Allow more --check runs
All checks were successful
gitea/ansible-roles/pipeline/head This commit looks good
fc692cf65b
Use “when: not ansible_check_mode” or “when <file>.stat.exists or not
ansible_check_mode” in order to provide a meaningful diff if possible.

This is an improvement from the previously reverted commit
1728eaee68.
dprevot added 1 commit 2022-12-23 16:39:38 +01:00
Use “when: not ansible_check_mode” or “when <file>.stat.exists or not
ansible_check_mode” in order to provide a meaningful diff if possible.

This is an improvement from the previously reverted commit
1728eaee68.
Author
Owner

tl;dr: more improvements are on the way.

Added some tags to make the whole (start of the) thing work. I also wonder about allowing the restart/reload handlers: would be nice to have them when the packages are installed, but AFAIUI, it’s tricky to make sure a variable is actually registered during the handlers call.

tl;dr: more improvements are on the way. Added some tags to make the whole (start of the) thing work. I also wonder about allowing the restart/reload handlers: would be nice to have them when the packages are installed, but AFAIUI, it’s tricky to make sure a variable is actually registered during the handlers call.
This pull request has changes conflicting with the target branch.
  • apache/tasks/auth.yml
  • apache/tasks/ip_whitelist.yml
  • apache/tasks/main.yml
  • apache/tasks/server_status.yml
  • evoacme/handlers/main.yml
  • evolinux-base/tasks/hardware.yml
  • evolinux-base/tasks/log2mail.yml
  • evolinux-base/tasks/postfix.yml
  • lxc-php/tasks/php74.yml
  • lxc-php/tasks/php80.yml

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin when-not-check:when-not-check
git checkout when-not-check

Merge

Merge the changes and update on Forgejo.
git checkout unstable
git merge --no-ff when-not-check
git checkout unstable
git merge --ff-only when-not-check
git checkout when-not-check
git rebase unstable
git checkout unstable
git merge --no-ff when-not-check
git checkout unstable
git merge --squash when-not-check
git checkout unstable
git merge --ff-only when-not-check
git checkout unstable
git merge when-not-check
git push origin unstable
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/ansible-roles#167
No description provided.