evolix
/
ansible-roles
16
2
Fork 2
Code Issues 61 Pull Requests 18 Releases 28 Wiki Activity

Labels Milestones

[WIP] Allow more --check runs #167

Draft
dprevot wants to merge 1 commits from when-not-check into unstable
pull from: when-not-check
merge into: evolix:unstable
Conversation 1 Commits 1 Files Changed 54
dprevot commented 5 months ago
Owner

Use “when: not ansible_check_mode” or “when .stat.exists or not
ansible_check_mode” in order to provide a meaningful diff if possible.

This is an improvement from the previously reverted commit
1728eaee68.

(Still work in progress, not ready for merge: just a request for
comment. I’ve reviewed my previous commit until minifirewall, will
continue starting with munin.)

Use “when: not ansible_check_mode” or “when <file>.stat.exists or not ansible_check_mode” in order to provide a meaningful diff if possible. This is an improvement from the previously reverted commit 1728eaee68118ac67477ae01c5c09486aa36b2f2. (Still work in progress, not ready for merge: just a request for comment. I’ve reviewed my previous commit until minifirewall, will continue starting with munin.)
dprevot added 1 commit 5 months ago
gitea/ansible-roles/pipeline/head This commit looks good Details
fc692cf65b Allow more --check runs 
Use “when: not ansible_check_mode” or “when <file>.stat.exists or not
ansible_check_mode” in order to provide a meaningful diff if possible.

This is an improvement from the previously reverted commit
1728eaee68.
dprevot added 1 commit 5 months ago
61f2096fad Allow more --check runs 
Use “when: not ansible_check_mode” or “when <file>.stat.exists or not
ansible_check_mode” in order to provide a meaningful diff if possible.

This is an improvement from the previously reverted commit
1728eaee68.
dprevot commented 5 months ago
Poster
Owner

tl;dr: more improvements are on the way.

Added some tags to make the whole (start of the) thing work. I also wonder about allowing the restart/reload handlers: would be nice to have them when the packages are installed, but AFAIUI, it’s tricky to make sure a variable is actually registered during the handlers call.

tl;dr: more improvements are on the way. Added some tags to make the whole (start of the) thing work. I also wonder about allowing the restart/reload handlers: would be nice to have them when the packages are installed, but AFAIUI, it’s tricky to make sure a variable is actually registered during the handlers call.
This pull request has changes conflicting with the target branch.
  • apache/tasks/auth.yml
  • apache/tasks/ip_whitelist.yml
  • apache/tasks/main.yml
  • apache/tasks/server_status.yml
  • evoacme/handlers/main.yml
  • evolinux-base/tasks/hardware.yml
  • evolinux-base/tasks/postfix.yml
  • munin/handlers/main.yml
  • mysql/tasks/packages_stretch.yml
  • php/handlers/main.yml
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b when-not-check unstable
git pull origin when-not-check

Step 2:

Merge the changes and update on Gitea.
git checkout unstable
git merge --no-ff when-not-check
git push origin unstable
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
security

Concern a security issue   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
security
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: evolix/ansible-roles#167
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'when-not-check'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes