evolix
/
ansible-roles
22
2
Fork 2
Code Issues 61 Pull Requests 18 Releases 32 Wiki Activity

nagios-nrpe role does not define it's own sudo rights #77

Closed
Ghost wants to merge 2 commits from nagios-sudoers into buster
pull from: nagios-sudoers
merge into: evolix:buster
Conversation 5 Commits 2 Files Changed 4 +15 -12
Ghost commented 2019-08-06 21:09:34 +02:00
First-time contributor
Copy Link

Based on the discussion in #49

I'm creating a new pull request since this is planned for buster.

Based on the discussion in #49 I'm creating a new pull request since this is planned for buster.
Ghost added this to the Debian 11 (Buster) milestone 2019-08-06 21:09:34 +02:00
jlecour was assigned by Ghost 2019-08-06 21:09:34 +02:00
Ghost added the
bug
 label 2019-08-06 21:09:34 +02:00
jlecour commented 2019-09-07 13:35:52 +02:00
Owner
Copy Link

I approve this idea. We should have a round of discussion with the rest of the team to verify that there is no hidden issue with that.

I approve this idea. We should have a round of discussion with the rest of the team to verify that there is no hidden issue with that.
Ghost commented 2019-10-10 22:46:57 +02:00
Author
First-time contributor
Copy Link

Can we merge this now or are we still waiting on somebody's input ?

Can we merge this now or are we still waiting on somebody's input ?
Ghost commented 2019-10-11 10:51:13 +02:00
Author
First-time contributor
Copy Link

LGTM

LGTM
lpoujol commented 2019-11-25 11:04:34 +01:00
Owner
Copy Link

I'm not fully comfortable with that PR in it's current state.

First because it's not targeting a specific release of Debian. We don't want to apply this to Jessie and Stretch. If we target buster, that would require "fixing" all buster (as we want uniformity). Otherwise I'd wait for Bullseye.

Second, I think we need to be more careful with that change as we could be in situations where no sudo commands are defined for nagios, or defined in both files (Side note: If it's defined two files, will it work ? or break sudo config ?)

I'm not fully comfortable with that PR in it's current state. First because it's not targeting a specific release of Debian. We don't want to apply this to Jessie and Stretch. If we target buster, that would require "fixing" all buster (as we want uniformity). Otherwise I'd wait for Bullseye. Second, I think we need to be more careful with that change as we could be in situations where no sudo commands are defined for nagios, or defined in both files (Side note: If it's defined two files, will it work ? or break sudo config ?)
lpoujol requested changes 2019-11-25 11:05:22 +01:00
lpoujol left a comment
Owner
Copy Link

I’m not fully comfortable with that PR in it’s current state.

First because it’s not targeting a specific release of Debian. We don’t want to apply this to Jessie and Stretch. If we target buster, that would require “fixing” all buster (as we want uniformity). Otherwise I’d wait for Bullseye.

Second, I think we need to be more careful with that change as we could be in situations where no sudo commands are defined for nagios, or defined in both files (Side note: If it’s defined two files, will it work ? or break sudo config ?)

I’m not fully comfortable with that PR in it’s current state. First because it’s not targeting a specific release of Debian. We don’t want to apply this to Jessie and Stretch. If we target buster, that would require “fixing” all buster (as we want uniformity). Otherwise I’d wait for Bullseye. Second, I think we need to be more careful with that change as we could be in situations where no sudo commands are defined for nagios, or defined in both files (Side note: If it’s defined two files, will it work ? or break sudo config ?)
lpoujol requested changes 2019-11-25 11:06:02 +01:00
lpoujol left a comment
Owner
Copy Link

I'm not full comfortable with that. I've explained in depth with my message in the PR discussion

I'm not full comfortable with that. I've explained in depth with my message in the PR discussion
Ghost commented 2019-11-25 17:54:03 +01:00
Author
First-time contributor
Copy Link

I was initially told that we should wait for buster to merge this. Now we're talking about waiting for bullseye ? Nobody thought to check if we had any buster stuff to merge before starting to deploy buster machines, how is this not going to happen again for bullseye ?

I was initially told that we should wait for buster to merge this. Now we're talking about waiting for bullseye ? Nobody thought to check if we had any buster stuff to merge before starting to deploy buster machines, how is this not going to happen again for bullseye ?
jlecour closed this pull request 2020-08-21 14:41:50 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
security

Concern a security issue

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Debian 11 (Buster)
Assignees
Clear assignees
No Assignees
jlecour
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: evolix/ansible-roles#77
No description provided.
Delete Branch "nagios-sudoers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?