evolix/ansible-roles
22
2
Fork 2
Code Issues 61 Pull requests 18 Releases 34 Wiki Activity

Added evobackup-client role #83

Manually merged
Ghost merged 17 commits from evobackup-client into unstable 2020-02-06 22:31:45 +01:00
Conversation 5 Commits 17 Files changed 11 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit f9b55c0c91 - Show all commits

2
evobackup-client/templates/zzz_evobackup.default.sh.j2
View file

@ -19,7 +19,7 @@
# email adress for notifications
MAIL={{ evobackup-client__mail }}
{{ evobackup-client__hosts | map
jlecour commented 2019-09-03 18:07:24 +02:00
Outdated
Review
Copy link

This probably is a bad copy/paste.

This probably is a bad copy/paste.
Ghost commented 2019-09-03 18:12:08 +02:00
Outdated
Review
Copy link

Damnit, thought I had erased that.

Damnit, thought I had erased that.
# list of hosts (hostname or IP) and SSH port for Rsync
SERVERS="{% for host in evobackup-client__hosts %}{{ host.name }}:{{ host.port }}{% if loop.index != loop.length %} {% endif %}{% endfor %}"
jlecour commented 2019-09-02 08:53:29 +02:00
Outdated
Review
Copy link

i'm not sure this loop produces the intended output.

i'm not sure this loop produces the intended output.
Ghost commented 2019-09-03 15:23:13 +02:00
Outdated
Review
Copy link

It produces:

SERVERS="hostname:port hostname:port "

The extra space at the end is not the cleanest, but it does not break the script.

It produces: ``` SERVERS="hostname:port hostname:port " ``` The extra space at the end is not the cleanest, but it does not break the script.
Ghost commented 2019-09-03 15:24:03 +02:00
Outdated
Review
Copy link

But this is kind of reason why it's a pull request and not a straight merge.

But this is kind of reason why it's a pull request and not a straight merge.
Ghost commented 2019-09-03 15:54:28 +02:00
Outdated
Review
Copy link

This should not be marked as outdated, this conversation is still open.

This should not be marked as outdated, this conversation is still open.