Revamping default pools file for PHP-FPM #95

Merged

lpoujol merged 3 commits from lpoujol/fpm-php into unstable

2020-01-16 15:56:34 +01:00

lpoujol commented

2019-10-18 16:47:35 +02:00

Owner

This pull request on the PHP role, targets the FPM part of it with the following objectives :

Have a default pool defined that can be fully functional on it's own (ie: Without the Debian default pool file)
Rename files (and variables) around the definition of the default pool

More details bellow :

Functional default pool

If Debian default pool file is deleted/absent, FPM won't be able to run because some settings are missing on the www pool. I've introduced the following settings (extracted from Debian's default pool) :

user = www-data
group = www-data
listen = {{ php_fpm_default_pool_socket }}
listen.owner = www-data
listen.group = www-data

Renaming files and variables

Because it's more than just pure configuration, but a (complete) fpm pool
definition, I've changed the following variables in Ansible :

php_fpm_defaults_conf_file to replaced by php_fpm_default_pool_file
php_fpm_custom_conf_file to php_fpm_default_pool_custom_file

On the FPM side, I've also changed the files names of the pool to make
them more explicit. No more z and zzz. It's the www pool, so let's put
www in the file name for coherence :

z-evolinux-defaults.conf changes to www-evolinux-defaults.conf
zzz-evolinux-custom.conf changes to www-evolinux-zcustom.conf

I've also introduced php_fpm_remove_default_pool, that will remove Debian's default FPM pool (the www.conf file). It's set to False by default

This pull request on the PHP role, targets the FPM part of it with the following objectives : - [x] Have a default pool defined that can be fully functional on it's own (ie: Without the Debian default pool file) - [x] Rename files (and variables) around the definition of the default pool More details bellow : # Functional default pool If Debian default pool file is deleted/absent, FPM won't be able to run because some settings are missing on the www pool. I've introduced the following settings (extracted from Debian's default pool) : ``` user = www-data group = www-data listen = {{ php_fpm_default_pool_socket }} listen.owner = www-data listen.group = www-data ``` # Renaming files and variables Because it's more than just pure configuration, but a (complete) fpm pool definition, I've changed the following variables in Ansible : - `php_fpm_defaults_conf_file` to replaced by `php_fpm_default_pool_file` - `php_fpm_custom_conf_file` to `php_fpm_default_pool_custom_file` On the FPM side, I've also changed the files names of the pool to make them more explicit. No more z and zzz. It's the www pool, so let's put www in the file name for coherence : - `z-evolinux-defaults.conf` changes to `www-evolinux-defaults.conf` - `zzz-evolinux-custom.conf` changes to `www-evolinux-zcustom.conf` I've also introduced `php_fpm_remove_default_pool`, that will remove Debian's default FPM pool (the www.conf file). It's set to **False** by default