From eff791007850ff021feda1285dd9555206280a8d Mon Sep 17 00:00:00 2001 From: Jeremy Lecour Date: Fri, 31 Aug 2018 16:24:45 +0200 Subject: [PATCH 1/3] Enable QUIET mode and keep standard output --- config/schedule.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/config/schedule.rb b/config/schedule.rb index 3d8193d..22d8885 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -5,7 +5,8 @@ set :output, standard: "log/cron.log" -# +job_type :rake_with_stdout, "cd :path && :environment_variable=:environment bundle exec rake :task" + # every 2.hours do # command "/usr/bin/some_great_command" # runner "MyModel.some_method" @@ -19,7 +20,7 @@ set :output, standard: "log/cron.log" # Learn more: http://github.com/javan/whenever every 1.day, at: '1:00 am', roles: [:app] do - rake "checks:sync_dates:all" + rake_with_stdout "checks:sync_dates:all QUIET=1" end every 1.day, at: '8:30 am', roles: [:app] do From defe371a22edbd85e734971ee416d89432d4f779 Mon Sep 17 00:00:00 2001 From: Jeremy Lecour Date: Mon, 3 Sep 2018 14:05:07 +0200 Subject: [PATCH 2/3] Add debug information on CheckProcessor --- app/services/check_processor.rb | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/services/check_processor.rb b/app/services/check_processor.rb index 1b77758..8bb2b17 100644 --- a/app/services/check_processor.rb +++ b/app/services/check_processor.rb @@ -29,10 +29,15 @@ module CheckProcessor end group_finished_at = Time.now + check_ids = checks.map(&:id) + check_logs = check_errors_scope(check_ids: check_ids, + after_date: group_started_at, + before_date: group_finished_at).includes(:check).all - check_errors_scope(check_ids: checks.map(&:id), - after_date: group_started_at, - before_date: group_finished_at).includes(:check).each do |check_log| + message = "#{self.class.name}: #{check_logs.count} error(s) found for checks '#{check_ids.join(',')}' between '#{group_started_at}' and '#{group_finished_at}'" # rubocop:disable Metrics/LineLength + logger.debug(message) + + check_logs.each do |check_log| message = "#{self.class.name}: check ##{check_log.check_id} for '#{check_log.check.domain}' failed (#{check_log.exit_status}) ; #{check_log.error.lines.first}" # rubocop:disable Metrics/LineLength logger.error(message) end From 51528563340c597f9265c249cef58d5de5913d45 Mon Sep 17 00:00:00 2001 From: Jeremy Lecour Date: Mon, 3 Sep 2018 14:06:06 +0200 Subject: [PATCH 3/3] rake checks:sync_dates:all VERBOSE=1 (temporary) --- config/schedule.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/schedule.rb b/config/schedule.rb index 22d8885..179cbaf 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -20,7 +20,7 @@ job_type :rake_with_stdout, "cd :path && :environment_variable=:environment bund # Learn more: http://github.com/javan/whenever every 1.day, at: '1:00 am', roles: [:app] do - rake_with_stdout "checks:sync_dates:all QUIET=1" + rake_with_stdout "checks:sync_dates:all VERBOSE=1" end every 1.day, at: '8:30 am', roles: [:app] do