Remove a lot of useless "require" thanks to Zeitwerk

app/jobs/ssl_sync_job.rb

@@ -1,3 +1,5 @@
+# require "ssl/errors"
+
 class SSLSyncJob < ApplicationJob
   queue_as :default
 

app/jobs/whois_sync_job.rb

@@ -1,3 +1,5 @@
+# require "whois/errors"
+
 class WhoisSyncJob < ApplicationJob
   queue_as :default
 

app/services/notifier.rb

@@ -1,7 +1,7 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "notifier/processor"
+# require "notifier/processor"
 
 module Notifier
   class << self

app/services/null_logger.rb

@@ -1,6 +1,6 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "naught"
+# require "naught"
 
 NullLogger = Naught.build

app/services/ssl.rb

@@ -1,13 +1,23 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "null_logger"
-require "system_command"
-require_relative "ssl/parser"
-require_relative "ssl/response"
-require_relative "ssl/errors"
+# require "null_logger"
+# require "system_command"
+# require_relative "ssl/parser"
+# require_relative "ssl/response"
+# require_relative "ssl/errors"
 
 module SSL
+  class Error < StandardError; end
+
+  class SSLCommandError < Error; end
+  class SSLConfigurationError < Error; end
+
+  class ParserError < Error; end
+  class DomainNotMatchError < ParserError; end
+  class InvalidResponseError < ParserError; end
+  class InvalidDateError < ParserError; end
+
   class << self
     def ask(domain, system_klass: SystemCommand, logger: NullLogger.new)
       Service.new(domain, system_klass: system_klass, logger: logger).call

app/services/ssl/errors.rb

@@ -1,14 +0,0 @@
-# Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
-# License: GNU AGPL-3+ (see full text in LICENSE file)
-
-module SSL
-  class Error < StandardError; end
-
-  class SSLCommandError < Error; end
-  class SSLConfigurationError < Error; end
-
-  class ParserError < Error; end
-  class DomainNotMatchError < ParserError; end
-  class InvalidResponseError < ParserError; end
-  class InvalidDateError < ParserError; end
-end

app/services/ssl/parser.rb

@@ -1,8 +1,8 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "null_logger"
-require "ssl/errors"
+# require "null_logger"
+# require "ssl/errors"
 
 module SSL
   class Parser

app/services/system_command.rb

@@ -1,12 +1,13 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "open4"
-require "null_logger"
-
-SystemCommandResult = Struct.new(:command, :exit_status, :stdout, :stderr)
+# require "open4"
+# require "null_logger"
 
 class SystemCommand
+  Result = Struct.new(:command, :exit_status, :stdout, :stderr)
+  class NotAllowedError < StandardError; end
+
   attr_reader :program
   attr_reader :args
   attr_reader :logger
@@ -42,7 +43,7 @@ class SystemCommand
     pid, _, stdout, stderr = Open4.popen4 cmd
     _, status = Process.waitpid2 pid
 
-    SystemCommandResult.new(
+    Result.new(
       syscmd,
       status.exitstatus || 255,
       stdout.read.strip,

app/services/whois.rb

@@ -1,14 +1,24 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "null_logger"
-require "domain_helper"
-require "system_command"
-require_relative "whois/parser"
-require_relative "whois/response"
-require_relative "whois/errors"
+# require "null_logger"
+# require "domain_helper"
+# require "system_command"
+# require_relative "whois/parser"
+# require_relative "whois/response"
+# require_relative "whois/errors"
 
 module Whois
+  class Error < StandardError; end
+
+  class WhoisCommandError < Error; end
+  class UnsupportedDomainError < Error; end
+  class DomainNotFoundError < Error; end
+  class ParserError < Error; end
+
+  class FieldNotFoundError < ParserError; end
+  class InvalidDateError < ParserError; end
+
   class << self
     def ask(domain, system_klass: SystemCommand, logger: NullLogger.new)
       Service.new(domain, system_klass: system_klass, logger: logger).call

app/services/whois/errors.rb

@@ -1,14 +0,0 @@
-# Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
-# License: GNU AGPL-3+ (see full text in LICENSE file)
-
-module Whois
-  class Error < StandardError; end
-
-  class WhoisCommandError < Error; end
-  class UnsupportedDomainError < Error; end
-  class DomainNotFoundError < Error; end
-  class ParserError < Error; end
-
-  class FieldNotFoundError < ParserError; end
-  class InvalidDateError < ParserError; end
-end

app/services/whois/parser.rb

@@ -1,15 +1,15 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "null_logger"
-require "whois/errors"
-require "whois/parser/afilias"
-require "whois/parser/afnic"
-require "whois/parser/cira"
-require "whois/parser/io"
-require "whois/parser/neustar"
-require "whois/parser/sonic"
-require "whois/parser/verisign"
+# require "null_logger"
+# require "whois/errors"
+# require "whois/parser/afilias"
+# require "whois/parser/afnic"
+# require "whois/parser/cira"
+# require "whois/parser/io"
+# require "whois/parser/neustar"
+# require "whois/parser/sonic"
+# require "whois/parser/verisign"
 
 module Whois
   module Parser

app/services/whois/parser/afilias.rb

@@ -1,9 +1,9 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "domain_helper"
-require "whois/errors"
-require_relative "base"
+# require "domain_helper"
+# require "whois/errors"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/afnic.rb

@@ -1,9 +1,9 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "domain_helper"
-require "whois/errors"
-require_relative "base"
+# require "domain_helper"
+# require "whois/errors"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/base.rb

@@ -1,10 +1,10 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "null_logger"
+# require "null_logger"
 require_relative "../response"
-require_relative "../errors"
-require_relative "entry_builder"
+# require_relative "../errors"
+# require_relative "entry_builder"
 
 module Whois
   module Parser

app/services/whois/parser/cira.rb

@@ -1,9 +1,9 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "domain_helper"
-require "whois/errors"
-require_relative "base"
+# require "domain_helper"
+# require "whois/errors"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/entry/blank.rb

@@ -1,7 +1,7 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require_relative "base"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/entry/field.rb

@@ -1,7 +1,7 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require_relative "base"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/entry/text.rb

@@ -1,7 +1,7 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require_relative "base"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/entry_builder.rb

@@ -1,9 +1,9 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require_relative "entry/blank"
-require_relative "entry/field"
-require_relative "entry/text"
+# require_relative "entry/blank"
+# require_relative "entry/field"
+# require_relative "entry/text"
 
 module Whois
   module Parser

app/services/whois/parser/io.rb

@@ -1,9 +1,9 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "domain_helper"
-require "whois/errors"
-require_relative "base"
+# require "domain_helper"
+# require "whois/errors"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/neustar.rb

@@ -1,9 +1,9 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "domain_helper"
-require "whois/errors"
-require_relative "base"
+# require "domain_helper"
+# require "whois/errors"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/sonic.rb

@@ -1,9 +1,9 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "domain_helper"
-require "whois/errors"
-require_relative "base"
+# require "domain_helper"
+# require "whois/errors"
+# require_relative "base"
 
 module Whois
   module Parser

app/services/whois/parser/verisign.rb

@@ -1,9 +1,9 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "domain_helper"
-require "whois/errors"
-require_relative "base"
+# require "domain_helper"
+# require "whois/errors"
+# require_relative "base"
 
 module Whois
   module Parser

config/environment.rb

@@ -3,3 +3,7 @@ require_relative 'application'
 
 # Initialize the Rails application.
 Rails.application.initialize!
+# binding.pry
+
+# Rails.autoloaders.main
+# loader.push_dir(Rails.root.join("app/services"))

config/initializers/inflections.rb

@@ -13,4 +13,7 @@
 # These inflection rules are supported but not enabled by default:
 ActiveSupport::Inflector.inflections(:en) do |inflect|
   inflect.acronym 'SSL'
+  inflect.acronym 'AFNIC'
+  inflect.acronym 'CIRA'
+  inflect.acronym 'IO'
 end

lib/errors.rb

@@ -1,4 +0,0 @@
-# Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
-# License: GNU AGPL-3+ (see full text in LICENSE file)
-
-class SystemCommandNotAllowedError < StandardError; end

lib/tasks/checks.rake

@@ -1,7 +1,7 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "null_logger"
+# require "null_logger"
 
 namespace :checks do
   namespace :sync_dates do

package.json

@@ -2,12 +2,12 @@
   "name": "chexpire",
   "private": true,
   "dependencies": {
+    "@rails/ujs": "^6.0.0-alpha",
     "@rails/webpacker": "3.5",
     "bootstrap": "^4.1.1",
     "exports-loader": "^0.7.0",
     "jquery": "^3.3.1",
     "popper.js": "^1.14.3",
-    "@rails/ujs": "^6.0.0-alpha",
     "turbolinks": "^5.2.0"
   },
   "devDependencies": {

test/helpers/domain_helper_test.rb

@@ -2,7 +2,7 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "domain_helper"
+# require "domain_helper"
 
 class DomainHelperTest < ActiveSupport::TestCase
   include DomainHelper

test/services/check_logger_test.rb

@@ -3,7 +3,7 @@
 
 require "test_helper"
 require "check_logger"
-require "system_command"
+# require "system_command"
 
 class CheckLoggerTest < ActiveSupport::TestCase
   setup do
@@ -20,7 +20,7 @@ class CheckLoggerTest < ActiveSupport::TestCase
   end
 
   test "should log a success raw result command" do
-    result = SystemCommandResult.new("command", 0, "the result", "")
+    result = SystemCommand::Result.new("command", 0, "the result", "")
 
     assert_no_difference -> { CheckLog.where(check: @check).count } do
       @logger.log :after_command, result
@@ -33,7 +33,7 @@ class CheckLoggerTest < ActiveSupport::TestCase
   end
 
   test "should log a raw result command with an error" do
-    result = SystemCommandResult.new("command", 1, "optional stdout", "an error occured")
+    result = SystemCommand::Result.new("command", 1, "optional stdout", "an error occured")
     @logger.log :after_command, result
 
     assert_equal "optional stdout", @logger.check_log.raw_response
@@ -43,7 +43,7 @@ class CheckLoggerTest < ActiveSupport::TestCase
   end
 
   test "should log an error when there is not exit status" do
-    result = SystemCommandResult.new("command", nil, nil, "an error")
+    result = SystemCommand::Result.new("command", nil, nil, "an error")
     @logger.log :after_command, result
 
     assert_nil @logger.check_log.raw_response

test/services/ssl/parser_test.rb

@@ -2,8 +2,8 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "ssl/parser"
-require "ssl/errors"
+# require "ssl/parser"
+# require "ssl/errors"
 
 module SSL
   class ParserTest < ActiveSupport::TestCase

test/services/ssl_test.rb

@@ -3,7 +3,7 @@
 
 require "test_helper"
 require "ssl"
-require "system_command"
+# require "system_command"
 
 module SSL
   class ServiceTest < ActiveSupport::TestCase

test/services/system_command_test.rb

@@ -2,14 +2,14 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "system_command"
+# require "system_command"
 
 class SystemCommandTest < ActiveSupport::TestCase
   test "should execute and log a command" do
     mock_logger = Minitest::Mock.new
     expected_cmd = 'whois "example.org"'
 
-    expected_result = SystemCommandResult.new(
+    expected_result = SystemCommand::Result.new(
       expected_cmd,
       0,
       "my result",

test/services/whois/parser/afilias_test.rb

@@ -2,9 +2,9 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois/parser/afilias"
-require "whois/response"
-require "whois/errors"
+# require "whois/parser/afilias"
+# require "whois/response"
+# require "whois/errors"
 
 module Whois
   class AfiliasTest < ActiveSupport::TestCase

test/services/whois/parser/afnic_test.rb

@@ -2,9 +2,9 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois/parser/afnic"
-require "whois/response"
-require "whois/errors"
+# require "whois/parser/afnic"
+# require "whois/response"
+# require "whois/errors"
 
 module Whois
   class AFNICTest < ActiveSupport::TestCase

test/services/whois/parser/cira_test.rb

@@ -2,9 +2,9 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois/parser/cira"
-require "whois/response"
-require "whois/errors"
+# require "whois/parser/cira"
+# require "whois/response"
+# require "whois/errors"
 
 module Whois
   class CIRATest < ActiveSupport::TestCase

test/services/whois/parser/io_test.rb

@@ -2,9 +2,9 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois/parser/io"
-require "whois/response"
-require "whois/errors"
+# require "whois/parser/io"
+# require "whois/response"
+# require "whois/errors"
 
 module Whois
   class IOTest < ActiveSupport::TestCase

test/services/whois/parser/neustar_test.rb

@@ -2,9 +2,9 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois/parser/neustar"
-require "whois/response"
-require "whois/errors"
+# require "whois/parser/neustar"
+# require "whois/response"
+# require "whois/errors"
 
 module Whois
   class NeustarTest < ActiveSupport::TestCase

test/services/whois/parser/sonic_test.rb

@@ -2,9 +2,9 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois/parser/sonic"
-require "whois/response"
-require "whois/errors"
+# require "whois/parser/sonic"
+# require "whois/response"
+# require "whois/errors"
 
 module Whois
   class SonicTest < ActiveSupport::TestCase

test/services/whois/parser/verisign_test.rb

@@ -2,9 +2,9 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois/parser/verisign"
-require "whois/response"
-require "whois/errors"
+# require "whois/parser/verisign"
+# require "whois/response"
+# require "whois/errors"
 
 module Whois
   class VerisignTest < ActiveSupport::TestCase

test/services/whois/parser_test.rb

@@ -2,8 +2,8 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois/parser"
-require "whois/errors"
+# require "whois/parser"
+# require "whois/errors"
 
 module Whois
   class ParserTest < ActiveSupport::TestCase

test/services/whois_test.rb

@@ -2,8 +2,8 @@
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
 require "test_helper"
-require "whois"
-require "system_command"
+# require "whois"
+# require "system_command"
 
 module Whois
   class ServiceTest < ActiveSupport::TestCase

test/system/checks_test.rb

@@ -1,7 +1,7 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Jeremy Lecour <jlecour@evolix.fr>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "application_system_test_case"
+# require "application_system_test_case"
 
 class ChecksTest < ApplicationSystemTestCase
   setup do

test/system/users_test.rb

@@ -1,7 +1,7 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "application_system_test_case"
+# require "application_system_test_case"
 
 class UsersTest < ApplicationSystemTestCase
   setup do

test/test_helper.rb

@@ -48,11 +48,11 @@ Capybara.javascript_driver = :headless_chrome
 Capybara.default_driver = :headless_chrome
 
 # Disable Open4 real system calls
-require "open4"
-require "errors"
+# require "open4"
+# require "errors"
 module Open4
   def popen4(*)
-    fail SystemCommandNotAllowedError,
+    fail SystemCommand::NotAllowedError,
       "Real Open4 calls are disabled in test env. Use mock_system_command helper instead."
   end
   alias open4 popen4

test/test_mocks_helper.rb

@@ -1,13 +1,13 @@
 # Copyright (C) 2018 Colin Darie <colin@darie.eu>, 2018 Evolix <info@evolix.fr>
 # License: GNU AGPL-3+ (see full text in LICENSE file)
 
-require "system_command"
+# require "system_command"
 
 module TestMocksHelper
   # rubocop:disable Metrics/MethodLength
   def mock_system_command(program, args, exit_status: 0, stdout: "", stderr: "")
     syscmd = "#{program} #{Array.wrap(args).join(' ')}"
-    result = SystemCommandResult.new(syscmd, exit_status, stdout, stderr)
+    result = SystemCommand::Result.new(syscmd, exit_status, stdout, stderr)
 
     mock = Minitest::Mock.new
     mock.expect :execute, result