diff --git a/app/services/check_logger.rb b/app/services/check_logger.rb index bd0124e..e04b077 100644 --- a/app/services/check_logger.rb +++ b/app/services/check_logger.rb @@ -22,7 +22,7 @@ class CheckLogger check_log.exit_status = result.exit_status check_log.raw_response = result.stdout - if result.exit_status > 0 # rubocop:disable Style/NumericPredicate + if result.exit_status.nil? || result.exit_status > 0 # rubocop:disable Style/NumericPredicate check_log.error = result.stderr check_log.status = :failed end diff --git a/config/schedule.rb b/config/schedule.rb index 27553b1..3d8193d 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -18,10 +18,10 @@ set :output, standard: "log/cron.log" # Learn more: http://github.com/javan/whenever -every 1.day, at: '4:30 am', roles: [:app] do +every 1.day, at: '1:00 am', roles: [:app] do rake "checks:sync_dates:all" end -every 1.day, at: '10:30 am', roles: [:app] do +every 1.day, at: '8:30 am', roles: [:app] do rake "notifications:send_all" end diff --git a/lib/tasks/checks.rake b/lib/tasks/checks.rake index 6703e73..a117d5e 100644 --- a/lib/tasks/checks.rake +++ b/lib/tasks/checks.rake @@ -9,7 +9,7 @@ namespace :checks do end desc "Refresh SSL expiry dates" - task domain: :environment do + task ssl: :environment do process = CheckSSLProcessor.new process.sync_dates end diff --git a/test/services/check_logger_test.rb b/test/services/check_logger_test.rb index cbd1044..29d3f0d 100644 --- a/test/services/check_logger_test.rb +++ b/test/services/check_logger_test.rb @@ -39,6 +39,16 @@ class CheckLoggerTest < ActiveSupport::TestCase assert @logger.check_log.failed? end + test "should log an error when there is not exit status" do + result = SystemCommandResult.new("command", nil, nil, "an error") + @logger.log :after_command, result + + assert_nil @logger.check_log.raw_response + assert_equal "an error", @logger.check_log.error + assert_nil @logger.check_log.exit_status + assert @logger.check_log.failed? + end + test "should log a successful parsed response" do response = OpenStruct.new( domain: "example.fr",