From e09a463bcba29f29324bf9254a31afb349fe342e Mon Sep 17 00:00:00 2001 From: Colin Darie Date: Fri, 6 Jul 2018 12:56:57 +0200 Subject: [PATCH 1/3] Change cron execution hour --- config/schedule.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/schedule.rb b/config/schedule.rb index 27553b1..3d8193d 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -18,10 +18,10 @@ set :output, standard: "log/cron.log" # Learn more: http://github.com/javan/whenever -every 1.day, at: '4:30 am', roles: [:app] do +every 1.day, at: '1:00 am', roles: [:app] do rake "checks:sync_dates:all" end -every 1.day, at: '10:30 am', roles: [:app] do +every 1.day, at: '8:30 am', roles: [:app] do rake "notifications:send_all" end From 4d42c34f4fb4afab50ec1b0c4482cd4b9a67f862 Mon Sep 17 00:00:00 2001 From: Colin Darie Date: Fri, 6 Jul 2018 12:57:07 +0200 Subject: [PATCH 2/3] Fixed ssl sync dates processor task --- lib/tasks/checks.rake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tasks/checks.rake b/lib/tasks/checks.rake index 6703e73..a117d5e 100644 --- a/lib/tasks/checks.rake +++ b/lib/tasks/checks.rake @@ -9,7 +9,7 @@ namespace :checks do end desc "Refresh SSL expiry dates" - task domain: :environment do + task ssl: :environment do process = CheckSSLProcessor.new process.sync_dates end From d98c1241c5845ad8579dceeaaaba1fbd9d8cac6e Mon Sep 17 00:00:00 2001 From: Colin Darie Date: Fri, 6 Jul 2018 12:58:25 +0200 Subject: [PATCH 3/3] Log an error when a system command doesnt have an exit status. Occurred at least 1 time with a check_http. --- app/services/check_logger.rb | 2 +- test/services/check_logger_test.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/services/check_logger.rb b/app/services/check_logger.rb index bd0124e..e04b077 100644 --- a/app/services/check_logger.rb +++ b/app/services/check_logger.rb @@ -22,7 +22,7 @@ class CheckLogger check_log.exit_status = result.exit_status check_log.raw_response = result.stdout - if result.exit_status > 0 # rubocop:disable Style/NumericPredicate + if result.exit_status.nil? || result.exit_status > 0 # rubocop:disable Style/NumericPredicate check_log.error = result.stderr check_log.status = :failed end diff --git a/test/services/check_logger_test.rb b/test/services/check_logger_test.rb index cbd1044..29d3f0d 100644 --- a/test/services/check_logger_test.rb +++ b/test/services/check_logger_test.rb @@ -39,6 +39,16 @@ class CheckLoggerTest < ActiveSupport::TestCase assert @logger.check_log.failed? end + test "should log an error when there is not exit status" do + result = SystemCommandResult.new("command", nil, nil, "an error") + @logger.log :after_command, result + + assert_nil @logger.check_log.raw_response + assert_equal "an error", @logger.check_log.error + assert_nil @logger.check_log.exit_status + assert @logger.check_log.failed? + end + test "should log a successful parsed response" do response = OpenStruct.new( domain: "example.fr",