diff --git a/CHANGELOG.md b/CHANGELOG.md index 445ceb9..cae8d94 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,8 @@ The **patch** part changes is incremented if multiple releases happen the same m ### Fixed +* letsencrypt: Add required check when retrieving certificate. (Avoid TypeError.) + ### Removed ### Security diff --git a/lib/letsencrypt.php b/lib/letsencrypt.php index 8c0d2d4..3cf9dbf 100644 --- a/lib/letsencrypt.php +++ b/lib/letsencrypt.php @@ -157,6 +157,9 @@ class LetsEncrypt { $stream = stream_context_create(array("ssl" => array("capture_peer_cert" => true))); $read = stream_socket_client("ssl://" . $domain . ":443", $errno, $errstr, 10, STREAM_CLIENT_CONNECT, $stream); + if ($read === false) { + return false; + } $cont = stream_context_get_params($read); return $cont; diff --git a/scripts/web-add.sh b/scripts/web-add.sh index 224b2b1..5ec23ba 100755 --- a/scripts/web-add.sh +++ b/scripts/web-add.sh @@ -766,7 +766,7 @@ op_del() { # Deactivate web vhost (apache or nginx) if [ "$WEB_SERVER" == "apache" ]; then - if a2query -s test12 >/dev/null 2&>1; then + if a2query -s "${login}" >/dev/null 2&>1; then a2dissite "${login}.conf" fi rm -f /etc/apache2/sites-available/"$login.conf"