Wrong order of deletion #76

New Issue

Closed

opened 2022-07-01 11:53:53 +02:00 by mtrossevin · 1 comment

mtrossevin commented

2022-07-01 11:53:53 +02:00

Owner

The account deletion part of web-add.sh (which is also used by the web app) delete things in the wrong order.

Indeed, the script delete things in this order:

crontab
web account
account
web account in lxc
account in lxc
alias
ssh permission
home directory
apache vhost
awstats config
fpm config
evoacme config
database

However this isn't the correct order because of the following dependencies.

the apache vhost references both the web account and the home directory so it should be deleted before either.
the awstats config references the home directory so it should be deleted before the home directory
the fpm pool configuration depends on the home directory, the account and the web account being present and cause breakage otherwise so it MUST be deleted before the home directory, the web account (in the lxc container) and the account (in the lxc container)
the ssh config references the account so the permission should be removed before the account

Therefore the correct order of deletion should be (there are other options of course):

crontab (might use a lot of other things but not used by anything else)
apache vhost
awstats config
fpm pool configuration
ssh permission
evoacme config? (might be put almost anywhere after the apache vhost (but not before as it is referenced by the vhost))
web account in lxc
account in lxc
alias
web account
account
home directory
database

edit: typo

The account deletion part of web-add.sh (which is also used by the web app) delete things in the wrong order. Indeed, the script delete things in this order: 1. crontab 2. web account 3. account 4. web account in lxc 5. account in lxc 6. alias 7. ssh permission 8. home directory 9. apache vhost 10. awstats config 11. fpm config 12. evoacme config 13. database However this isn't the correct order because of the following dependencies. - the apache vhost references both the web account and the home directory so it should be deleted *before* either. - the awstats config references the home directory so it should be deleted before the home directory - the fpm pool configuration depends on the home directory, the account and the web account being present and cause breakage otherwise so it ***MUST*** be deleted before the home directory, the web account (in the lxc container) and the account (in the lxc container) - the ssh config references the account so the permission should be removed before the account Therefore the correct order of deletion should be (there are other options of course): 1. crontab (might use a lot of other things but not used by anything else) 2. apache vhost 3. awstats config 4. fpm pool configuration 5. ssh permission 6. evoacme config? (might be put almost anywhere after the apache vhost (but not before as it is referenced by the vhost)) 7. web account in lxc 8. account in lxc 9. alias 10. web account 11. account 12. home directory 13. database edit: typo

mtrossevin changed title from ~~Wrong order of suppression~~ to Wrong order of deletion

2022-07-01 12:07:59 +02:00

lpoujol self-assigned this 2023-02-17 12:29:14 +01:00

lpoujol commented

2023-02-20 10:35:12 +01:00

Owner

Proposed new order in 63dfa3af99 :

Crontab
Vhost & FPM (multi-php)
AWStats (config + cron)
Account (host & container)
/etc/aliases
sshd config (old AllowUsers)
Home directory
SSL/TLS certificate handled by evoacme
MySQL database

Proposed new order in 63dfa3af99e3bbaa728c362c9d3bf3a8cff29a01 : 1. Crontab 1. Vhost & FPM (multi-php) 1. AWStats (config + cron) 1. Account (host & container) 1. /etc/aliases 1. sshd config (old AllowUsers) 1. Home directory 1. SSL/TLS certificate handled by evoacme 1. MySQL database

lpoujol referenced this issue from a commit

2023-02-20 10:35:16 +01:00

web-add.sh > Correct deletion order

lpoujol closed this issue

2023-02-20 10:35:16 +01:00