Shellcheck pass on web-add.sh and --gid fix #1
No reviewers
Labels
No labels
Bug
Doc
Feature
Forge
Mode
Cluster
Mode
MultiPHP
Script
Server
Web
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: evolix/evoadmin-web#1
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "shellcheck-web-add"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Please review! You're probably more familiar with the code than I am.
LGTM but did you try the script with your patch? Is it working well? Nothing broken?
This is a big commit and not atomic, not easy to review.
Are you looking at the unified diff or the individual commits? I
tried to make them as atomic as I could, but yes I'll have to be
more careful in the future.
I've mostly tested vhost creation /
deletion, as well as aliases. And have tested some specific syntax
changes in the shell.
The unified diff a.k.a the full merge request.
The next script I review I'll keep it to one function per pull request if you want. Instead of one commit per shellcheck rule with a unified pull request. These types of linting passes tend to be a bit messy by nature.
True.
I'm OK to merge it.
What about @vlaborie?
Shellcheck pass on web-add.shto Shellcheck pass on web-add.sh and --gid fixLooks good to me and can be merged if it has been properly tested.