evolix
/
evoadmin-web
22
0
Fork 1
Code Issues 31 Pull Requests 4 Releases 1 Wiki Activity

Found useless groupdel in web-add.sh #4

Merged
Ghost merged 1 commits from groupdel-web-add into master 2018-11-29 18:35:17 +01:00
Conversation 5 Commits 1 Files Changed 1 +2 -3
Ghost commented 2018-11-14 21:54:14 +01:00
First-time contributor
Copy Link

Found while working on a support ticket.

Tested on my vm, the commit is pretty self-explanatory.

Found while working on a support ticket. Tested on my vm, the commit is pretty self-explanatory.
benpro was assigned by Ghost 2018-11-14 21:54:14 +01:00
Ghost added the
Script
Bug
 labels 2018-11-14 21:54:14 +01:00
benpro commented 2018-11-15 09:21:47 +01:00
Contributor
Copy Link

It displayed The group 'name' does not exist.?

LGTM.

It displayed `The group 'name' does not exist.`? LGTM.
Ghost commented 2018-11-15 15:20:36 +01:00
Author
First-time contributor
Copy Link

It would say userdel: group 'name' is the primary group of another user and is not removed.

This was fixed by adding a groupdel(1) after deleting the users, but it makes more sense to just delete the second user first. Thus making the logs cleaner, the script easier to read and it's execution more efficient.

It would say `userdel: group 'name' is the primary group of another user and is not removed.` This was fixed by adding a groupdel(1) after deleting the users, but it makes more sense to just delete the second user first. Thus making the logs cleaner, the script easier to read and it's execution more efficient.
👍 1
benpro commented 2018-11-15 15:37:32 +01:00
Contributor
Copy Link

Understood! 👍

Understood! :+1:
Ghost commented 2018-11-29 14:25:27 +01:00
Author
First-time contributor
Copy Link

@vlaborie do you have any objections to me merging this today?

@vlaborie do you have any objections to me merging this today?
Ghost commented 2018-11-29 18:33:45 +01:00
Author
First-time contributor
Copy Link

LGTM

LGTM
Ghost closed this pull request 2018-11-29 18:35:17 +01:00
Ghost deleted branch groupdel-web-add 2018-11-29 18:35:25 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Fixing or reporting bugs

  
Doc

Things that needs to be documented (use and/or dev)

  
Feature

Adding new features

  
Forge

Issues imported from https://forge.evolix.org/projects/evoadmin-web/issues

Archived

  
Mode
Cluster

  
Mode
MultiPHP

  
Script

Code that can be run both on the command line or by evoadmin

  
Server

Server configuration

  
Web

Code that is run on or by the http server.

  
wontfix
No Label
Bug
Doc
Feature
Forge
Mode
Cluster
Mode
MultiPHP
Script
Server
Web
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
benpro
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: evolix/evoadmin-web#4
No description provided.
Delete Branch "groupdel-web-add"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?