Found useless groupdel in web-add.sh #4
No reviewers
Labels
No labels
Bug
Doc
Feature
Forge
Mode
Cluster
Mode
MultiPHP
Script
Server
Web
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: evolix/evoadmin-web#4
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "groupdel-web-add"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found while working on a support ticket.
Tested on my vm, the commit is pretty self-explanatory.
It displayed
The group 'name' does not exist.
?LGTM.
It would say
userdel: group 'name' is the primary group of another user and is not removed.
This was fixed by adding a groupdel(1) after deleting the users, but it makes more sense to just delete the second user first. Thus making the logs cleaner, the script easier to read and it's execution more efficient.
Understood! 👍
@vlaborie do you have any objections to me merging this today?
LGTM