Added add_domain_slave.sh #50

benpro · 2019-03-22T09:48:26+01:00

benpro commented

2019-03-22 09:48:26 +01:00

Script to add a DNS slave zone automatically (on Evolix servers).

lpoujol approved these changes 2019-04-02 10:30:48 +02:00

lpoujol left a comment

I'm not fluent with this area of the project.

As long as you've tested your changes youre good to go :)

Don't forget to document your changes !

I'm not fluent with this area of the project. As long as you've tested your changes youre good to go :) Don't forget to document your changes !

mtrossevin requested changes 2023-11-17 15:15:42 +01:00

mtrossevin left a comment

NAK

scripts/add_domain_slave.sh

					
				@ -0,0 +9,4 @@

				usage() {

				    cat <<EOT

				$0 domain_to_add

				Exemple: $0 mydomain.com

mtrossevin commented

2023-11-17 15:15:28 +01:00

Should be using example.com here too.

scripts/add_domain_slave.sh

					
				@ -0,0 +26,4 @@

				# Connect to $slaveServer and add slave domain.

				stdin=/tmp/empty-in

				stdout=/tmp/empty-out

				result=/tmp/result

mtrossevin commented

2023-11-17 15:14:19 +01:00

Should be using mktemp(1).

Should be using `mktemp(1)`.

scripts/add_domain_slave.sh

					
				@ -0,0 +29,4 @@

				result=/tmp/result

				[[ -e $stdin ]] && rm -f $stdin

				[[ -e $stdout ]] && rm -f $stdout

				empty -f -i $stdin -o $stdout -L $result ssh ${sshUser}@${slaveServer} "sudo /usr/share/scripts/bind-slave-${clientName}.sh"

mtrossevin commented

2023-11-17 15:10:37 +01:00

What is this empty command ?
This require ssh access to the secondary DNS server, even if we did limit access to this one command, this seems like a bad idea.

1. What is this `empty` command ? 2. This require ssh access to the secondary DNS server, even if we did limit access to this one command, this seems like a bad idea.

scripts/add_domain_slave.sh

					
				@ -0,0 +35,4 @@

				echo "$domain" > $stdin

				sleep 2

				# Send mail

				subject="[AUTO-${clientName}] Added slave domain of $webServerName $domain"