WIP: Add the Composer installation for the account being created #55

Closed

Ghost wants to merge 1 commit from composer_install into master

Ghost commented

2019-04-18 17:20:32 +02:00

First-time contributor

That's not ready to be merged yet.

Waiting for your comments about that.

That's not ready to be merged yet. Waiting for your comments about that.

benpro commented

2019-04-18 17:28:27 +02:00

Contributor

Every account will have composer. Shouldn't be optional?

lpoujol commented

2019-04-18 18:11:00 +02:00

Owner

I'm not a huge fan.

If all accounts needs composer in a client case. We could simply use /etc/skel

It has some advantages :

Won't crap the account creation if https://getcomposer.org/installer is unavailable (or slow)
Each account created will start with the same composer version (reproductibility)
user can do composer self-update anyway - it's his responsability

I'm not a huge fan. If *all* accounts needs composer in a client case. We could simply use /etc/skel It has some advantages : - Won't crap the account creation if `https://getcomposer.org/installer` is unavailable (or slow) - Each account created will start with the same composer version (reproductibility) - user can do `composer self-update` anyway - it's his responsability

Ghost commented

2019-04-18 18:33:55 +02:00

Author

First-time contributor

So after talking with lpoujol we decided to follow his idea. We will copy Composer in /etc/skel instead.

I didn't actually know that the whole content of the directory is copied when creating a new Unix account.

So after talking with lpoujol we decided to follow his idea. We will copy Composer in /etc/skel instead. I didn't actually know that the whole content of the directory is copied when creating a new Unix account.

Ghost closed this pull request

2019-05-01 17:58:14 +02:00