From ec994f7e2c4a2e949bc652f5012973946be62134 Mon Sep 17 00:00:00 2001 From: Patrick Marchand Date: Mon, 20 Apr 2020 12:12:51 -0400 Subject: [PATCH] Removed a ignore shellcheck comment in zzz_evobackup and fix warning Since only one PID can be in the PID file, we will never have more than one, we can thus easily quote the variable and remove the shellcheck ignore. --- zzz_evobackup | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/zzz_evobackup b/zzz_evobackup index be36204..e722d44 100755 --- a/zzz_evobackup +++ b/zzz_evobackup @@ -123,9 +123,7 @@ pick_server() { if [ -e "${PIDFILE}" ]; then pid=$(cat "${PIDFILE}") # Does process still exist ? - # ignore check because multiple processes might exist - # shellcheck disable=SC2086 - if kill -0 ${pid} 2> /dev/null; then + if kill -0 "${pid}" 2> /dev/null; then # Killing the childs of evobackup. for ppid in $(pgrep -P "${pid}"); do kill -9 "${ppid}";