init should take the IP and key for the vm

Ghost commented

2018-12-22 00:02:45 +01:00

I dont see why the init command doesnt ask for the IP and key for the jail at the same time it initiates it.

😕 2

benpro commented

2019-01-03 09:34:38 +01:00

Contributor

And I son't see why they should be merged.
You can add a key, then multiple IP address and vice versa.
This suggestion is a no-go for me.

And I son't see why they should be merged. You can add a key, then multiple IP address and vice versa. This suggestion is a no-go for me.

Ghost commented

2019-01-03 16:12:23 +01:00

Author

What is the point of initiating a jail without a key? I understand that not every jail uses the firewall rules though.

benpro commented

2019-01-03 16:19:16 +01:00

Contributor

The point is to handle multiple keys. So, to add your first key, you must invoke bkcltd key. init will create the jail (chroot) only. It make senses.

The point is to handle multiple keys. So, to add your first key, you must invoke `bkcltd key`. `init` will create the jail (chroot) only. It make senses.

Ghost commented

2019-01-03 17:38:05 +01:00

Author

I'm not saying remove the key and ip commands, but making it possible to add them at the same time as you init.

It makes sense to have a jail with >= 1 keys, but does it make sense to have a jail with < 1 key?

In my mind it would do

bkctld init -k /path/to/key [-a ip.address] name-of-jail

I'm not saying remove the `key` and `ip` commands, but making it possible to add them at the same time as you `init`. It makes sense to have a jail with >= 1 keys, but does it make sense to have a jail with < 1 key? In my mind it would do ``` bkctld init -k /path/to/key [-a ip.address] name-of-jail ```

benpro commented

2019-01-03 17:39:43 +01:00

Contributor

I dunno. @vlaborie should make the final decision.

Ghost commented

2019-01-03 17:45:53 +01:00

Author

@vlaborie is it an error state (or undesirable in general) for a jail to have no keys at all?

jlecour commented

2020-04-02 18:50:32 +02:00

Owner

I'm with @benpro here.

Sure it's ultra-rare to have a jail without an SSH key, but nothing prevents from having a less strict SSH config for a given jail.

We could have optional additional arguments for bkctld init to create a jail in one command, but it's a separate issue.

I'm closing this.

I'm with @benpro here. Sure it's ultra-rare to have a jail without an SSH key, but nothing prevents from having a less strict SSH config for a given jail. We could have optional additional arguments for `bkctld init` to create a jail in one command, but it's a separate issue. I'm closing this.

jlecour closed this issue

2020-04-02 18:50:32 +02:00

init should take the IP and key for the vm #1