Obsolete BACKUP_DISK variable ? #70

New issue

Open

opened 2023-12-19 09:52:13 +01:00 by whirigoyen · 1 comment

whirigoyen commented

2023-12-19 09:52:13 +01:00

Owner

Our internal procedure says to set BACKUP_DISK var in /etc/default/bkctld
However, this variable doesn't seems anymore used since commit 0ad1e8d342.

There are also some references left in the repo that should be removed :

$ grep BACKUP_DISK -R .
lib/includes:BACKUP_DISK="${BACKUP_DISK:-}"
test/test_helper.bash:    set_variable "/etc/default/bkctld" "BACKUP_DISK" "/dev/vdb"
test/test_helper.bash:    remove_variable "/etc/default/bkctld" "BACKUP_DISK"

Our internal procedure says to set BACKUP_DISK var in /etc/default/bkctld However, this variable doesn't seems anymore used since commit 0ad1e8d34290c527d6bb48b54c20b18d5bcd67e3. There are also some references left in the repo that should be removed : ``` $ grep BACKUP_DISK -R . lib/includes:BACKUP_DISK="${BACKUP_DISK:-}" test/test_helper.bash: set_variable "/etc/default/bkctld" "BACKUP_DISK" "/dev/vdb" test/test_helper.bash: remove_variable "/etc/default/bkctld" "BACKUP_DISK" ```

jlecour was assigned by whirigoyen

2023-12-19 09:52:21 +01:00

whirigoyen commented

2023-12-19 09:55:37 +01:00

Author

Owner

It looks like BACKUP_DISK has been replaced by :
server/lib/includes:BACKUP_PARTITION="${BACKUP_PARTITION:-/backup}"

BACKUP_PARTITION should be added in server/bkctld.conf

It looks like BACKUP_DISK has been replaced by : `server/lib/includes:BACKUP_PARTITION="${BACKUP_PARTITION:-/backup}"` BACKUP_PARTITION should be added in server/bkctld.conf