WIP: Extract functions for local tasks #65

Hi,

This PR intersects 2 differents goals :

improving the maintainability of the backup script ;
improving the reliability and ability to report the status of the various tasks.

I have extracted the "dump" tasks into dedicated functions.

It helps enabling/disabling them in the local_tasks function, by having a single line comment to add/remove.
It clarifies the list of enabled dump tasks in the local_tasks function.
Having dedicated functions helps future upgrades of the script and/or those functions, thanks to clear boundaries between code sections.
It doesn't reduce the ability to customize those tasks.
It helps having some "support" code, like dealing with dump directories, temporary error files, error management…
each local task has its own "dump directory" with clear names…
a log file containing the Rsync stats is pushed after the main Rsync command (alongside the canary file), to help seeing what has been transferred directly on the backer server.
an mtree is done for each top-level directory and sent to the backup server, for future comparisions

A question remains:

Should we limit the output of the script to errors, or give every step, or keep the last lines of the log file?

Hi, This PR intersects 2 differents goals : 1. improving the maintainability of the backup script ; 2. improving the reliability and ability to report the status of the various tasks. I have extracted the "dump" tasks into dedicated functions. 1. It helps enabling/disabling them in the `local_tasks` function, by having a single line comment to add/remove. 2. It clarifies the list of enabled dump tasks in the `local_tasks` function. 3. Having dedicated functions helps future upgrades of the script and/or those functions, thanks to clear boundaries between code sections. 4. It doesn't reduce the ability to customize those tasks. 5. It helps having some "support" code, like dealing with dump directories, temporary error files, error management… 6. each local task has its own "dump directory" with clear names… 7. a log file containing the Rsync stats is pushed after the main Rsync command (alongside the canary file), to help seeing what has been transferred directly on the backer server. 8. an `mtree` is done for each top-level directory and sent to the backup server, for future comparisions A question remains: Should we limit the output of the script to errors, or give every step, or keep the last lines of the log file?

I have merged the "split-lib" branch.

Now functions are extracted in dedicated library files.

I have merged the "split-lib" branch. Now functions are extracted in dedicated library files.

Labels Milestones

WIP: Extract functions for local tasks #65

Step 1:

Step 2: