evolix/evocheck
evolix/evocheck
21
2
Fork 2
Code Issues 48 Pull requests 5 Releases 37 Wiki Activity

Disable a few shellcheck style warnings

Browse source
This commit is contained in:
Jérémy Lecour 2019-03-23 00:13:04 +01:00
parent a7bfbe0a19
commit 2fdc3338fd
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
evocheck.sh
View file

@ -149,6 +149,7 @@ elif [ "$(uname -s)" = "OpenBSD" ]; then
fi fi
# Source configuration file # Source configuration file
# shellcheck disable=SC1091
test -f /etc/evocheck.cf && . /etc/evocheck.cf test -f /etc/evocheck.cf && . /etc/evocheck.cf
VERBOSE="${VERBOSE:-0}" VERBOSE="${VERBOSE:-0}"
@ -706,6 +707,7 @@ if is_debian; then
# Verification si le système doit redémarrer suite màj kernel. # Verification si le système doit redémarrer suite màj kernel.
if [ "$IS_KERNELUPTODATE" = 1 ]; then if [ "$IS_KERNELUPTODATE" = 1 ]; then
if is_installed linux-image*; then if is_installed linux-image*; then
# shellcheck disable=SC2012
kernel_installed_at=$(date -d "$(ls --full-time -lcrt /boot | tail -n1 | awk '{print $6}')" +%s) kernel_installed_at=$(date -d "$(ls --full-time -lcrt /boot | tail -n1 | awk '{print $6}')" +%s)
last_reboot_at=$(($(date +%s) - $(cut -f1 -d '.' /proc/uptime))) last_reboot_at=$(($(date +%s) - $(cut -f1 -d '.' /proc/uptime)))
if [ "$kernel_installed_at" -gt "$last_reboot_at" ]; then if [ "$kernel_installed_at" -gt "$last_reboot_at" ]; then
@ -878,6 +880,7 @@ if is_debian; then
if [ "$IS_HARDWARERAIDTOOL" = 1 ]; then if [ "$IS_HARDWARERAIDTOOL" = 1 ]; then
if lspci | grep -q 'MegaRAID SAS'; then if lspci | grep -q 'MegaRAID SAS'; then
# shellcheck disable=SC2015
is_installed megacli && { is_installed megaclisas-status || is_installed megaraidsas-status; } \ is_installed megacli && { is_installed megaclisas-status || is_installed megaraidsas-status; } \
|| failed "IS_HARDWARERAIDTOOL" "Mega tools not found" || failed "IS_HARDWARERAIDTOOL" "Mega tools not found"
fi fi
@ -1050,6 +1053,7 @@ if is_debian; then
# If there is no duplicate, uniq will have no output # If there is no duplicate, uniq will have no output
# So, if $tmpOutput is not null, there is a duplicate # So, if $tmpOutput is not null, there is a duplicate
if [ -n "$tmpOutput" ]; then if [ -n "$tmpOutput" ]; then
# shellcheck disable=SC2086
labels=$(echo -n $tmpOutput | tr '\n' ' ') labels=$(echo -n $tmpOutput | tr '\n' ' ')
failed "IS_DUPLICATE_FS_LABEL" "Duplicate labels: $labels" failed "IS_DUPLICATE_FS_LABEL" "Duplicate labels: $labels"
fi fi
@ -1082,6 +1086,7 @@ if is_debian; then
certDir=$(dirname "$live") certDir=$(dirname "$live")
certName=$(basename "$certDir") certName=$(basename "$certDir")
# shellcheck disable=SC2012
lastCertDir=$(ls -ds "${certDir}"/[0-9]* | tail -1) lastCertDir=$(ls -ds "${certDir}"/[0-9]* | tail -1)
lastVersion=$(basename "$lastCertDir") lastVersion=$(basename "$lastCertDir")
@ -1287,6 +1292,7 @@ if [ "$IS_EVOMAINTENANCEUSERS" = 1 ]; then
users=$({ grep "^User_Alias *ADMIN" $sudoers | cut -d= -f2 | tr -d " "; grep "^sudo" /etc/group | cut -d: -f 4; } | tr "," "\n" | sort -u) users=$({ grep "^User_Alias *ADMIN" $sudoers | cut -d= -f2 | tr -d " "; grep "^sudo" /etc/group | cut -d: -f 4; } | tr "," "\n" | sort -u)
fi fi
for user in $users; do for user in $users; do
# shellcheck disable=SC2086
if ! grep -qs "^trap.*sudo.*evomaintenance.sh" ~${user}/.*profile; then if ! grep -qs "^trap.*sudo.*evomaintenance.sh" ~${user}/.*profile; then
failed "IS_EVOMAINTENANCEUSERS" "${user} doesn't have an evomaintenance trap" failed "IS_EVOMAINTENANCEUSERS" "${user} doesn't have an evomaintenance trap"
## let's print an error for each user ## let's print an error for each user