Split every checks in their own files #68

Open
opened 2019-03-13 16:42:35 +01:00 by benpro · 7 comments
Contributor

And like munin plugins, use symbolic links to enable checks.

/usr/share/evocheck/minifirewall.sh
/etc/evocheck/checks/minifirewall.sh →  /usr/share/evocheck/minifirewall.sh
And like munin plugins, use symbolic links to enable checks. ``` /usr/share/evocheck/minifirewall.sh /etc/evocheck/checks/minifirewall.sh → /usr/share/evocheck/minifirewall.sh ```
benpro added the
enhancement
label 2019-03-13 16:42:35 +01:00
benpro added a new dependency 2019-03-13 16:42:58 +01:00

This does introduce the potential of someone editing the symbolic link with sed -i and overwriting it, but I think that can be fixed by making it read only?

This does introduce the potential of someone editing the symbolic link with `sed -i` and overwriting it, but I think that can be fixed by making it read only?
Author
Contributor

Yeah and /usr is already RO most of the time.
Also, nobody should sed -i a check 😧.

Yeah and /usr is already RO most of the time. Also, nobody should `sed -i` a check :anguished:.

Give a man a shovel and he'll dig himself into a hole.

Give a man a shovel and he'll dig himself into a hole.
Owner

IMO evocheck.sh must stay a single readeable shellscript file

IMO evocheck.sh must stay a single readeable shellscript file
Author
Contributor

Would logrotate be one big file?
Would vhosts be one big file?
Would crons be one big file?
Would ansible-roles be one big file?
Would be one big file?

I don't agree and I think we should vote/debate it!

Would logrotate be one big file? Would vhosts be one big file? Would crons be one big file? Would ansible-roles be one big file? Would `…` be one big file? I don't agree and I think we should vote/debate it!
benpro added the
discussion
label 2019-03-21 14:15:16 +01:00

I dont feel like evocheck.sh is particularly readable in the first place..

Modularization is a relatively well proven method of reducing complexity of stuff like development, testing, and deployment.

If this is to be a proper open source project and not just an internal tool, we have to make it simple and secure to add and remove checks. The filesystem has well understood semantics about adding, removing and reading information and we should use that.

I dont feel like evocheck.sh is particularly readable in the first place.. Modularization is a relatively well proven method of reducing complexity of stuff like development, testing, and deployment. If this is to be a proper open source project and not just an internal tool, we have to make it simple and secure to add and remove checks. The filesystem has well understood semantics about adding, removing and reading information and we should use that.

After looking at the code again, I really think this would be a good idea.

After looking at the code again, I really think this would be a good idea.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: evolix/evocheck#68
No description provided.