Ability to modify message #10

Open
opened 2019-04-15 17:06:12 +02:00 by benpro · 4 comments

Sometimes I push enter too fast...
But, after typing your message you'll have:

> Let's continue? [Y,n,i,?] 

I propose to add an e(dit) option to modify your message.

> Let's continue? [Y,e,n,i,?] 
Sometimes I push enter too fast... But, after typing your message you'll have: ``` > Let's continue? [Y,n,i,?] ``` I propose to add an `e(dit)` option to modify your message. ``` > Let's continue? [Y,e,n,i,?] ```
benpro added the
enhancement
label 2019-04-15 17:06:12 +02:00
Owner

Il faudrait utiliser GNU readline à la place de read mais il faut s'assurer que readline soit installé.

Il faudrait utiliser [GNU readline](https://tiswww.case.edu/php/chet/readline/rltop.html#TOCIntroduction) à la place de `read` mais il faut s'assurer que `readline` soit installé.
Owner

It seems that what @benpro is proposing is different than what @bwaegeneire is proposing.

Being able to edit the message before final validation doesn't imply using a different "read". We just need to reenter the message editing function (or something like that).

Being able to edit the message while typing is a more complex subject. We obviously can delete characters from end to beginning, letter by letter, but it would be nice to have "full" navigation with arrows, Ctrl-A. We should verify if read -e does the trick and if so we can easily have a conditional to use if if available.

It seems that what @benpro is proposing is different than what @bwaegeneire is proposing. Being able to edit the message **before final validation** doesn't imply using a different "read". We just need to reenter the message editing function (or something like that). Being able to edit the message **while typing** is a more complex subject. We obviously can delete characters from end to beginning, letter by letter, but it would be nice to have "full" navigation with arrows, Ctrl-A. We should verify if `read -e` does the trick and if so we can easily have a conditional to use if if available.
Owner

Right, I confused the two issues... My bad.

Right, I confused the two issues... My bad.
Owner

This is a good idea, that is compatible with my proposal in #13.
Even if we can navigate in the comment while typing, we can still want to edit it after typing Enter (spelling mistake, change of mind, Enter pushed too fast...).

This is a good idea, that is compatible with my proposal in #13. Even if we can navigate in the comment while typing, we can still want to edit it after typing Enter (spelling mistake, change of mind, Enter pushed too fast...).
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: evolix/evomaintenance#10
No description provided.