evolix/evomaintenance
21
0
Fork 0
Code Issues 10 Pull requests 2 Releases 8 Wiki Activity

Fix session start time detection on Debian 12 #19

Merged
bwaegeneire merged 1 commit from fix-deb12 into master 2024-09-17 14:07:22 +02:00
Conversation 1 Commits 1 Files changed 2 +11
mtrossevin commented 2024-09-16 13:16:00 +02:00
Owner
Copy link

fix #18

From Debian 12 onwards sudo cause a new utmp login record to be created, breaking the expectations of get_begin_date(), causing the wrong time to be detected as the session start time.

Let's move to using loginctl --property=Timestamp show-session $(cat /proc/self/sessionid) on Debian 12 (and up) to get the start time to fix this issue.

(Technically this could be used for Debian 8+.)

fix #18 From Debian 12 onwards `sudo` cause a new `utmp` login record to be created, breaking the expectations of `get_begin_date()`, causing the wrong time to be detected as the session start time. Let's move to using `loginctl --property=Timestamp show-session $(cat /proc/self/sessionid)` on Debian 12 (and up) to get the start time to fix this issue. (Technically this could be used for Debian 8+.)
mtrossevin added the
bug
 label 2024-09-16 13:16:00 +02:00
mtrossevin self-assigned this 2024-09-16 13:16:00 +02:00
mtrossevin added 1 commit 2024-09-16 13:16:00 +02:00 
fix #18
requested reviews from jlecour, bwaegeneire 2024-09-16 13:19:50 +02:00
bwaegeneire commented 2024-09-16 17:07:34 +02:00
Owner
Copy link

LGTM!

LGTM!
removed review request for bwaegeneire 2024-09-16 17:30:54 +02:00
bwaegeneire merged commit 6b8cf29a08 into master 2024-09-17 14:07:22 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
jlecour
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mtrossevin
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/evomaintenance#19
No description provided.
Delete branch "fix-deb12"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?