Fix the problem with semicolon in the details #20

Merged

mgauthier merged 2 commits from fix_semicolon_in_details_problem into master

2024-11-15 15:24:36 +01:00

mgauthier commented

2024-10-29 16:43:06 +01:00

Owner

As per the cURL manual, "quoting must be applied to non-file data if it contains semicolons, leading/trailing spaces or leading double quotes".

mgauthier added the

bug

label 2024-10-29 16:43:06 +01:00

mgauthier added 2 commits 2024-10-29 16:43:07 +01:00

Fix problem with semicolon in the details using double quotes d3178787d8

Double quotes to single quotes and then wrap the whole message string in double quotes 026ac502cf

mgauthier changed title from ~~fix_semicolon_in_details_problem~~ to WIP: fix_semicolon_in_details_problem

2024-10-29 16:43:49 +01:00

mgauthier changed title from ~~WIP: fix_semicolon_in_details_problem~~ to WIP: Fix the problem with semicolon in the details

2024-10-29 16:44:53 +01:00

requested reviews from jlecour, mtrossevin, bwaegeneire

2024-11-08 15:43:10 +01:00

gcolpart commented

2024-11-12 17:22:29 +01:00

Owner

ça semble correct, Go pour pull

mgauthier commented

2024-11-12 22:08:49 +01:00

Author

Owner

@jlecour J'ai testé ceci, mais ça produit le même résultat s'il y a un" dans les détails :

    #API_DETAILS=$(echo "${MESSAGE}" | sed -e "s/\"/\'/g" -e 's/^/\"/g' -e 's/$/\"/g')
    API_DETAILS=$(echo "${MESSAGE}" | sed -e 's/^/\"/g' -e 's/$/\"/g')
    echo "$API_DETAILS" > mesg.temp
    (...)
    -F details="$(cat mesg.temp)")

@jlecour J'ai testé ceci, mais ça produit le même résultat s'il y a un`"` dans les détails : ``` #API_DETAILS=$(echo "${MESSAGE}" | sed -e "s/\"/\'/g" -e 's/^/\"/g' -e 's/$/\"/g') API_DETAILS=$(echo "${MESSAGE}" | sed -e 's/^/\"/g' -e 's/$/\"/g') echo "$API_DETAILS" > mesg.temp (...) -F details="$(cat mesg.temp)") ```

mgauthier changed title from ~~WIP: Fix the problem with semicolon in the details~~ to Fix the problem with semicolon in the details

2024-11-15 15:23:55 +01:00

mgauthier merged commit 87e21dccec into master

2024-11-15 15:24:36 +01:00

mgauthier deleted branch fix_semicolon_in_details_problem

2024-11-15 15:24:36 +01:00

mgauthier referenced this pull request from a commit

2024-11-15 15:24:37 +01:00

Merge pull request 'Fix the problem with semicolon in the details' (#20) from fix_semicolon_in_details_problem into master

removed review requests for mtrossevin, bwaegeneire

2024-11-15 15:24:57 +01:00