error "parameter not set" #13

New issue

Closed

opened 2023-11-22 11:20:02 +01:00 by gcolpart · 3 comments

gcolpart commented

2023-11-22 11:20:02 +01:00

Owner

We should have a proper msg when launching without option:

# /etc/init.d/minifirewall 
/etc/init.d/minifirewall: 1319: 1: parameter not set

We should have a proper msg when launching without option: ``` # /etc/init.d/minifirewall /etc/init.d/minifirewall: 1319: 1: parameter not set ```

mtrossevin commented

2023-11-22 16:18:30 +01:00

Owner

This is already the case, you were using an older version where it wasn't.

mtrossevin closed this issue

2023-11-22 16:18:30 +01:00

mtrossevin added the

invalid

label 2023-11-22 16:18:43 +01:00

mtrossevin commented

2023-11-22 16:21:07 +01:00

Owner

See

Preview has been truncated

 case "${1:-''}" in
     start)
         source_configuration
         check_unpersisted_state
         start
     ;;
     safe-start)
         source_configuration
         check_unpersisted_state
         safe_start
     ;;
     stop)
         source_configuration
         check_unpersisted_state
         stop
     ;;
     status)
         source_configuration
         check_unpersisted_state
         status
     ;;
     reset)
         source_configuration
         check_unpersisted_state
         reset
     ;;
     restart)
         source_configuration
         check_unpersisted_state
         stop
         start
     ;;
     safe-restart)
         source_configuration
         check_unpersisted_state
         stop
         safe_start

More specifically the fallback at the very end which is hit if no argument is passed to minifirewall.

See https://gitea.evolix.org/evolix/minifirewall/src/commit/2bdcf018823b3d796cf0ffac1e13cfe9e0ae28f2/minifirewall#L1257-L1332 More specifically the fallback at the very end which is hit if no argument is passed to minifirewall.

mtrossevin commented

2023-11-22 16:25:46 +01:00

Owner

And this is the case since a600d03ab4 (though the message was worse than it currently is).

And this is the case since a600d03ab4 (though the message was worse than it currently is).