It's used more than once. But indeed we could replace all occurrences of the variable with the function call. Would it be better?
It's the same pattern in other (unchanged) parts of the code.
Shall we replace it with only jail_name="${1}"
, ensuring that the test would then be reached to display the error message & help ?
shellcheck wasn't happy with it (the intial form). An alternative could be something like `printf "%s" "${output}"
We could. It felt easier/simpler to have a separate numbering scheme.
Tomorrow, 24.09 without any changes in the jail structure, it would stay in jail v2 mode. So no need to handle the jail…
Okay.... this is it I guess. While I have others idea in mind, I'll keep those for a next version as this one already introduce lots of changes.
I'm looking forward for a review/comments.