Commit graph

281 commits

Author SHA1 Message Date
Jérémy Lecour 8aadbed4de Don't limit to Lenny
This test doesn't seem to be limited to Lenny, so we should check for 
all backports
2019-03-23 02:36:41 +01:00
Jérémy Lecour c2fda32d0d extract main conditional 2019-03-23 02:36:41 +01:00
Jérémy Lecour 3b8617b20c use grep -s instead of redirecting stderr 2019-03-23 02:36:41 +01:00
Jérémy Lecour 7cb7a47be7 improve readability 2019-03-23 02:36:41 +01:00
Jérémy Lecour 0afdfbf3a1 Use braces instead for command grouping.
It avoids subshells
2019-03-23 02:36:40 +01:00
Jérémy Lecour 9658e531ad quotes 2019-03-23 02:36:40 +01:00
Jérémy Lecour 2267b79618 remove unused IS_TOOMUCHDEBIANSYSMAINT 2019-03-23 02:36:40 +01:00
Jérémy Lecour fc3d2e28cf APACHEMUNIN: muunin config can be in other files 2019-03-23 02:36:40 +01:00
Jérémy Lecour a4c1629912 verbose comments for RAID checks 2019-03-23 02:36:40 +01:00
Jérémy Lecour d51c64d410 reorganize IS_APACHEMUNIN 2019-03-23 02:36:40 +01:00
Jérémy Lecour 3353096ebe don't use a sub shell for IS_REPVOLATILE 2019-03-23 02:36:40 +01:00
Jérémy Lecour 366fc03237 print duplicate labels on a single line 2019-03-23 02:36:40 +01:00
Jérémy Lecour 9b31ab030e fix "is_debian_lenny" 2019-03-23 02:36:40 +01:00
Jérémy Lecour 2ad82591f3 test if it's a file, to ignore directories 2019-03-23 02:36:40 +01:00
Jérémy Lecour c3b4efd71e fix debian version detection for IS_LSBRELEASE 2019-03-23 02:36:40 +01:00
Jérémy Lecour e525141ae4 move VERBOSE block to log comment 2019-03-23 02:36:40 +01:00
Jérémy Lecour 419ecbc10f fix conditions grouping 2019-03-23 02:36:40 +01:00
Jérémy Lecour 367756d6b2 variables extraction 2019-03-23 02:36:40 +01:00
Jérémy Lecour 99ddd1a05c better test ordering 2019-03-23 02:36:40 +01:00
Jérémy Lecour 3e14210a0b extract if 2019-03-23 02:36:40 +01:00
Jérémy Lecour 9dcdd8202e more permissions check with stat 2019-03-23 02:36:40 +01:00
Jérémy Lecour 057cb7026a even more quotes 2019-03-23 02:36:40 +01:00
Jérémy Lecour 0fc9d0921e grep can count occurrences too 2019-03-23 02:36:40 +01:00
Jérémy Lecour ae12b37c7f add verbose comments for IS_BACKPORTSCONF 2019-03-23 02:36:40 +01:00
Jérémy Lecour 830db4743c more quotes 2019-03-23 02:36:40 +01:00
Jérémy Lecour 38b0342d0c use stat instead of ls -l | grep 2019-03-23 02:36:10 +01:00
Jérémy Lecour 00311e8f0e quote 2019-03-23 02:36:10 +01:00
Jérémy Lecour fa79f1d1a8 big cleanup
* tests organization
* shellcheck conventions
* variables extractions
* quotes and indentations
2019-03-23 02:36:10 +01:00
Jérémy Lecour 2c44db77a3 replace `` with $() 2019-03-23 02:30:18 +01:00
Jérémy Lecour 720ea03b0c Add IS_LSBRELEASE check 2019-03-23 02:29:24 +01:00
Jérémy Lecour 36fa3af815 replace old-fashioned tests with functions 2019-03-23 02:29:24 +01:00
Jérémy Lecour d3cb743f76 MINIFW_FILE for Debian Lenny 2019-03-23 02:28:53 +01:00
Jérémy Lecour 1b4b2a2ff8 workaround possibly missing lsb_release command 2019-03-23 02:28:53 +01:00
Jérémy Lecour 9c4a40b585 optimize OS/release/version detection 2019-03-23 02:28:53 +01:00
Jérémy Lecour da2b48d792 no tabs, but 4 spaces 2019-03-21 21:19:53 +01:00
Jérémy Lecour b7ce862073 fix indentation levels 2019-03-21 21:15:48 +01:00
Jérémy Lecour f3caffc9d5 Improve logging with optional verbose comment (#71) 2019-03-21 14:27:34 +01:00
Benoît S. 7cc422974a IS_NOTUPGRADED: Better detection of upgrades
Fix #66
2019-03-05 11:27:53 +01:00
Benoît S. cf8ad6c4d8 Merge branch '62-IS_NOTUPGRADED-quiet-grep' of evolix/evocheck into master 2019-02-22 10:31:38 +01:00
Benoît S. f783d2bb3f Quiet grep by adding -s
Otherwhise it would ouput
`grep: /etc/evolinux/listupgrade.cnf: No such file or directory`.
2019-02-21 15:59:21 +01:00
Benoît S. a6ee33004e Closes #59 IS_MYSQLUTILS: Fixed wrong logic (#60) 2019-02-20 17:52:30 +01:00
Benoît S. 3f0b40e34e Merge branch '54-fixes-IS_LISTCHANGESCONF-verbose-mode' of evolix/evocheck into master 2019-02-19 15:07:24 +01:00
Benoît S. 65c97eb7be Fixes and closes #29 by adding silent grep 2019-02-19 11:24:01 +01:00
Benoît S. 62bcb5a71d Fixes #54 by refactoring IS_LISTCHANGESCONF
Verbose mode previously added was misbehaving.
Also refactored the code for more readability.
2019-02-19 10:43:51 +01:00
Benoît S. 9be91392f3 Merge branch 'IS_EVOLIX_USER-do-not-use-getent' of evolix/evocheck into master 2019-02-14 11:19:32 +01:00
Benoît S. 2fe9d4ea0e Merge branch 'IS_BACKPORTSCONF-really-quiet-grep' of evolix/evocheck into master 2019-02-14 11:19:19 +01:00
Benoît S. 7ccf640e4c Merge branch 'IS_DUPLICATE_FS_LABEL-exclude-EFI_SYSPART' of evolix/evocheck into master 2019-02-14 11:18:57 +01:00
Benoît S. b7c3b3fadc Merge branch 'IS_DUPLICATE_FS_LABEL-add-verbose-mode' of evolix/evocheck into master 2019-02-14 11:18:41 +01:00
Benoît S. 38c8c75248 IS_EVOLIX_USER: Do not use getent
Why? Because of LDAP. It is normal to have an evolix user in LDAP but not in
`/etc/passwd`.
2019-02-12 12:48:28 +01:00
Benoît S. 1aad813663 IS_BACKPORTSCONF: Quiet grep and better readability
Added `-s` to grep to not have error messages like:
`grep: /etc/apt/preferences.d/*: No such file or directory`
And don't use `2>/dev/null` as there is `-s` grep option!

Added if condition for better readability of the code.
2019-02-12 12:38:11 +01:00