v-kaywon
0b135b1529
if not scientific notation, only parse up to decimal_digits
2017-11-21 13:17:39 -08:00
v-susanh
54f1e5e22f
support for non-utf8 locales ( #598 )
...
* support non-utf8 locales
2017-11-20 17:56:45 -08:00
v-kaywon
20480812c2
remove include string in core_stmt.cpp
2017-11-20 16:06:39 -08:00
v-kaywon
acb0300271
change changelog and version.h for 5.1.2-preview
2017-11-17 16:12:57 -08:00
v-kaywon
fc7c4fb89b
return if the length of the decimal string is greater than maxDecimalStrLen
2017-11-17 13:27:45 -08:00
v-kaywon
bb1e1c0168
do not throw an error if the decimal string is ill formed; let SQL Server handle it
2017-11-17 12:30:14 -08:00
v-kaywon
90029e7e54
add test for scientific notation
2017-11-17 10:21:03 -08:00
David Puglielli
01dd22cac2
Merge pull request #595 from david-puglielli/nextrowset-revert
...
Revert nextRowset changes
2017-11-16 22:06:12 -05:00
Jenny Tam
ef45560db0
Modified how to bind parameters when AE is enabled
2017-11-16 10:30:44 -08:00
David Puglielli
633024c22b
Revert next result changes, improve tests
2017-11-15 17:39:00 -08:00
v-kaywon
9acfab9ec2
include vector library
2017-11-15 16:38:27 -08:00
v-kaywon
9d6aba62ce
implement adjustInputPrecision
2017-11-15 16:36:10 -08:00
Jenny Tam
1a2459614e
Adjusted the initial length for string and LOB fields
2017-11-15 11:00:56 -08:00
Jenny Tam
d633691b5b
Raised the initial buffer size and modified tests as per review
2017-11-10 15:04:07 -08:00
Jenny Tam
52b612ece8
Fix to GitHub issue 574
2017-11-09 15:24:08 -08:00
David Puglielli
10aa50ced0
Fixed crash caused by non-freed reference
2017-11-06 15:48:51 -08:00
Jenny Tam
ef144000c3
Fixed the typo in the comment
2017-11-03 12:17:43 -07:00
Jenny Tam
b44a5dd1fb
Modified comments as per review feedback
2017-11-03 11:14:55 -07:00
Jenny Tam
e5a3767089
Added error handling for LOB types as output parameters
2017-11-03 10:00:08 -07:00
v-kaywon
2ce10aceb0
change error messages
2017-10-31 09:41:34 -07:00
v-kaywon
631f80a9af
added error handling for using direct_query and emulate_prepare in a Column Encryption enabled connection
2017-10-26 13:58:38 -07:00
Yuki Wong
779c39abc2
Merge pull request #571 from v-kaywon/AEdecimalprecision
...
fix for right truncation error when precision of the column definition and input is not aligned
2017-10-26 13:43:27 -07:00
v-kaywon
7a496acfbe
change test title in pdo_decimal_precision.phpt and sqlsrv_decimal_precision.phpt
2017-10-20 15:10:56 -07:00
Jenny Tam
f25d5d59dd
update version to 5.1.1
2017-10-19 15:14:02 -07:00
v-kaywon
02e145d988
fix for right truncation error when precision of the column definition and input is not aligned
2017-10-18 18:10:30 -07:00
v-kaywon
6a4f625e56
change encoding
2017-10-18 15:40:58 -07:00
v-kaywon
f2f3bc1ff5
change encoding
2017-10-18 13:08:07 -07:00
v-kaywon
f4c736a073
only change encoding if it is invalid
2017-10-18 12:17:52 -07:00
v-kaywon
b73539c311
remove setting encoding in core_stmt.cpp
2017-10-18 11:17:55 -07:00
v-kaywon
d7212e60cb
change output biging to encoding utf8
2017-10-17 16:11:05 -07:00
v-kaywon
f67240e566
change encoding to converting from long to string to UTF8
2017-10-17 16:02:12 -07:00
v-kaywon
9e847c1ca8
detect appveyor problem
2017-10-17 15:51:41 -07:00
v-kaywon
6b223a77c9
detect appveyor problem
2017-10-17 15:44:52 -07:00
v-kaywon
597d54476e
detect appveyor problem
2017-10-17 15:37:59 -07:00
v-kaywon
3e247c6a25
detect appveyor problem
2017-10-17 15:30:27 -07:00
v-kaywon
98edd5df85
detect appveyor problem
2017-10-17 15:22:00 -07:00
v-kaywon
8397f7b8bf
detect appveyor problem
2017-10-17 15:13:29 -07:00
v-kaywon
b5a0d1f859
cosmetic changes
2017-10-13 15:50:50 -07:00
v-kaywon
c30f2d6100
change encoding to SYSTEM when converting int to string for inout and output param
2017-10-12 11:33:45 -07:00
v-kaywon
a0e886273f
convert long output param to string, then convert back to long if less than max int
2017-10-11 18:03:14 -07:00
Jenny Tam
ce8d444977
Merge pull request #552 from yitam/missingDriver
...
Search for installed ODBC driver(s) in non-Windows env and more error handling when driver option is set
2017-10-03 15:05:49 -07:00
Jenny Tam
002f631ae4
modified comments for sql state
2017-10-03 12:42:19 -07:00
David Puglielli
a1d613054e
Merge pull request #520 from david-puglielli/nextrowset-fix
...
Added empty result set check to nextRowset()
2017-10-03 14:31:56 -04:00
Jenny Tam
afb8167995
modified core_sqlsrv_connect based on review comments
2017-10-02 16:13:32 -07:00
David Puglielli
95f76757d0
Merge branch 'nextrowset-fix' of https://github.com/david-puglielli/msphpsql into nextrowset-fix
2017-10-02 13:47:29 -07:00
David Puglielli
4151f8f5d1
Minor fixes
2017-09-29 20:47:24 -07:00
David Puglielli
4674f58a15
Update stmt.cpp
2017-09-29 16:18:27 -07:00
David Puglielli
9e928672d4
Update pdo_stmt.cpp
2017-09-29 16:17:39 -07:00
Jenny Tam
bbc2701140
Made changes as per review comments
2017-09-29 15:54:34 -07:00
David Puglielli
494527d465
Tweaked tests, added comments per code review comments
2017-09-29 14:30:29 -07:00
Jenny Tam
302f8540c8
Merge branch 'dev' into missingDriver
2017-09-29 11:37:05 -07:00
David Puglielli
3acab1ae0c
Fixed tests and added code comments
2017-09-28 14:16:50 -07:00
Jenny Tam
76e628c963
resumed error handling when driver option is set and added test cases
2017-09-28 13:22:00 -07:00
Yuki Wong
61f881136a
Merge pull request #550 from v-kaywon/fixPODQuoteNul
...
Fix PDO::quote with string containing ASCII NUL character
2017-09-28 12:23:10 -07:00
David Puglielli
d56446c41c
More tiny fixes
2017-09-27 18:08:24 -07:00
David Puglielli
7713b70d1f
Fixed typos again
2017-09-27 17:50:20 -07:00
David Puglielli
d039cf66a7
Fixed typos
2017-09-27 17:18:38 -07:00
David Puglielli
a749010a67
Moved errors back to pdo_stmt and stmt.cpp
2017-09-27 17:01:20 -07:00
Jenny Tam
5189a9eb65
removed the checks for IM002 because of DM inconsistencies
2017-09-27 16:44:51 -07:00
Jenny Tam
0cbc00384c
added more error checking when driver option is set
2017-09-27 15:16:17 -07:00
Jenny Tam
4ea4259af3
Merge branch 'dev' into missingDriver
2017-09-27 09:24:05 -07:00
David Puglielli
66a12d3330
Fixed errant variable name
2017-09-26 18:38:48 -07:00
David Puglielli
68bb42b2cf
Moved check to core_sqlsrv_next_result to avoid suppressing a different error message
2017-09-26 18:33:49 -07:00
Jenny Tam
256e712072
also checked if ODBC driver is set when AE is enabled
2017-09-26 16:38:34 -07:00
David Puglielli
1045ea40a9
fixed conflicts
2017-09-26 16:11:24 -07:00
David Puglielli
270f2b446e
Use core_sqlsrv_has_any_result to check for null results
2017-09-26 16:02:30 -07:00
David Puglielli
be2be4bb27
Merge remote-tracking branch 'upstream/dev' into nextrowset-fix
2017-09-26 15:04:40 -07:00
Jenny Tam
7a10c1ce59
fixed the merged issues
2017-09-25 13:49:36 -07:00
Jenny Tam
2dbdf12b18
searched for ODBC drivers only in non-windows env
2017-09-25 13:37:42 -07:00
Jenny Tam
96a15f3a48
added legacy_stdio_definitions.lib
2017-09-25 12:35:03 -07:00
Jenny Tam
183872818d
added header file
2017-09-25 12:35:03 -07:00
Jenny Tam
674d7c818b
search for installed drivers in win
2017-09-25 12:35:03 -07:00
Jenny Tam
ca257fd2f4
search installed ODBC driver in Unix env
2017-09-25 12:35:02 -07:00
Jenny Tam
15e1bce414
added legacy_stdio_definitions.lib
2017-09-22 17:03:33 -07:00
Jenny Tam
2e9999d176
added header file
2017-09-22 16:58:32 -07:00
Jenny Tam
6fc50c100c
search for installed drivers in win
2017-09-22 16:37:05 -07:00
Jenny Tam
695254c29b
search installed ODBC driver in Unix env
2017-09-22 12:55:38 -07:00
David Puglielli
2c28d0bf31
Update stmt.cpp
2017-09-22 00:13:33 -04:00
David Puglielli
0d06dea2e8
Fixed compile bug
2017-09-21 18:37:23 -07:00
David Puglielli
7046086f60
Fixed test failures by moving logic back to stmt.cpp and pdo_stmt.cpp
2017-09-21 18:27:56 -07:00
David Puglielli
8666ea63c7
Fixed bug for sqlsrv too, sqlsrv test added
2017-09-21 17:55:59 -07:00
v-kaywon
57a41d71e9
fix PDO::quote api when input string contain a NUL ASCII character
2017-09-21 15:59:54 -07:00
v-kaywon
36fef13297
fix handling decimal type with no decimal with always encrypted
2017-09-19 12:48:21 -07:00
Yuki Wong
a47dc0d20f
Merge pull request #534 from v-kaywon/requireSqlTypeError
...
add error handling for using sqlsrv_query without sqltype
2017-09-15 14:20:49 -07:00
Hadis-Fard
4e712ff50a
fixed missign driver error message
2017-09-15 13:13:29 -07:00
v-kaywon
e70ebbaba1
change error message
2017-09-15 11:15:38 -07:00
Hadis-Fard
b037bfa317
constant mars error per review
2017-09-15 09:58:47 -07:00
Hadis-Fard
e97d5c201a
replaced tab with spaces
2017-09-15 09:45:36 -07:00
Hadis-Fard
80b9f9e603
fixes per review comments
2017-09-14 18:21:25 -07:00
v-kaywon
6c5ef7ad9e
add error handling for using sqlsrv_query without sqltype in a column encryption enabled connection
2017-09-14 17:42:28 -07:00
Hadis-Fard
db226aa13c
Merge branch 'AlwaysEncrypted' of https://github.com/Hadis-Fard/msphpsql into AlwaysEncrypted
2017-09-14 16:56:23 -07:00
Hadis-Fard
98100ee892
aded capability to pass driver with/without curly braces
2017-09-14 16:54:59 -07:00
Hadis Fard
8495cb10a6
Merge branch 'AlwaysEncrypted' into AlwaysEncrypted
2017-09-14 15:21:07 -07:00
Hadis-Fard
dfee28f22a
fixed indentations
2017-09-14 12:00:51 -07:00
Hadis-Fard
08ca46116f
changed the order of ODBC drivers
2017-09-14 09:34:48 -07:00
Hadis-Fard
0d25563909
reset the flag after a failed conn
2017-09-14 08:11:40 -07:00
Hadis-Fard
9175241358
added pdo test, fixed issue with missing driver
2017-09-13 19:06:28 -07:00
Jenny Tam
79ee775b81
Updated versions to 5.1.0-preview
2017-09-13 15:34:06 -07:00
Hadis-Fard
d88838a605
fixed mem leak
2017-09-13 09:32:40 -07:00
Hadis-Fard
6f3f578219
fixed mars connection, added test for col enrytion
2017-09-12 19:21:55 -07:00
Hadis-Fard
403d51a4e4
fixed Mars error, added driver option in pdo, added invalid driver error
2017-09-12 13:30:14 -07:00
Hadis-Fard
8a01b6e2f9
placed back setConnAttr after namespace definition
2017-09-12 09:46:22 -07:00
v-kaywon
5fb49b8c77
change typo in error message length
2017-09-12 09:42:46 -07:00
Hadis-Fard
a0e959a6e9
removed driver_version from conn struct
2017-09-11 16:17:24 -07:00
v-kaywon
3ddb8aae78
change conditions for using sql types derived from SQLDescribeParam
2017-09-11 15:41:19 -07:00
v-kaywon
ba7684e8c2
change comment
2017-09-11 13:41:43 -07:00
v-kaywon
f2381ba7b2
change comment
2017-09-11 13:06:20 -07:00
Hadis-Fard
16c5556340
added pooled boolean, fixed linux error
2017-09-11 11:43:52 -07:00
Hadis-Fard
193df5c5b5
added flag and connect using driver set
2017-09-08 17:36:48 -07:00
Hadis-Fard
1abd36b935
passed conn_str to odbc_Connect, removed conn_options
2017-09-08 17:15:31 -07:00
Hadis-Fard
1e61efca7e
refactored conn string funcs, added Driver option
2017-09-08 16:47:43 -07:00
Hadis-Fard
fc7173df11
fixed default driver version, sal annotation, and error messages
2017-09-08 10:28:01 -07:00
David Puglielli
83631cdabc
Added empty result set check to nextRowset()
2017-09-07 15:44:43 -07:00
v-kaywon
376461fab4
fix according to code review
2017-09-07 15:26:46 -07:00
Hadis-Fard
3343d1eb18
fixed crash and error handling
2017-09-06 18:04:55 -07:00
Hadis-Fard
117b2bf777
resolved merge conflicts
2017-09-06 12:46:22 -07:00
Hadis-Fard
f25677e457
refactored odbc connect, added ae connect error
2017-09-06 10:55:08 -07:00
v-kaywon
01c9f22f63
add code for AE insertion
2017-09-05 16:51:40 -07:00
Jenny Tam
d62d434cd0
modified skipif and code based on review
2017-09-01 16:10:44 -07:00
Jenny Tam
58f2068479
conflicts in msodbcsql
2017-09-01 16:10:44 -07:00
Jenny Tam
babaae71e9
added 2 more columns to ksp test table
2017-09-01 16:10:44 -07:00
Jenny Tam
0441af291c
added checks for server version in the tests
2017-09-01 16:10:43 -07:00
Jenny Tam
8c749e981b
added tests for basic error handling
2017-09-01 16:10:42 -07:00
Jenny Tam
cf9bafc826
merged msodbcsql.h
2017-09-01 16:10:42 -07:00
Jenny Tam
15247faae0
Added support for loading a custom keystore provider for Column Encryption
2017-09-01 16:10:42 -07:00
v-kaywon
f7c9f06108
change comment in core_stmt.cpp
2017-09-01 16:10:41 -07:00
v-kaywon
d2fe48c85a
add comment
2017-09-01 16:10:41 -07:00
v-kaywon
96a0943180
refactored AE related code
2017-09-01 16:10:41 -07:00
v-kaywon
4d6aee9b3d
fixed indentation in core_stmt.cpp
2017-09-01 16:10:41 -07:00
v-kaywon
8fe7039b1b
Implementation of fetching AE max columns
2017-09-01 16:10:41 -07:00
v-kaywon
f744b7e515
merge ae code
2017-09-01 16:10:40 -07:00
Hadis-Fard
278a27c3aa
build connection attrs before connect
2017-08-28 16:34:44 -07:00
v-kaywon
ff671fcde3
change comment in core_stmt.cpp
2017-08-16 16:48:09 -07:00
v-kaywon
f8816b16de
add comment
2017-08-14 17:20:11 -07:00
v-kaywon
0100910be1
refactored AE related code
2017-08-14 17:09:49 -07:00
v-kaywon
7a5384650b
fixed indentation in core_stmt.cpp
2017-08-14 11:44:54 -07:00
v-kaywon
22b4817f65
Implementation of fetching AE max columns
2017-08-08 12:03:51 -07:00
David Puglielli
5a3f2ba201
Update version.h
...
Fixed the location of the dash, since pecl does not like dashes it gets included in VER_FILEVERSION_STR instead of SEMVER_PRERELEASE.
2017-07-25 11:44:01 -07:00
v-kaywon
c8c7bfad57
merge ae code
2017-07-25 11:01:00 -07:00
David Puglielli
3f20e0cab0
updated version.h
2017-07-20 16:39:58 -07:00
David Puglielli
c1e7280dc6
Version updated
2017-07-20 11:44:46 -07:00
David Puglielli
9817f4d598
Tests fixed, version updated
2017-07-19 14:43:28 -07:00
David Puglielli
ca4a2d9b7d
changed line endings
2017-07-19 14:10:53 -07:00
David Puglielli
53318fbbdd
new PR for lastInsertID
2017-07-19 14:05:14 -07:00
v-kaywon
925a62891c
Merge pull request #465 from v-kaywon/fix_translate_nonascii_to_binary
...
fix unmatching quoted length and quoted_len in pdo_quote
2017-07-04 17:44:09 -07:00
v-kaywon
49fd20d31c
fix unmatching quoted length and quoted_len in pdo_quote (fix for uninitialized read)
2017-07-04 16:32:35 -07:00
Hadis-Fard
c949793907
updated the version file
2017-07-04 16:17:53 -07:00
v-kaywon
f2510c7d5d
Merge pull request #461 from v-kaywon/moreSAL
...
add more annotations
2017-06-30 16:35:29 -07:00
ulvii
58e8a24b17
Fixing issues reported by binary analysis - Hardening checks ( #460 )
...
* Adding compiler and linker options for hardening check
* Update config.m4
* Adding fstack protector to compiler options
* Detect platform in config.m4
* Removing the newly added linker flag, because its breaking the PDO_SQLSRV load. Creating a backlog item
* Update config.m4
* Update config.m4
* Testing with -O3
* Adding optimization flag to windows config files
* Update config.w32
2017-06-30 16:28:04 -07:00
v-kaywon
f5f5d5e82f
add more annotations
2017-06-30 15:17:14 -07:00
v-kaywon
d2690aad12
Merge branch 'dev' into fix_fortify_warning
2017-06-30 13:01:48 -07:00
v-kaywon
d32250a61f
added in a SAL annotation for pdo_sqlsrv_dbh_quote
2017-06-30 10:59:31 -07:00
v-kaywon
c470d59f07
change back ordering for checking stmt != NULL
2017-06-30 09:38:01 -07:00
v-kaywon
c107a64368
change ordering of != NULL check
2017-06-29 12:53:00 -07:00
v-kaywon
bcff393895
fix versionhelper header
2017-06-29 12:49:00 -07:00
v-kaywon
b78bcf8be3
fix GetVersionExA is Deprecated warning
2017-06-29 12:23:46 -07:00
v-kaywon
fb64892e37
fix inconsistent annotation in get_error_message in util.cpp
2017-06-29 11:53:04 -07:00
v-kaywon
48223ff107
fix for fortify warnings
2017-06-29 10:51:58 -07:00
v-kaywon
f0da33db26
change _In_ to _Inout_ annotation for pdo_dbh and pdo_stmt objects
2017-06-27 15:17:21 -07:00
v-kaywon
28301557d6
change annotation
2017-06-22 16:16:30 -07:00
v-kaywon
7a19a270d1
add more annotation to sal_def.h
2017-06-22 16:06:57 -07:00
v-kaywon
e575b6d341
added annotations to sal_def.h
2017-06-22 14:44:33 -07:00
v-kaywon
bde81001e9
added SAL annotations and fixed warnings
2017-06-22 14:04:34 -07:00
Hadis Fard
219de931fd
updated to RC1
2017-06-20 11:54:53 -07:00
Hadis Kakanejadi Fard
a879e40162
updated version to 4.3 rc
2017-06-20 10:12:23 -07:00
v-kaywon
a97a2f5880
Merge pull request #443 from v-kaywon/fix_leak
...
Fix leak in connection and statement resource in SQLSRV driver
2017-06-19 17:29:28 -07:00
v-kaywon
84ee58cb5f
Merge pull request #426 from v-kaywon/tnir
...
Add TNIR conn option and tests
2017-06-19 17:27:39 -07:00
v-kaywon
c508a84ef1
changed structure of UTF8 data; added comment for fix in source code
2017-06-19 12:55:40 -07:00
v-kaywon
56dcce01b7
Fix indentation in core_sqlsrv.h
2017-06-19 09:58:04 -07:00
v-kaywon
c408f8c294
fix leak in SQLSRV driver: prevent leak in zval containing the connection and statement resource
2017-06-16 15:43:15 -07:00
susanh
fe2a14c798
Merge branch 'macconfig' of https://github.com/lilgreenbird/msphpsql into macconfig
2017-06-16 13:00:20 -07:00
susanh
e7f621e4f9
remove comment about workaround
2017-06-16 12:49:05 -07:00
susanh
f4ae5e1e4c
added MACOSX_DEPLOYMENT_TARGET to not use linker flat_namespace flag
2017-06-15 17:46:04 -07:00
yitam
25e7705249
added a comment for CEKeystoreData
2017-06-08 15:45:22 -07:00
yitam
1afc509125
removed unnecessary definitions
2017-06-08 15:21:50 -07:00
yitam
7c105ac08e
added a comment about this file being a subset
2017-06-08 12:02:12 -07:00
yitam
74800c993c
fixed CEKeystoreProvider interface
2017-06-08 11:59:34 -07:00
yitam
48478125e0
Updated odbc header constants
2017-06-08 09:33:37 -07:00
v-kaywon
208cc4a078
Add TNIR conn option and tests
2017-06-07 13:53:04 -07:00
Hadis Kakanejadi Fard
e0a65cd0a5
reverted m4 files
2017-05-24 12:45:42 -07:00
Hadis Kakanejadi Fard
7ffa4d470a
added the header to m4 and updated SQLSRV headers to 4.2
2017-05-24 10:09:46 -07:00
Hadis Kakanejadi Fard
d74e4083f2
updated headers versions to 4.2
2017-05-24 10:05:32 -07:00
Hadis Kakanejadi Fard
3577a9281a
updated header files to 4.2
2017-05-24 10:01:44 -07:00
yitam
ae9957d684
revert indentation
2017-05-18 13:53:03 -07:00
yitam
52cf72edf9
indentation
2017-05-18 13:24:56 -07:00
yitam
a0b6d5644b
update version
2017-05-18 13:08:26 -07:00
Hadis Fard
29bb60282d
Merge pull request #399 from Hadis-Fard/dev
...
sql variant support
2017-05-18 13:01:45 -07:00
David Puglielli
a88b187f50
Removed ODBCVER #define
2017-05-17 14:59:32 -07:00
Hadis Fard
b31ee170f3
fixed indentations
2017-05-17 13:52:22 -07:00
Hadis Kakanejadi Fard
42ebf9465d
removed sqlsrv variant const
2017-05-16 15:54:13 -07:00
Hadis Kakanejadi Fard
dba7ba4365
added variant const
2017-05-16 15:53:40 -07:00
David Puglielli
ddab6d3f9d
Removed more unneeded code - MPLAT_UNIX defines and unnecessary typedefs
2017-05-16 15:47:32 -07:00
David Puglielli
674fce0ded
Removed extraneous comments
2017-05-15 16:30:05 -07:00
David Puglielli
a297fe0c54
Removed unused xplat functions
2017-05-15 16:22:58 -07:00
Hadis Kakanejadi Fard
5d4ca446fc
Merge branch 'dev' of https://github.com/Microsoft/msphpsql into dev
2017-05-15 14:19:49 -07:00
Hadis Kakanejadi Fard
7904bddb6e
added sql_variant const
2017-05-15 14:19:36 -07:00
v-kaywon
4537021d1b
Merge pull request #395 from v-kaywon/fix_uninit_read
...
fix uninitialized read if pos of string parser is -1
2017-05-12 16:39:26 -07:00
v-kaywon
8de9669b39
get start_pos out of while loop
2017-05-12 16:02:34 -07:00
David Puglielli
c846076c53
Removed extraneous null terminator that caused Address Sanitizer to complain
2017-05-12 13:50:13 -07:00
v-kaywon
9e3252d4f4
fix uninitialized read if pos of string parser is -1
2017-05-12 10:56:26 -07:00