evolix/ansible-roles
22
2
Fork 2
Code Issues 61 Pull requests 18 Releases 33 Wiki Activity

Quote a variable in zz_evobackup.default.sh.j2
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse source 
This allows us to remove the shellcheck ignore warning comment and puts it in line with upstream. Apparently, the file can only contain one PID, so it's okay to quote the variable.
This commit is contained in:
Patrick Marchand 2020-04-20 18:16:39 +02:00
parent daa97a2314
commit 7173fc06ea
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
evobackup-client/templates/zzz_evobackup.default.sh.j2
View file

@ -124,9 +124,7 @@ pick_server() {
if [ -e "${PIDFILE}" ]; then if [ -e "${PIDFILE}" ]; then
pid=$(cat "${PIDFILE}") pid=$(cat "${PIDFILE}")
# Does process still exist ? # Does process still exist ?
# ignore check because multiple processes might exist if kill -0 "${pid}" 2> /dev/null; then
# shellcheck disable=SC2086
if kill -0 ${pid} 2> /dev/null; then
# Killing the childs of evobackup. # Killing the childs of evobackup.
for ppid in $(pgrep -P "${pid}"); do for ppid in $(pgrep -P "${pid}"); do
kill -9 "${ppid}"; kill -9 "${ppid}";