evolix/ansible-roles
22
2
Fork 2
Code Issues 61 Pull requests 18 Releases 33 Wiki Activity

minifirewall: fix warnings ansible-lint

Browse source
This commit is contained in:
Jérémy Lecour 2020-01-08 17:19:13 +01:00 committed by Jérémy Lecour
parent f79b30eeb4
commit bf7de332ea
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -62,6 +62,7 @@ The **patch** part changes incrementally at each release.
### Fixed ### Fixed
* evoadmin-web: Put the php config at the right place for Buster * evoadmin-web: Put the php config at the right place for Buster
* lxc-php: Don't remove the default pool * lxc-php: Don't remove the default pool
* minifirewall: fix warnings ansible-lint
* nginx: fix munin fcgi not working (missing chmod 660 on logs) * nginx: fix munin fcgi not working (missing chmod 660 on logs)
* php: add missing handler for php7.3-fpm * php: add missing handler for php7.3-fpm
* roundcube: fix typo for roundcube vhost * roundcube: fix typo for roundcube vhost

7
minifirewall/tasks/config.yml
View file

@ -37,9 +37,12 @@
line: "# END ANSIBLE MANAGED BLOCK FOR IPS" line: "# END ANSIBLE MANAGED BLOCK FOR IPS"
insertafter: '^PRIVILEGIEDIPS=' insertafter: '^PRIVILEGIEDIPS='
- fail: - name: Verify that at least 1 trusted IP is provided
assert:
that:
- minifirewall_trusted_ips != []
msg: You must provide at least 1 trusted IP msg: You must provide at least 1 trusted IP
when: minifirewall_trusted_ips == []
- debug: - debug:
msg: "Warning: minifirewall_trusted_ips='0.0.0.0/0', the firewall is useless!" msg: "Warning: minifirewall_trusted_ips='0.0.0.0/0', the firewall is useless!"
when: minifirewall_trusted_ips == ["0.0.0.0/0"] when: minifirewall_trusted_ips == ["0.0.0.0/0"]

3
minifirewall/tasks/main.yml
View file

@ -1,6 +1,7 @@
--- ---
- set_fact: - name: Compose minifirewall_restart_handler_name variable
set_fact:
minifirewall_restart_handler_name: "{{ minifirewall_restart_if_needed | ternary('restart minifirewall', 'restart minifirewall (noop)') }}" minifirewall_restart_handler_name: "{{ minifirewall_restart_if_needed | ternary('restart minifirewall', 'restart minifirewall (noop)') }}"
- include: install.yml - include: install.yml