keepalived: change exit code (warning if runnin but not on expected state ; critical if not running)

CHANGELOG.md

@@ -40,6 +40,7 @@ The **patch** part changes is incremented if multiple releases happen the same m
 * squid: whitelist deb.freexian.com
 * varnish: better package facts usage with check mode and tags
 * varnish: systemd override depends on Varnish version instead of Debian version
+* keepalived: change exit code (warning if runnin but not on expected state ; critical if not running)
 
 ### Fixed
 

keepalived/files/check_keepalived

@@ -18,35 +18,38 @@ MASTER='true'
 # checking if there are alive keepalived processes so we can trust the content of the notify 'state' file
 KEEPALIVENUM=`ps uax|grep '/usr/sbin/keepalived'|grep -v grep|wc -l|tr -d "\n"`
 
-if [ $KEEPALIVENUM -gt 0 ]; then
+if [ ${KEEPALIVENUM} -gt 0 ]; then
 
   KEEPALIVESTATE=`cat /var/run/keepalive.state`
 
-  if [ "$MASTER" == "true" ]; then
+  if [ "${MASTER}" == "true" ]; then
 
-    if [[ $KEEPALIVESTATE == *"MASTER"* ]];then
+    if [[ ${KEEPALIVESTATE} == *"MASTER"* ]];then
-      echo $KEEPALIVESTATE
+      echo "OK - ${KEEPALIVESTATE}"
       exit 0
     fi
 
-    if [[ $KEEPALIVESTATE == *"BACKUP"* ]];then
+    if [[ ${KEEPALIVESTATE} == *"BACKUP"* ]];then
-      echo $KEEPALIVESTATE
+      echo "WARNING - ${KEEPALIVESTATE}"
-      exit 2
+      exit 1
     fi
 
   else
 
-    if [[ $KEEPALIVESTATE == *"BACKUP"* ]];then
+    if [[ ${KEEPALIVESTATE} == *"BACKUP"* ]];then
-      echo $KEEPALIVESTATE
+      echo "OK - ${KEEPALIVESTATE}"
       exit 0
     fi
 
-    if [[ $KEEPALIVESTATE == *"MASTER"* ]];then
+    if [[ ${KEEPALIVESTATE} == *"MASTER"* ]];then
-      echo $KEEPALIVESTATE
+      echo "WARNING - ${KEEPALIVESTATE}"
-      exit 2
+      exit 1
     fi
 
   fi
+else
+    echo "CRITICAL - keepalived is not running"
+    exit 2
 fi
 
 echo "Keepalived is in UNKNOWN state"