WIP: Replace the `include` module with `include_tasks` or `import_tasks` #147

Draft

mtrossevin wants to merge 1 commit from replace_include into unstable

mtrossevin commented

2022-03-02 13:05:50 +01:00

Owner

The behaviour of the include module is badly defined (it try to choose
between statically importing the tasks and dynamically including them)
and can cause problems depending on any number of constraints (mostly if
it choose the wrong behaviour).

Replace it with the import_tasks (always statically import tasks) unless
the include is in a loop in which case we replace it with
include_tasks (always dynamically include tasks).

The behaviour of the `include` module is badly defined (it try to choose between statically importing the tasks and dynamically including them) and can cause problems depending on any number of constraints (mostly if it choose the wrong behaviour). Replace it with the `import_tasks` (always statically import tasks) unless the `include` is in a loop in which case we replace it with `include_tasks` (always dynamically include tasks).

mtrossevin commented

2022-03-02 13:14:19 +01:00

Author

Owner

We also replace include_role with import_role where relevant (so if the include_role itself isn't looped) as it is more efficient and make the tasks actually appear in ansible-playbook --list-tasks, it result in different behaviour where tags are concerned (they are applied on the imported tasks instead of only on the include_role) but I believe it is what we actually want most of the time (with remount-usr).

We also replace `include_role` with `import_role` where relevant (so if the `include_role` itself isn't looped) as it is more efficient and make the tasks actually appear in `ansible-playbook --list-tasks`, it result in different behaviour where tags are concerned (they are applied on the imported tasks instead of only on the `include_role`) but I believe it is what we actually want most of the time (with remount-usr).

mtrossevin force-pushed replace_include from 542292e0f3 to 73b7eff126

2022-03-02 13:36:06 +01:00

Compare

mtrossevin force-pushed replace_include from 73b7eff126 to 0a968e831d

2022-03-02 17:14:40 +01:00

Compare

mtrossevin force-pushed replace_include from 0a968e831d to 356f4e3c2b

2022-03-04 16:20:07 +01:00

Compare

mtrossevin commented

2022-03-04 16:22:45 +01:00

Author

Owner

We also replace include_role with import_role where relevant (so if the include_role itself isn't looped) as it is more efficient and make the tasks actually appear in ansible-playbook --list-tasks, it result in different behaviour where tags are concerned (they are applied on the imported tasks instead of only on the include_role) but I believe it is what we actually want most of the time (with remount-usr).

After a few tests, that cause problems with handlers with the same name in different roles, so I reverted that change (should have made a different commit).

> We also replace `include_role` with `import_role` where relevant (so if the `include_role` itself isn't looped) as it is more efficient and make the tasks actually appear in `ansible-playbook --list-tasks`, it result in different behaviour where tags are concerned (they are applied on the imported tasks instead of only on the `include_role`) but I believe it is what we actually want most of the time (with remount-usr). After a few tests, that cause problems with handlers with the same name in different roles, so I reverted that change (should have made a different commit).

mtrossevin force-pushed replace_include from 356f4e3c2b to f49ffb1c2d

2022-03-07 09:27:50 +01:00

Compare